search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Overwrite SonataAdminBundle translation .xliff file it's not working ! #6879

Closed askuiop closed 3 years ago

askuiop commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.89.1 3.89.1 The missing Symfony Admin Generator sonata-project/block-bundle 4.5.0 4.5.0 Symfony SonataBlockBundle sonata-project/cache 2.1.1 2.1.1 Cache library sonata-project/doctrine-extensions 1.11.0 1.11.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 3.29.0 3.29.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.5.1 2.5.1 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/twig-extensions 1.5.1 1.5.1 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v4.4.19 v5.2.3 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v4.4.19 v5.2.3 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/cache v4.4.19 v5.2.3 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.2.0 v2.2.0 Generic abstractions related to caching symfony/config v4.4.19 v5.2.3 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v4.4.19 v5.2.3 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v4.4.19 v5.2.3 Converts CSS selectors to XPath expressions symfony/debug v4.4.19 v4.4.19 Provides tools to ease debugging PHP code symfony/debug-bundle v4.4.19 v5.2.3 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework symfony/debug-pack v1.0.9 v1.0.9 A debug pack for Symfony projects symfony/dependency-injection v4.4.19 v5.2.3 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.2.0 v2.2.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v4.4.19 v5.2.3 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v4.4.19 v5.2.3 Eases DOM navigation for HTML and XML documents symfony/dotenv v4.4.19 v5.2.3 Registers environment variables from a .env file symfony/error-handler v4.4.19 v5.2.3 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v4.4.19 v5.2.3 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v1.1.9 v2.2.0 Generic abstractions related to dispatching event symfony/expression-language v4.4.19 v5.2.3 Provides an engine that can compile and evaluate expressions symfony/filesystem v4.4.19 v5.2.3 Provides basic utilities for the filesystem symfony/finder v4.4.19 v5.2.3 Finds files and directories via an intuitive fluent interface symfony/flex v1.12.2 v1.12.2 Composer plugin for Symfony symfony/form v4.4.19 v5.2.3 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v4.4.19 v5.2.3 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v4.4.19 v5.2.3 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.3.1 v2.3.1 Generic abstractions related to HTTP clients symfony/http-foundation v4.4.19 v5.2.3 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v4.4.19 v5.2.3 Provides a structured process for converting a Request into a Response symfony/inflector v4.4.19 v5.2.3 Converts words between their singular and plural forms (English only) symfony/intl v4.4.19 v5.2.3 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mailer v4.4.19 v5.2.3 Helps sending emails symfony/maker-bundle v1.29.1 v1.29.1 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerpl... symfony/mime v4.4.19 v5.2.3 Allows manipulating MIME messages symfony/monolog-bridge v4.4.19 v5.2.3 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.6.0 v3.6.0 Symfony MonologBundle symfony/options-resolver v4.4.19 v5.2.3 Provides an improved replacement for the array_replace PHP function symfony/orm-pack v2.1.0 v2.1.0 A pack for the Doctrine ORM symfony/phpunit-bridge v5.2.3 v5.2.3 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.22.1 v1.22.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.22.1 v1.22.1 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.22.1 v1.22.1 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.22.1 v1.22.1 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.22.1 v1.22.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/process v4.4.19 v5.2.3 Executes commands in sub-processes symfony/profiler-pack v1.0.5 v1.0.5 A pack for the Symfony web profiler symfony/property-access v4.4.19 v5.2.3 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v4.4.19 v5.2.3 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v4.4.19 v5.2.3 Provides integration for ProxyManager with various Symfony components symfony/routing v4.4.19 v5.2.3 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.1.1 v3.1.1 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v4.4.19 v5.2.3 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v4.4.19 v5.2.3 Symfony Security Component - Core Library symfony/security-csrf v4.4.19 v5.2.3 Symfony Security Component - CSRF Library symfony/security-guard v4.4.19 v5.2.3 Symfony Security Component - Guard symfony/security-http v4.4.19 v5.2.3 Symfony Security Component - HTTP Integration symfony/serializer v4.4.19 v5.2.3 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML a... symfony/serializer-pack v1.0.4 v1.0.4 A pack for the Symfony serializer symfony/service-contracts v2.2.0 v2.2.0 Generic abstractions related to writing services symfony/stopwatch v4.4.19 v5.2.3 Provides a way to profile code symfony/string v5.2.3 v5.2.3 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/test-pack v1.0.7 v1.0.7 A pack for functional and end-to-end testing within a Symfony app symfony/translation v4.4.19 v5.2.3 Provides tools to internationalize your application symfony/translation-contracts v2.3.0 v2.3.0 Generic abstractions related to translation symfony/twig-bridge v4.4.19 v5.2.3 Provides integration for Twig with various Symfony components symfony/twig-bundle v4.4.19 v5.2.3 Provides a tight integration of Twig into the Symfony full-stack framework symfony/twig-pack v1.0.1 v1.0.1 A Twig pack for Symfony projects symfony/validator v4.4.19 v5.2.3 Provides tools to validate values symfony/var-dumper v4.4.19 v5.2.3 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v4.4.19 v5.2.3 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v4.4.19 v5.2.3 Manages links between resources symfony/web-profiler-bundle v4.4.19 v5.2.3 Provides a development tool that gives detailed information about the execution of any request symfony/yaml v4.4.19 v5.2.3 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.3.16 (cli) (built: Apr 13 2020 13:43:36) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.16, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.16, Copyright (c) 1999-2018, by Zend Technologies

Subject

Overwrite SonataAdminBundle.**.xliff doesn't work ! https://symfony.com/doc/current/bundles/override.html#translations

Steps to reproduce

Override the translations defined in the /vendor/sonata-project/admin-bundle/src/Resources/translations/SonataAdminBundle.xx.xliff file , create a /translations/SonataAdminBundle.xx.yml file. It works in my old project with symfony 3.3 and SonataAdminBundle 3.35.2, but in new version it doesn't work !

Expected results

overwrite SonataAdminBundle translations.

Actual results

New .xliff file overwrite doesn't work. cache:clear works fine and no error. but when I run command:

$ bin/console translation:update --force en -v
Translation Messages Extractor and Dumper
=========================================

// Generating "en" translation files for "default directory"

// Parsing templates...

In MenuFactory.php line 28:

[TypeError]
Argument 1 passed to Knp\Menu\MenuFactory::createItem() must be of the type string, null given, called in <my-project>/vendor/knplabs/knp-menu/src/Knp/Menu/MenuI
tem.php on line 356

Exception trace:
at <my-project>/vendor/knplabs/knp-menu/src/Knp/Menu/MenuFactory.php:28
Knp\Menu\MenuFactory->createItem() at <my-project>/vendor/knplabs/knp-menu/src/Knp/Menu/MenuItem.php:356
Knp\Menu\MenuItem->addChild() at <my-project>/vendor/sonata-project/admin-bundle/src/Admin/BreadcrumbsBuilder.php:131
Sonata\AdminBundle\Admin\BreadcrumbsBuilder->buildBreadcrumbs() at <my-project>/vendor/sonata-project/admin-bundle/src/Admin/BreadcrumbsBuilder.php:56
Sonata\AdminBundle\Admin\BreadcrumbsBuilder->getBreadcrumbs() at <my-project>/vendor/sonata-project/admin-bundle/src/Translator/Extractor/AdminExtractor.php:111
Sonata\AdminBundle\Translator\Extractor\AdminExtractor->extract() at <my-project>/vendor/symfony/translation/Extractor/ChainExtractor.php:56
Symfony\Component\Translation\Extractor\ChainExtractor->extract() at <my-project>/vendor/symfony/framework-bundle/Command/TranslationUpdateCommand.php:226
Symfony\Bundle\FrameworkBundle\Command\TranslationUpdateCommand->execute() at <my-project>/vendor/symfony/console/Command/Command.php:255
Symfony\Component\Console\Command\Command->run() at <my-project>/vendor/symfony/console/Application.php:1027
Symfony\Component\Console\Application->doRunCommand() at <my-project>/vendor/symfony/framework-bundle/Console/Application.php:97
Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at <my-project>/vendor/symfony/console/Application.php:273
Symfony\Component\Console\Application->doRun() at <my-project>/vendor/symfony/framework-bundle/Console/Application.php:83
Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at <my-project>/vendor/symfony/console/Application.php:149
Symfony\Component\Console\Application->run() at <my-project>/bin/console:42
VincentLanglet commented 3 years ago

The error seems pretty clear and seems to have nothing related with the translations. createItem(null) is called.

What is your yaml config ?

askuiop commented 3 years ago

@VincentLanglet I set a new project for test: https://github.com/sonata-project/SonataAdminBundle/issues/6881