I set a new project for test: overwrite SonataAdminBundle translation .xliff file it's not working !

askuiop commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.89.1 3.89.1 The missing Symfony Admin Generator sonata-project/block-bundle 4.5.0 4.5.0 Symfony SonataBlockBundle sonata-project/cache 2.1.1 2.1.1 Cache library sonata-project/doctrine-extensions 1.11.0 1.11.0 Doctrine2 behavioral extensions sonata-project/exporter 2.5.1 2.5.1 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/twig-extensions 1.5.1 1.5.1 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset symfony/browser-kit symfony/cache symfony/cache-contracts symfony/config symfony/console symfony/css-selector symfony/debug symfony/debug-bundle symfony/dependency-injection symfony/deprecation-contracts symfony/doctrine-bridge symfony/dom-crawler symfony/dotenv symfony/error-handler symfony/event-dispatcher symfony/event-dispatcher-contracts symfony/expression-language symfony/filesystem symfony/finder symfony/flex symfony/form symfony/framework-bundle symfony/http-client symfony/http-client-contracts symfony/http-foundation symfony/http-kernel symfony/inflector symfony/intl symfony/mailer symfony/maker-bundle symfony/mime symfony/monolog-bridge symfony/monolog-bundle symfony/options-resolver symfony/phpunit-bridge symfony/polyfill-intl-grapheme symfony/polyfill-intl-icu symfony/polyfill-intl-idn symfony/polyfill-intl-normalizer symfony/polyfill-mbstring symfony/polyfill-php72 symfony/polyfill-php73 symfony/polyfill-php80 symfony/process symfony/property-access symfony/property-info symfony/proxy-manager-bridge symfony/routing symfony/security-acl symfony/security-bundle symfony/security-core symfony/security-csrf symfony/security-guard symfony/security-http symfony/serializer symfony/service-contracts symfony/stopwatch symfony/string symfony/translation symfony/translation-contracts symfony/twig-bridge symfony/twig-bundle symfony/validator symfony/var-dumper symfony/var-exporter symfony/web-link symfony/web-profiler-bundle symfony/yaml ``` v4.4.19 v5.2.3 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files v4.4.19 v5.2.3 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically v4.4.19 v5.2.3 Provides an extended PSR-6, PSR-16 (and tags) implementation v2.2.0 v2.2.0 Generic abstractions related to caching v4.4.19 v5.2.3 Helps you find, load, combine, autofill and validate configuration values of any kind v4.4.19 v5.2.3 Eases the creation of beautiful and testable command line interfaces v4.4.19 v5.2.3 Converts CSS selectors to XPath expressions v4.4.19 v4.4.19 Provides tools to ease debugging PHP code v4.4.19 v5.2.3 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework v4.4.19 v5.2.3 Allows you to standardize and centralize the way objects are constructed in your application v2.2.0 v2.2.0 A generic function and convention to trigger deprecation notices v4.4.19 v5.2.3 Provides integration for Doctrine with various Symfony components v4.4.19 v5.2.3 Eases DOM navigation for HTML and XML documents v4.4.19 v5.2.3 Registers environment variables from a .env file v4.4.19 v5.2.3 Provides tools to manage errors and ease debugging PHP code v4.4.19 v5.2.3 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them v1.1.9 v2.2.0 Generic abstractions related to dispatching event v4.4.19 v5.2.3 Provides an engine that can compile and evaluate expressions v4.4.19 v5.2.3 Provides basic utilities for the filesystem v4.4.19 v5.2.3 Finds files and directories via an intuitive fluent interface v1.12.2 v1.12.2 Composer plugin for Symfony v4.4.19 v5.2.3 Allows to easily create, process and reuse HTML forms v4.4.19 v5.2.3 Provides a tight integration between Symfony components and the Symfony full-stack framework v4.4.19 v5.2.3 Provides powerful methods to fetch HTTP resources synchronously or asynchronously v2.3.1 v2.3.1 Generic abstractions related to HTTP clients v4.4.19 v5.2.3 Defines an object-oriented layer for the HTTP specification v4.4.19 v5.2.3 Provides a structured process for converting a Request into a Response v4.4.19 v5.2.3 Converts words between their singular and plural forms (English only) v4.4.19 v5.2.3 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library v4.4.19 v5.2.3 Helps sending emails v1.29.1 v1.29.1 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerpl... v4.4.19 v5.2.3 Allows manipulating MIME messages v4.4.19 v5.2.3 Provides integration for Monolog with various Symfony components v3.6.0 v3.6.0 Symfony MonologBundle v4.4.19 v5.2.3 Provides an improved replacement for the array_replace PHP function v5.2.3 v5.2.3 Provides utilities for PHPUnit, especially user deprecation notices management v1.22.1 v1.22.1 Symfony polyfill for intl's grapheme_* functions v1.22.1 v1.22.1 Symfony polyfill for intl's ICU-related data and classes v1.22.1 v1.22.1 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions v1.22.1 v1.22.1 Symfony polyfill for intl's Normalizer class and related functions v1.22.1 v1.22.1 Symfony polyfill for the Mbstring extension v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions v4.4.19 v5.2.3 Executes commands in sub-processes v4.4.19 v5.2.3 Provides functions to read and write from/to an object or array using a simple string notation v4.4.19 v5.2.3 Extracts information about PHP class' properties using metadata of popular sources v4.4.19 v5.2.3 Provides integration for ProxyManager with various Symfony components v4.4.19 v5.2.3 Maps an HTTP request to a set of configuration variables v3.1.1 v3.1.1 Symfony Security Component - ACL (Access Control List) v4.4.19 v5.2.3 Provides a tight integration of the Security component into the Symfony full-stack framework v4.4.19 v5.2.3 Symfony Security Component - Core Library v4.4.19 v5.2.3 Symfony Security Component - CSRF Library v4.4.19 v5.2.3 Symfony Security Component - Guard v4.4.19 v5.2.3 Symfony Security Component - HTTP Integration v4.4.19 v5.2.3 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML a... v2.2.0 v2.2.0 Generic abstractions related to writing services v4.4.19 v5.2.3 Provides a way to profile code v5.2.3 v5.2.3 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way v4.4.19 v5.2.3 Provides tools to internationalize your application v2.3.0 v2.3.0 Generic abstractions related to translation v4.4.19 v5.2.3 Provides integration for Twig with various Symfony components v4.4.19 v5.2.3 Provides a tight integration of Twig into the Symfony full-stack framework v4.4.19 v5.2.3 Provides tools to validate values v4.4.19 v5.2.3 Provides mechanisms for walking through any arbitrary PHP variable v4.4.19 v5.2.3 Allows exporting any serializable PHP data structure to plain PHP code v4.4.19 v5.2.3 Manages links between resources v4.4.19 v5.2.3 Provides a development tool that gives detailed information about the execution of any request v4.4.19 v5.2.3 Loads and dumps YAML files

PHP version

$ php -v
PHP 7.3.16 (cli) (built: Apr 13 2020 13:43:36) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.16, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.16, Copyright (c) 1999-2018, by Zend Technologies

Subject

I test it in new empty project: https://github.com/askuiop/newProject Overwrite SonataAdminBundle.en.xliff doesn't work ! https://symfony.com/doc/current/bundles/override.html#translations

Minimal repository with the bug

https://github.com/askuiop/newProject

Steps to reproduce

Override the translations defined in the /vendor/sonata-project/admin-bundle/src/Resources/translations/SonataAdminBundle.en.xliff file , create a /translations/SonataAdminBundle.en.xliff file , and I changed the translation of 3 words ,then clean cache for test.

Visit the admin page on http://localhost:8000/admin, then visit http://localhost:8000/_profiler/5ce8a0?panel=translation and found the translation message preview didn't change anthing.

It works in my old project with symfony 3.3 and SonataAdminBundle 3.35.2, but in new version it doesn't work !

Where is the problem?

Expected results

overwrite SonataAdminBundle translations.

Actual results

New .xliff file overwrite doesn't work.

VincentLanglet commented 3 years ago

@sonata-project/contributors I tried the projet and it seems like that the translations are not overridden. Any idea why ? Should be reported to symfony instead ?