Check `service_container` usages

[franmomu]

Feature Request

We are using service_container in:

• [x] InlineValidator For what I remember, the validation was removed from admins, so I don't know if this service is longer needed. Update: deprecated in https://github.com/sonata-project/SonataAdminBundle/pull/6998
• [x] SonataAdminExtension This one should have been marked to me removed, in 4.x is already removed.
• [x] RenderElementExtension I think this is no longer needed, it is used to fetch the template registry associated to an admin, but IIRC there is a getTemplateRegistry in the admin. Update: made it in https://github.com/sonata-project/SonataAdminBundle/pull/6996
• [x] Pool This one is already a Service Locator in 4.x.
• [x] AdminPoolLoader I have no idea about this one, looking at the use I would say it is not needed anymore, but I'm not sure. Updated: done in 4.x.
• [x] FilterFactory It would be nice to create a ServiceLocator for this one so filters don't need to be public.
• [x] AuditManager Looks like a tag could be created to inject a service locator with the related services. Updated: done in 4.x.

[VincentLanglet]

Speaking on SonataAdminExtension, the only remaining method is https://github.com/sonata-project/SonataAdminBundle/blob/b737b64feea99be925af9b970bc42dca26d7587f/src/Twig/Extension/SonataAdminExtension.php#L64

But I find no usage, do you think we can deprecate the full extension ? @franmomu

[franmomu]

The method is not directly used, but it's used as a filter: https://github.com/search?q=org%3Asonata-project+sonata_urlsafeid&type=code.

In some places there is no admin, so I guess we should keep it for now.

[jordisala1991]

But we have another filter called this same way: https://github.com/sonata-project/twig-extensions/blob/1.x/src/Extension/TemplateExtension.php

Which one are we using?

[franmomu]

Interesting, I guess it depends on the project, on which bundle it is registered last.

[VincentLanglet]

This issue can be closed. But should we open one about the sonata_urlsafeid duplicate ?