search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

v3.98: Unclosed "{" on src/Resources/views/CRUD/Association/edit_one_to_one.html.twig L27 #7124

Closed u03c1 closed 3 years ago

u03c1 commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.98.0 3.98.0 The missing Symfony Admin Gener... sonata-project/block-bundle 3.23.0 4.5.3 Symfony SonataBlockBundle sonata-project/cache 2.0.1 2.1.1 Cache library sonata-project/doctrine-extensions 1.12.0 1.12.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 3.33.0 3.33.0 Integrate Doctrine ORM into the... sonata-project/exporter 2.6.2 2.6.2 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/intl-bundle 2.10.1 2.10.1 Symfony SonataIntlBundle sonata-project/media-bundle 3.31.1 3.31.1 Symfony SonataMediaBundle sonata-project/twig-extensions 1.5.1 1.5.1 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v4.4.20 v5.2.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript fi... symfony/browser-kit v4.4.20 v5.2.4 Simulates the behavior of a web browser, allowing you to make requests, click on links and... symfony/cache v4.4.21 v5.2.6 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v4.4.20 v5.2.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v4.4.21 v5.2.6 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v4.4.20 v5.2.4 Converts CSS selectors to XPath expressions symfony/debug v4.4.20 v4.4.20 Provides tools to ease debugging PHP code symfony/debug-bundle v4.4.20 v5.2.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack fr... symfony/debug-pack v1.0.9 v1.0.9 A debug pack for Symfony projects symfony/dependency-injection v4.4.21 v5.2.6 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v4.4.21 v5.2.6 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v4.4.20 v5.2.4 Eases DOM navigation for HTML and XML documents symfony/dotenv v4.4.20 v5.2.4 Registers environment variables from a .env file symfony/error-handler v4.4.21 v5.2.6 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v4.4.20 v5.2.4 Provides tools that allow your application components to communicate with each other by di... symfony/event-dispatcher-contracts v1.1.9 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v4.4.20 v5.2.4 Provides an engine that can compile and evaluate expressions symfony/filesystem v4.4.21 v5.2.6 Provides basic utilities for the filesystem symfony/finder v4.4.20 v5.2.4 Finds files and directories via an intuitive fluent interface symfony/flex v1.12.2 v1.12.2 Composer plugin for Symfony symfony/form v4.4.21 v5.2.6 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v4.4.21 v5.2.6 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v4.4.21 v5.2.6 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v4.4.20 v5.2.4 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v4.4.21 v5.2.6 Provides a structured process for converting a Request into a Response symfony/inflector v4.4.21 v5.2.6 Converts words between their singular and plural forms (English only) symfony/intl v4.4.20 v5.2.4 Provides a PHP replacement layer for the C intl extension that includes additional data fr... symfony/maker-bundle v1.30.2 v1.30.2 Symfony Maker helps you create empty commands, controllers, form classes, tests and more s... symfony/mime v4.4.21 v5.2.6 Allows manipulating MIME messages symfony/monolog-bridge v4.4.21 v5.2.5 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/options-resolver v4.4.20 v5.2.4 Provides an improved replacement for the array_replace PHP function symfony/panther v1.0.1 v1.0.1 A browser testing and web scraping library for PHP and Symfony. symfony/phpunit-bridge v5.2.6 v5.2.6 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.22.1 v1.22.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.22.1 v1.22.1 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.22.1 v1.22.1 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.22.1 v1.22.1 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.22.1 v1.22.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/process v4.4.20 v5.2.4 Executes commands in sub-processes symfony/profiler-pack v1.0.5 v1.0.5 A pack for the Symfony web profiler symfony/property-access v4.4.20 v5.2.4 Provides functions to read and write from/to an object or array using a simple string nota... symfony/routing v4.4.20 v5.2.6 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.1.1 v3.1.1 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v4.4.21 v5.2.6 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v4.4.21 v5.2.6 Symfony Security Component - Core Library symfony/security-csrf v4.4.20 v5.2.4 Symfony Security Component - CSRF Library symfony/security-guard v4.4.20 v5.2.4 Symfony Security Component - Guard symfony/security-http v4.4.21 v5.2.6 Symfony Security Component - HTTP Integration symfony/serializer v4.4.20 v5.2.4 Handles serializing and deserializing data structures, including object graphs, into array... symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v4.4.20 v5.2.4 Provides a way to profile code symfony/string v5.2.6 v5.2.6 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and gra... symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v4.4.20 v5.2.4 Provides all the tools needed to build any kind of template system symfony/translation v4.4.21 v5.2.6 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v4.4.21 v5.2.6 Provides integration for Twig with various Symfony components symfony/twig-bundle v4.4.20 v5.2.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v4.4.21 v5.2.6 Provides tools to validate values symfony/var-dumper v4.4.21 v5.2.6 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v4.4.20 v5.2.4 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-profiler-bundle v4.4.21 v5.2.6 Provides a development tool that gives detailed information about the execution of any req... symfony/yaml v4.4.21 v5.2.5 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.15 (cli) (built: Feb  4 2021 20:58:13) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.15, Copyright (c), by Zend Technologies

Subject

From 3.98 it seems their is a typo here: https://github.com/sonata-project/SonataAdminBundle/blob/79b678ced3a6e36dc6548b1b9afbc9e2df2b8301/src/Resources/views/CRUD/Association/edit_one_to_one.html.twig#L27

We need to remove 1 parenthesis, or we trigger an error: Unclosed "{" on src/Resources/views/CRUD/Association/edit_one_to_one.html.twig

Steps to reproduce

Create an admin that implement one_to_one association.

Expected results

No error

Actual results


Twig\Error\SyntaxError:
Unclosed "{".

  at vendor/sonata-project/admin-bundle/src/Resources/views/CRUD/Association/edit_one_to_one.html.twig:23
  at Twig\Lexer->lexExpression()
     (vendor/twig/twig/src/Lexer.php:292)
  at Twig\Lexer->lexVar()
     (vendor/twig/twig/src/Lexer.php:186)
  at Twig\Lexer->tokenize()
     (vendor/twig/twig/src/Environment.php:542)
  at Twig\Environment->tokenize()
     (vendor/twig/twig/src/Environment.php:595)
  at Twig\Environment->compileSource()
     (vendor/twig/twig/src/Environment.php:408)
  at Twig\Environment->loadClass()
     (vendor/twig/twig/src/Environment.php:381)
  at Twig\Environment->loadTemplate()
     (vendor/twig/twig/src/Template.php:333)
  at Twig\Template->loadTemplate()
     (var/cache/dev/twig/ed/edca00ee2acf2a2d0676905089e86d6c86b0a6389ff4099312146fb0beb0a7ba.php:75)
  at __TwigTemplate_15fc1ab1b6a1faec0b11bc4567b82ab5fb2ff01028feccbdc68cdbc9f768e22c->block_sonata_admin_orm_one_to_one_widget()
     (vendor/twig/twig/src/Template.php:182)
  at Twig\Template->displayBlock()
     (var/cache/dev/twig/ed/edca00ee2acf2a2d0676905089e86d6c86b0a6389ff4099312146fb0beb0a7ba.php:234)
  at __TwigTemplate_15fc1ab1b6a1faec0b11bc4567b82ab5fb2ff01028feccbdc68cdbc9f768e22c->block_sonata_type_admin_widget()
     (vendor/twig/twig/src/Template.php:182)
  at Twig\Template->displayBlock()
     (vendor/symfony/twig-bridge/Form/TwigRendererEngine.php:58)
  at Symfony\Bridge\Twig\Form\TwigRendererEngine->renderBlock()
     (vendor/symfony/form/FormRenderer.php:260)
  at Symfony\Component\Form\FormRenderer->searchAndRenderBlock()
     (var/cache/dev/twig/46/46a9501993b9c024d352a631c3d0f397cfce4c951489fb850af85bb2e179dbde.php:1361)
  at __TwigTemplate_9141ec49874f20cd9e65b45e37288517158291fcd09d6e4b5e01487ddd969cfc->block_form_row()
     (vendor/twig/twig/src/Template.php:182)
  at Twig\Template->displayBlock()
     (vendor/symfony/twig-bridge/Form/TwigRendererEngine.php:58)
  at Symfony\Bridge\Twig\Form\TwigRendererEngine->renderBlock()
     (vendor/symfony/form/FormRenderer.php:260)
  at Symfony\Component\Form\FormRenderer->searchAndRenderBlock()
     (var/cache/dev/twig/e2/e254b837df7e8ba0777bc2faf1e0733368d5d817b35c9500be9728d7a8367eb0.php:122)
  at __TwigTemplate_bb1dac879a02a92dc0de2d00e636d801c795eea1b7bd9f8a9f4fcc37a3edacac->macro_render_groups()
     (vendor/twig/twig/src/Extension/CoreExtension.php:1110)
  at twig_call_macro()
     (var/cache/dev/twig/06/0602d8f7fa7119697e1cd19d58950ac6c8dbed2a5a94bf4db884f10b818b5047.php:631)
  at __TwigTemplate_c9a55cd843434b356e5f001e50b64bc4b69b94201a46a94512d4f882e8a1126f->block_sonata_tab_content()
     (vendor/twig/twig/src/Template.php:182)
  at Twig\Template->displayBlock()
     (var/cache/dev/twig/06/0602d8f7fa7119697e1cd19d58950ac6c8dbed2a5a94bf4db884f10b818b5047.php:223)
  at __TwigTemplate_c9a55cd843434b356e5f001e50b64bc4b69b94201a46a94512d4f882e8a1126f->block_form()
     (vendor/twig/twig/src/Template.php:182)
  at Twig\Template->displayBlock()
     (var/cache/dev/twig/a1/a1c695e92077e241435a1fc4f13c088cba445a5022f9f77a8fa72497ed9f9926.php:219)
  at __TwigTemplate_bd96540c88634de252709a866e262277a39bd470ff6e032de413e2a8a71587dc->block_form()
     (vendor/twig/twig/src/Template.php:182)
  at Twig\Template->displayBlock()
     (vendor/twig/twig/src/Template.php:254)
  at Twig\Template->renderBlock()
     (var/cache/dev/twig/32/32adaa9d16f46bacf2970fe15ae67efa789435fb10821d7a43b6473730fe754e.php:76)
  at __TwigTemplate_f343466fb3f1a3a73dedf205f3ecc0c7d6e110d7bd407a664261c93bf3078a57->doDisplay()
     (vendor/twig/twig/src/Template.php:405)
  at Twig\Template->displayWithErrorHandling()
     (vendor/twig/twig/src/Template.php:378)
  at Twig\Template->display()
     (var/cache/dev/twig/dd/dd8f8b39f0a17ca455545a2465cfde4602fd445389dc2202c3091fcc44ca4d1a.php:53)
  at __TwigTemplate_0022391190141e6f93a18ee3ad105412bfbddcc50f1e696cb1f28cb085458ffd->doDisplay()
     (vendor/twig/twig/src/Template.php:405)
  at Twig\Template->displayWithErrorHandling()
     (vendor/twig/twig/src/Template.php:378)
  at Twig\Template->display()
     (var/cache/dev/twig/a1/a1c695e92077e241435a1fc4f13c088cba445a5022f9f77a8fa72497ed9f9926.php:75)
  at __TwigTemplate_bd96540c88634de252709a866e262277a39bd470ff6e032de413e2a8a71587dc->doDisplay()
     (vendor/twig/twig/src/Template.php:405)
  at Twig\Template->displayWithErrorHandling()
     (vendor/twig/twig/src/Template.php:378)
  at Twig\Template->display()
     (vendor/twig/twig/src/Template.php:390)
  at Twig\Template->render()
     (vendor/symfony/twig-bridge/TwigEngine.php:54)
  at Symfony\Bridge\Twig\TwigEngine->render()
     (vendor/symfony/framework-bundle/Controller/ControllerTrait.php:233)
  at Sonata\AdminBundle\Controller\CRUDController->originalRender()
     (vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php:124)
VincentLanglet commented 3 years ago

Thanks @RaphaelDB ; I opened https://github.com/sonata-project/SonataAdminBundle/pull/7125