search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

4.0.0-alpha-2, dashboard group config 'keep_open' seems broken #7207

Closed virtualize closed 3 years ago

virtualize commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.0.0-alpha-2 4.0.0-alpha-2 The missing Symfony Admin Generator sonata-project/block-bundle 4.5.3 4.5.3 Symfony SonataBlockBundle sonata-project/cache 2.1.1 2.1.1 Cache library sonata-project/doctrine-extensions 1.12.0 1.12.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.0.0-alpha-2 4.0.0-alpha-2 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.6.2 2.6.2 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/twig-extensions 1.6.0 1.6.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/amqp-messenger v5.2.7 v5.2.7 Symfony AMQP extension Messenger Bridge symfony/apache-pack v1.0.1 v1.0.1 A pack for Apache support in Symfony symfony/asset v5.2.7 v5.2.7 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v5.2.9 v5.2.9 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/cache v5.2.9 v5.2.9 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v5.2.8 v5.2.8 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.2.8 v5.2.8 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v5.2.9 v5.2.9 Converts CSS selectors to XPath expressions symfony/debug-bundle v5.2.4 v5.2.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework symfony/dependency-injection v5.2.9 v5.2.9 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.2.9 v5.2.9 Provides integration for Doctrine with various Symfony components symfony/doctrine-messenger v5.2.7 v5.2.7 Symfony Doctrine Messenger Bridge symfony/dom-crawler v5.2.9 v5.2.9 Eases DOM navigation for HTML and XML documents symfony/dotenv v5.2.4 v5.2.4 Registers environment variables from a .env file symfony/error-handler v5.2.8 v5.2.8 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.2.4 v5.2.4 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v2.4.0 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v5.2.7 v5.2.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.2.7 v5.2.7 Provides basic utilities for the filesystem symfony/finder v5.2.9 v5.2.9 Finds files and directories via an intuitive fluent interface symfony/flex v1.13.3 v1.13.3 Composer plugin for Symfony symfony/form v5.2.9 v5.2.9 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.2.9 v5.2.9 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/google-mailer v5.2.4 v5.2.4 Symfony Google Mailer Bridge symfony/http-client v5.2.9 v5.2.9 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.2.8 v5.2.8 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.2.9 v5.2.9 Provides a structured process for converting a Request into a Response symfony/intl v5.2.7 v5.2.7 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mailer v5.2.7 v5.2.7 Helps sending emails symfony/maker-bundle v1.31.1 v1.31.1 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/messenger v5.2.7 v5.2.7 Helps applications send and receive messages to/from other applications or via message queues symfony/mime v5.2.9 v5.2.9 Allows manipulating MIME messages symfony/monolog-bridge v5.2.7 v5.2.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/options-resolver v5.2.4 v5.2.4 Provides an improved replacement for the array_replace PHP function symfony/phpunit-bridge v5.2.9 v5.2.9 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.22.1 v1.22.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.22.1 v1.22.1 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.22.1 v1.22.1 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.22.1 v1.22.1 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.22.1 v1.22.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php70 v1.20.0 v1.20.0 Symfony polyfill backporting some PHP 7.0+ features to lower PHP versions symfony/polyfill-php73 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/process v5.2.7 v5.2.7 Executes commands in sub-processes symfony/property-access v5.2.4 v5.2.4 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.2.8 v5.2.8 Extracts information about PHP class' properties using metadata of popular sources symfony/redis-messenger v5.2.7 v5.2.7 Symfony Redis extension Messenger Bridge symfony/routing v5.2.9 v5.2.9 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.1.2 v3.1.2 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.2.9 v5.2.9 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.2.9 v5.2.9 Symfony Security Component - Core Library symfony/security-csrf v5.2.7 v5.2.7 Symfony Security Component - CSRF Library symfony/security-guard v5.2.8 v5.2.8 Symfony Security Component - Guard symfony/security-http v5.2.9 v5.2.9 Symfony Security Component - HTTP Integration symfony/serializer v5.2.9 v5.2.9 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v5.2.7 v5.2.7 Provides a way to profile code symfony/string v5.2.8 v5.2.8 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/templating v5.2.4 v5.2.4 Provides all the tools needed to build any kind of template system symfony/translation v5.2.9 v5.2.9 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v5.2.8 v5.2.8 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.2.9 v5.2.9 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.2.9 v5.2.9 Provides tools to validate values symfony/var-dumper v5.2.8 v5.2.8 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.2.8 v5.2.8 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-profiler-bundle v5.2.8 v5.2.8 Provides a development tool that gives detailed information about the execution of any request symfony/yaml v5.2.9 v5.2.9 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.13 (cli) (built: Dec  6 2020 20:43:27) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.4, Copyright (c), by Zend Technologies
    with blackfire v1.34.0~mac-x64-non_zts74, https://blackfire.io, by Blackfire

Subject

Setting keep_open does not keep the menu open. It collapses if another menu group is opened

sonata_admin:
    dashboard:
        groups:
            management:
                label: 'Management'
                keep_open: true
            reports:
                label: 'Reports'
                keep_open: true
            shop:
                label: 'Shop'
                keep_open: true
VincentLanglet commented 3 years ago

Did you have the issue with the alpha-1 ?

virtualize commented 3 years ago

I just reverted to alpha-1 and there it works. The change must be somewhere between alpha-1 and alpha-2.

jordisala1991 commented 3 years ago

Do you have the same problem with latest release of 3.x?

virtualize commented 3 years ago

@jordisala1991 No. I tried with this setup and it works fine

sonata-project/admin-bundle              3.100.1 3.100.1 The missing Symfony Admin Generator
sonata-project/block-bundle              4.5.3   4.5.3   Symfony SonataBlockBundle
sonata-project/cache                     2.1.1   2.1.1   Cache library
sonata-project/doctrine-extensions       1.12.0  1.12.0  Doctrine2 behavioral extensions
sonata-project/doctrine-orm-admin-bundle 3.34.1  3.34.1  Integrate Doctrine ORM into the SonataAdminBundle
sonata-project/exporter                  2.6.2   2.6.2   Lightweight Exporter library
sonata-project/form-extensions           1.9.0   1.9.0   Symfony form extensions
sonata-project/twig-extensions           1.6.0   1.6.0   Sonata twig extensions
VincentLanglet commented 3 years ago

If you have time, the best would be to try directly with commits between alpha-1 and alpha-2 in order to find which one introduce the bug.

franmomu commented 3 years ago

Looks like in

https://github.com/sonata-project/SonataAdminBundle/blob/9fc1dc247f365586ce0f8d065956388c23c0ee9d/assets/scss/styles.scss#L299-L306

should be change to be like:

https://github.com/sonata-project/SonataAdminBundle/blob/1d895c1af28b05b9572816536bf5de15b8890514/src/Resources/public/css/styles.css#L679-L682

I'll make a PR.