search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

history, historyViewRevision and historyCompareRevisions should have his own permission map `HISTORY` #7444

Closed VincentLanglet closed 3 years ago

VincentLanglet commented 3 years ago

Feature Request

When doing https://github.com/sonata-project/SonataAdminBundle/pull/7443, I saw that history, historyViewRevision and historyCompareRevisions was using the EDIT permission.

I was kinda surprise the role ROLE_MYADMIN_HISTORY didn't exist ; IMHO it should.

It's because you have the right to edit some field of some entity that you have the right to see all the modification made by others people. And you can also have the right to see the history without the right to edit.

WDYT @sonata-project/contributors ?

VincentLanglet commented 3 years ago

With these change