sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Twig date is wrong #7503

Closed haivala closed 3 years ago

haivala commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.105.1 4.0.0 The missing Symfony Admin Generator sonata-project/block-bundle 3.23.2 4.7.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/cache-bundle 3.3.0 3.3.0 This bundle provides caching services sonata-project/datagrid-bundle 3.4.0 3.4.0 Symfony SonataDatagridBundle sonata-project/doctrine-extensions 1.13.1 1.13.1 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 3.35.0 4.0.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.8.0 2.8.0 Lightweight Exporter library sonata-project/form-extensions 1.10.0 1.10.0 Symfony form extensions sonata-project/formatter-bundle 4.6.1 4.6.1 Symfony SonataFormatterBundle sonata-project/media-bundle 3.33.1 3.33.1 Symfony SonataMediaBundle sonata-project/notification-bundle 3.13.0 3.13.0 Symfony SonataNotificationBundle sonata-project/page-bundle 3.23.0 3.23.0 This bundle provides a Site and Page management through container and block serv... sonata-project/seo-bundle 2.13.1 2.13.1 Symfony SonataSeoBundle sonata-project/twig-extensions 1.8.0 1.8.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v5.2.12 v5.3.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScri... symfony/cache v5.3.7 v5.3.7 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v4.4.30 v5.3.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v4.4.30 v5.3.7 Eases the creation of beautiful and testable command line interfaces symfony/debug v4.4.27 v4.4.27 Provides tools to ease debugging PHP code symfony/debug-bundle v4.4.27 v5.3.4 Provides a tight integration of the Symfony Debug component into the Symfony full-sta... symfony/dependency-injection v4.4.27 v5.3.7 Allows you to standardize and centralize the way objects are constructed in your appl... symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v4.4.30 v5.3.7 Provides integration for Doctrine with various Symfony components symfony/dotenv v4.4.29 v5.3.7 Registers environment variables from a .env file symfony/error-handler v4.4.30 v5.3.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v4.4.30 v5.3.7 Provides tools that allow your application components to communicate with each other ... symfony/event-dispatcher-contracts v1.1.9 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v5.3.7 v5.3.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesystem symfony/finder v5.3.7 v5.3.7 Finds files and directories via an intuitive fluent interface symfony/flex v1.15.4 v1.15.4 Composer plugin for Symfony symfony/form v4.4.30 v5.3.7 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v4.4.30 v5.3.7 Provides a tight integration between Symfony components and the Symfony full-stack fr... symfony/http-client v4.4.27 v5.3.7 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v4.4.30 v5.3.7 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v4.4.30 v5.3.7 Provides a structured process for converting a Request into a Response symfony/intl v5.3.7 v5.3.7 Provides a PHP replacement layer for the C intl extension that includes additional da... symfony/mailer v4.4.27 v5.3.4 Helps sending emails symfony/maker-bundle v1.33.0 v1.33.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and m... symfony/mime v5.3.7 v5.3.7 Allows manipulating MIME messages symfony/monolog-bridge v4.4.27 v5.3.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/options-resolver v4.4.30 v5.3.7 Provides an improved replacement for the array_replace PHP function symfony/polyfill-ctype v1.23.0 v1.23.0 Symfony polyfill for ctype functions symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v4.4.30 v5.3.7 Executes commands in sub-processes symfony/property-access v5.3.7 v5.3.7 Provides functions to read and write from/to an object or array using a simple string... symfony/property-info v5.3.7 v5.3.7 Extracts information about PHP class' properties using metadata of popular sources symfony/routing v4.4.30 v5.3.7 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v4.4.27 v5.3.7 Provides a tight integration of the Security component into the Symfony full-stack fr... symfony/security-core v4.4.30 v5.3.7 Symfony Security Component - Core Library symfony/security-csrf v4.4.27 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v4.4.27 v5.3.7 Symfony Security Component - Guard symfony/security-http v4.4.30 v5.3.7 Symfony Security Component - HTTP Integration symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v4.4.27 v5.3.4 Provides a way to profile code symfony/string v5.3.7 v5.3.7 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points an... symfony/templating v4.4.30 v5.3.7 Provides all the tools needed to build any kind of template system symfony/translation v4.4.30 v5.3.7 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v4.4.27 v5.3.7 Provides integration for Twig with various Symfony components symfony/twig-bundle v4.4.30 v5.3.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v4.4.30 v5.3.7 Provides tools to validate values symfony/var-dumper v5.3.7 v5.3.7 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.3.7 v5.3.7 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-profiler-bundle v4.4.28 v5.3.5 Provides a development tool that gives detailed information about the execution of an... symfony/webpack-encore-bundle v1.12.0 v1.12.0 Integration with your Symfony app & Webpack Encore! symfony/yaml v4.4.29 v5.3.6 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.23 (cli) (built: Aug 27 2021 21:53:25) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.23, Copyright (c), by Zend Technologies

Subject

I have Entity with Date object and the date is wrong in many cases. Date has been updated using Sonata DatePickerType from Sonata Admin and it shows right date there but in wrong language. I have the Admin in Finnish and the date in the list route is "September 10, 2021" and another column in the entity is a date that is DateTime and that is showing as the format in twig config is defined "21.9.2021, 15:30" == format: j.n.Y, H:i. ./bin/console doctrine:query:sql tells me that the date is string(10) "2021-09-10"

When I dump the date in front controller it says the right date but when I pass it to twig and dump it date is "2022-02-10 00:00:00.0 Europe/Helsinki (+02:00)" When I load the entity in a Block and use sonata_block_render in twig the date is 10.1.2022, 00:00 When I load the block to the PageBundles composer and use the page template to render the block it is the right date again.

I don't know where I should put this issue..

Steps to reproduce

Don't know as I haven't seen this behavior

Expected results

Date would be the same in all cases.

Actual results

Date is wrong in many cases

VincentLanglet commented 3 years ago

I never got any issue with the date.

Without a reproducer, this can't be confirmed, and solved.

haivala commented 3 years ago

Me either. On the other hand I have been always using DateTime.

How it can interpret the date 2021-09-10 as 2022-01-10 or 2022-02-10? I'm tying to understand where the bug could be. I searched the net and it could be that it has something to do with division of 1000? The date dump from twig also has wrong timezone. it should be +03:00 not +02:00.

I'll make reproducer later if it is really needed

VincentLanglet commented 3 years ago

Me either. On the other hand I have been always using DateTime.

I don't understand why you would open an issue if you're saying you never got any issue with dates...

I'll make reproducer later if it is really needed

It is. We can't debug someone we don't reproduce.

haivala commented 3 years ago

Me either. On the other hand I have been always using DateTime.

I don't understand why you would open an issue if you're saying you never got any issue with dates...

Well before this.

I'll make reproducer later if it is really needed

It is. We can't debug someone we don't reproduce.

And this means I cannot get help by asking and debug it myself?

jordisala1991 commented 3 years ago

Me either. On the other hand I have been always using DateTime.

I don't understand why you would open an issue if you're saying you never got any issue with dates...

Well before this.

I'll make reproducer later if it is really needed

It is. We can't debug someone we don't reproduce.

And this means I cannot get help by asking and debug it myself?

Well, you can get help. But you need to understand that there are issues that are easy to reproduce are other that are hard to reproduce. If you want more success at getting help, we can guide you how to do it. First step, provide a reproducer of the issue.

haivala commented 3 years ago

I get what you mean but if I get answers to my questions I would be able to try to debug it myself and provide my discoveries here

VincentLanglet commented 3 years ago

I get what you mean but if I get answers to my questions I would be able to try to debug it myself and provide my discoveries here

We try to keep Github issues for bug reports and feature requests only. If you have a question, please ask it on Stack Overflow or on #sonata on the symfony-devs slack.

And as far, with the description of the problem you give, this cannot be considered as a confirmed bug.

haivala commented 3 years ago

well it is a bug report!