search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Global search - Empty boxes not works #7513

Closed rrc845 closed 3 years ago

rrc845 commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.0.0 4.0.0 The missing Symfony Admin Generator sonata-project/block-bundle 4.7.0 4.7.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/doctrine-extensions 1.13.1 1.13.1 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.0.0 4.0.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.8.0 2.8.0 Lightweight Exporter library sonata-project/form-extensions 1.11.0 1.11.0 Symfony form extensions sonata-project/intl-bundle 2.10.2 2.10.2 Symfony SonataIntlBundle sonata-project/twig-extensions 1.9.0 1.9.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v5.3.4 v5.3.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v5.3.4 v5.3.4 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms pr... symfony/cache v5.3.7 v5.3.8 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v5.3.4 v5.3.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.3.7 v5.3.7 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v5.3.4 v5.3.4 Converts CSS selectors to XPath expressions symfony/debug-bundle v5.3.4 v5.3.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework symfony/dependency-injection v5.3.7 v5.3.8 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.3.7 v5.3.8 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v5.3.7 v5.3.7 Eases DOM navigation for HTML and XML documents symfony/dotenv v5.3.7 v5.3.8 Registers environment variables from a .env file symfony/error-handler v5.3.7 v5.3.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.3.7 v5.3.7 Provides tools that allow your application components to communicate with each other by dispatching events... symfony/event-dispatcher-contracts v2.4.0 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v5.3.7 v5.3.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesystem symfony/finder v5.3.7 v5.3.7 Finds files and directories via an intuitive fluent interface symfony/flex v1.16.2 v1.16.3 Composer plugin for Symfony symfony/form v5.3.7 v5.3.8 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.3.7 v5.3.8 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.3.7 v5.3.8 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.3.7 v5.3.7 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.3.7 v5.3.9 Provides a structured process for converting a Request into a Response symfony/intl v5.3.7 v5.3.8 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/lock v5.3.4 v5.3.4 Creates and manages locks, a mechanism to provide exclusive access to a shared resource symfony/mailer v5.3.4 v5.3.9 Helps sending emails symfony/maker-bundle v1.34.0 v1.34.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget... symfony/mime v5.3.7 v5.3.8 Allows manipulating MIME messages symfony/monolog-bridge v5.3.7 v5.3.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/notifier v5.3.4 v5.3.9 Sends notifications via one or more channels (email, SMS, ...) symfony/options-resolver v5.3.7 v5.3.7 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.3.7 v5.3.8 Provides password hashing utilities symfony/phpunit-bridge v5.3.7 v5.3.8 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v5.3.7 v5.3.7 Executes commands in sub-processes symfony/property-access v5.3.7 v5.3.8 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.3.7 v5.3.8 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.3.4 v5.3.4 Provides integration for ProxyManager with various Symfony components symfony/routing v5.3.7 v5.3.7 Maps an HTTP request to a set of configuration variables symfony/runtime v5.3.4 v5.3.4 Enables decoupling PHP applications from global state symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.3.7 v5.3.8 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.3.7 v5.3.8 Symfony Security Component - Core Library symfony/security-csrf v5.3.4 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v5.3.7 v5.3.7 Symfony Security Component - Guard symfony/security-http v5.3.7 v5.3.8 Symfony Security Component - HTTP Integration symfony/serializer v5.3.4 v5.3.8 Handles serializing and deserializing data structures, including object graphs, into array structures or o... symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v5.3.4 v5.3.4 Provides a way to profile code symfony/string v5.3.7 v5.3.7 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters i... symfony/templating v5.3.7 v5.3.7 Provides all the tools needed to build any kind of template system symfony/translation v5.3.7 v5.3.9 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v5.3.7 v5.3.7 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.3.4 v5.3.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.3.7 v5.3.8 Provides tools to validate values symfony/var-dumper v5.3.7 v5.3.8 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.3.7 v5.3.8 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v5.3.4 v5.3.4 Manages links between resources symfony/web-profiler-bundle v5.3.5 v5.3.8 Provides a development tool that gives detailed information about the execution of any request symfony/yaml v5.3.6 v5.3.6 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 8.0.10 (cli) (built: Aug 26 2021 07:11:25) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.10, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.10, Copyright (c), by Zend Technologies

Subject

Hello, i tried configure empty boxes in fade or hide mode, but it never worked.

I configured global search empty boxes in hide, but when i see the search, the boxes is not hide.

I checked the template, and i found a bug in the conditional.

In: vendor/sonata-project/admin-bundle/src/Resources/views/Block/block_search_result.html.twig

The line: {% set visibility_class = 'sonata-search-result-' ~ has_results ? 'show' : show_empty_boxes %}

Always return 'show', never return the variable show_empty_boxes.

It was solved adding parentheses.

{% set visibility_class = 'sonata-search-result-' ~ (has_results ? 'show' : show_empty_boxes) %}

Steps to reproduce

Tried configure empty_boxes, the configuration not works.

Expected results

After the change: image

Actual results

Before the change: image

Regards.

VincentLanglet commented 3 years ago

Hi @krubenrc ; can you open a PR with the fix ? :)