search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Add new Element to Inline Collection #7557

Closed TheFox closed 2 years ago

TheFox commented 3 years ago

Is it possible to add more than one element to an inline Collection before saving the whole form? If I click on "New" for an inline Collection a new empty row will be added, but when I fill out the new row fields and then click again on "New" without clicking on save, the new added new will be empty again. Is this baviour intended, or a bug?

VincentLanglet commented 3 years ago

Please fill up the issue template correctly or the issue will be closed.

TheFox commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.105.3 4.0.1 The missing Symfony Admin Generator sonata-project/block-bundle 4.7.0 4.7.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/datagrid-bundle 3.4.0 3.4.0 Symfony SonataDatagridBundle sonata-project/doctrine-extensions 1.14.0 1.14.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 3.35.0 4.0.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.8.0 2.8.0 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.12.0 Symfony form extensions sonata-project/intl-bundle 2.10.2 2.10.2 Symfony SonataIntlBundle sonata-project/translation-bundle 2.8.1 2.9.1 SonataTranslationBundle sonata-project/twig-extensions 1.5.1 1.9.0 Sonata twig extensions sonata-project/user-bundle 4.11.1 4.12.0 Symfony SonataUserBundle ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v4.4.27 v5.3.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript file... symfony/browser-kit v4.4.27 v5.3.4 Simulates the behavior of a web browser, allowing you to make requests, click on links and s... symfony/cache v4.4.31 v5.3.8 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v4.4.30 v5.3.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v4.4.30 v5.3.7 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v4.4.27 v5.3.4 Converts CSS selectors to XPath expressions symfony/debug v4.4.31 v4.4.31 Provides tools to ease debugging PHP code symfony/debug-bundle v4.4.27 v5.3.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack fram... symfony/dependency-injection v4.4.31 v5.3.8 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v4.4.31 v5.3.8 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v4.4.30 v5.3.7 Eases DOM navigation for HTML and XML documents symfony/dotenv v4.4.29 v5.3.8 Registers environment variables from a .env file symfony/error-handler v4.4.30 v5.3.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v4.4.30 v5.3.7 Provides tools that allow your application components to communicate with each other by disp... symfony/event-dispatcher-contracts v1.1.9 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v4.4.30 v5.3.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v4.4.27 v5.3.4 Provides basic utilities for the filesystem symfony/finder v4.4.30 v5.3.7 Finds files and directories via an intuitive fluent interface symfony/flex v1.12.2 v1.17.2 Composer plugin for Symfony symfony/form v4.4.31 v5.3.8 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v4.4.31 v5.3.8 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v4.4.30 v5.3.7 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v4.4.32 v5.3.9 Provides a structured process for converting a Request into a Response symfony/inflector v4.4.27 v5.3.4 Converts words between their singular and plural forms (English only) symfony/intl v4.4.31 v5.3.8 Provides a PHP replacement layer for the C intl extension that includes additional data from... symfony/mailer v4.4.27 v5.3.9 Helps sending emails symfony/maker-bundle v1.34.1 v1.34.1 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so ... symfony/mime v4.4.31 v5.3.8 Allows manipulating MIME messages symfony/monolog-bridge v4.4.27 v5.3.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.0 Symfony MonologBundle symfony/options-resolver v4.4.30 v5.3.7 Provides an improved replacement for the array_replace PHP function symfony/orm-pack v2.1.0 v2.1.0 A pack for the Doctrine ORM symfony/phpunit-bridge v5.3.8 v5.3.8 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/property-access v4.4.30 v5.3.8 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v4.4.31 v5.3.8 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v4.4.27 v5.3.4 Provides integration for ProxyManager with various Symfony components symfony/routing v4.4.30 v5.3.7 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v4.4.27 v5.3.8 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v4.4.31 v5.3.8 Symfony Security Component - Core Library symfony/security-csrf v4.4.27 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v4.4.27 v5.3.7 Symfony Security Component - Guard symfony/security-http v4.4.30 v5.3.8 Symfony Security Component - HTTP Integration symfony/sendgrid-mailer v4.4.30 v5.3.7 Symfony Sendgrid Mailer Bridge symfony/serializer v4.4.31 v5.3.8 Handles serializing and deserializing data structures, including object graphs, into array s... symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v4.4.27 v5.3.4 Provides a way to profile code symfony/string v5.3.7 v5.3.7 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and graph... symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v4.4.30 v5.3.7 Provides all the tools needed to build any kind of template system symfony/translation v4.4.32 v5.3.9 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v4.4.27 v5.3.7 Provides integration for Twig with various Symfony components symfony/twig-bundle v4.4.30 v5.3.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/twig-pack v1.0.1 v1.0.1 A Twig pack for Symfony projects symfony/validator v4.4.31 v5.3.8 Provides tools to validate values symfony/var-dumper v4.4.31 v5.3.8 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v4.4.31 v5.3.8 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-profiler-bundle v4.4.31 v5.3.8 Provides a development tool that gives detailed information about the execution of any request symfony/yaml v4.4.29 v5.3.6 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.23 (cli) (built: Aug 26 2021 16:07:37) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.23, Copyright (c), by Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans

Subject

Add new Elements to Inline Collection

Minimal repository with the bug

IDK

Steps to reproduce

  1. Create Inline Collection
->add('boothBlocks', \Sonata\Form\Type\CollectionType::class, [], [
            'edit' => 'inline',
            'inline' => 'table',
            'sortable' => 'position',
        ])
  1. In browser click on "New".
  2. fill out the fields of the new Row.
  3. Click on "New".

Expected results

I expect I can add multiple rows before submitting the form.

Actual results

In step 4 the row which has been filled out in step 3 has been emptied. No new row has been added. I can only click on "New", fill out the row, click on "Save" to also save the new added row. It is not working by click on "New", click on "New" and then on "Save".

VincentLanglet commented 3 years ago

I was using a lot of inline CollectionType on Sonata 3 without any issue. This seems weird, maybe related to some configuration.

A reproducer could be helpful to debug.

TheFox commented 3 years ago

The fields of Booth Blocks are only two text fields, so nothing special.

@VincentLanglet Did you use \Sonata\Form\Type\CollectionType or the native collection?

VincentLanglet commented 3 years ago

@VincentLanglet Did you use \Sonata\Form\Type\CollectionType or the native collection?

Both were working fine on my admin

TheFox commented 3 years ago

I works when I create a new Parent entity. I doesn't work with existing parent entities.

TheFox commented 3 years ago

@VincentLanglet It's somehow related to the Translation Bundle. I tracked it down to this line: https://github.com/sonata-project/SonataTranslationBundle/blob/13cea9bb1a45e0e2c62ae28aa0d4378c3ab1bdf7/src/Admin/Extension/Gedmo/TranslatableAdminExtension.php#L92

This causes that the original object in $subject at https://github.com/sonata-project/SonataAdminBundle/blob/8cf819a1b3b59abc98c610f09345ec3abb2dd960/src/Admin/AdminHelper.php#L190 will also change to what it's currently in the database.

So when I add a new item to the collection by clicking on the "New" button in the inline collection, the new item is at the collection before https://github.com/sonata-project/SonataAdminBundle/blob/8cf819a1b3b59abc98c610f09345ec3abb2dd960/src/Admin/AdminHelper.php#L157

After that line the collection is reset to what's at the database, not what's coming from the POST core/append-form-field-element request.

I am using the lastest version:

sonata-project/translation-bundle              2.9.1

When I turn of the translation for this entity it works like expected. So guess the issue is the Translation Bundle.

jordisala1991 commented 2 years ago

Your issue seems like this one: https://github.com/sonata-project/SonataTranslationBundle/issues/506

Lets focus the discussion there.