Sonata\Form\Type\CollectionType in modal/standard mode doesn't work

[clem-tri]

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.2.1 4.3.1 The missing Symfony Admin Generator sonata-project/block-bundle 4.7.0 4.8.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/doctrine-extensions 1.14.0 1.15.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.1.0 4.2.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.8.0 2.9.1 Lightweight Exporter library sonata-project/form-extensions 1.12.0 1.12.1 Symfony form extensions sonata-project/intl-bundle 2.11.1 2.11.2 Symfony SonataIntlBundle sonata-project/twig-extensions 1.9.0 1.9.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v4.4.27 v5.3.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v4.4.27 v5.3.4 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/cache v4.4.31 v5.3.10 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v4.4.30 v5.3.10 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v4.4.30 v5.3.10 Eases the creation of beautiful and testable command line interfaces symfony/debug v4.4.31 v4.4.31 Provides tools to ease debugging PHP code symfony/dependency-injection v4.4.31 v5.3.10 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v4.4.31 v5.3.8 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v4.4.30 v5.3.7 Eases DOM navigation for HTML and XML documents symfony/dotenv v4.4.29 v5.3.10 Registers environment variables from a .env file symfony/error-handler v4.4.30 v5.3.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v4.4.30 v5.3.7 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v1.1.9 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v4.4.30 v5.3.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v4.4.27 v5.3.4 Provides basic utilities for the filesystem symfony/finder v4.4.30 v5.3.7 Finds files and directories via an intuitive fluent interface symfony/flex v1.17.2 v1.17.2 Composer plugin for Symfony symfony/form v4.4.31 v5.3.10 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v4.4.31 v5.3.10 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v4.4.30 v5.3.10 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v4.4.32 v5.3.10 Provides a structured process for converting a Request into a Response symfony/inflector v4.4.27 v5.3.4 Converts words between their singular and plural forms (English only) Package symfony/inflector is abandoned, you should avoid using it. Use use `EnglishInflector` from the String component instead instead. symfony/intl v4.4.31 v5.3.8 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mime v4.4.31 v5.3.8 Allows manipulating MIME messages symfony/monolog-bridge v4.4.27 v5.3.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.0 v3.7.1 Symfony MonologBundle symfony/options-resolver v4.4.30 v5.3.7 Provides an improved replacement for the array_replace PHP function symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v4.4.30 v5.3.7 Executes commands in sub-processes symfony/property-access v4.4.30 v5.3.8 Provides functions to read and write from/to an object or array using a simple string notation symfony/proxy-manager-bridge v4.4.27 v5.3.4 Provides integration for ProxyManager with various Symfony components symfony/routing v4.4.30 v5.3.7 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v4.4.27 v5.3.8 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v4.4.31 v5.3.10 Symfony Security Component - Core Library symfony/security-csrf v4.4.27 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v4.4.27 v5.3.7 Symfony Security Component - Guard symfony/security-http v4.4.30 v5.3.10 Symfony Security Component - HTTP Integration symfony/serializer v4.4.31 v5.3.10 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v4.4.27 v5.3.4 Provides a way to profile code symfony/string v5.3.7 v5.3.10 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v4.4.30 v5.3.7 Provides all the tools needed to build any kind of template system symfony/translation v4.4.32 v5.3.10 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v4.4.27 v5.3.7 Provides integration for Twig with various Symfony components symfony/twig-bundle v4.4.30 v5.3.10 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v4.4.31 v5.3.10 Provides tools to validate values symfony/var-dumper v4.4.31 v5.3.10 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v4.4.31 v5.3.8 Allows exporting any serializable PHP data structure to plain PHP code symfony/webpack-encore-bundle v1.12.0 v1.13.0 Integration with your Symfony app & Webpack Encore! symfony/yaml v4.4.29 v5.3.6 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.25 (cli) (built: Oct 20 2021 09:29:27) ( NTS Visual C++ 2017 x64 )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

Subject

I have an admin form where I have added a Sonata\Form\Type\CollectionType field. The field is well implemented, when I click on the add button, the modal is showing with the form in it. But when I click on the create button, the modal fade and the new element is not showing as added to the collection.

Here is my code :

//  App\Admin\PhysicalPreorderContentAdmin.php (admin for "Content" entities)
protected function configureFormFields(FormMapper $form): void
{
...
   ->tab('Banners')
               ->with('Banners')
                   ->add('Banners', CollectionType::class,
                       array(
                           'label'        => false,
                           'required'     => false,
                           'by_reference' => false
                       ),
                       array(
                          'inline'       => 'standard',
                           'edit'         => 'standard',
                           'allow_delete' => true,
                           'allow_add'    => true,
                           'admin_code'   => 'sonata_admin_artistbanner',
                           'sortable'     => 'position'
                       ))

               ->end()
               ->end()
...
}

// App\Entity\Content.php

/**
     * @ORM\OneToMany(
     *     targetEntity="App\Entity\Banner",
     *     mappedBy="Content",
     *     orphanRemoval=true,
     *     cascade={"all"}
     * )
     * @ORM\OrderBy({"position" = "ASC"})
     */
    private $Banners;

...

/**
     * @param Collection $banners
     * @return $this
     */
    public function setBanners($banners): Content
    {

        $this->Banners = new ArrayCollection();
        if (empty($banners)) {
            return $this;
        }
        foreach ($banners as $banner) {
            $this->addBanner($banner);
        }

        return $this;
    }

    /**
     * Add Banners
     *
     * @param Banner $banners
     * @return Content
     */
    public function addBanner(Banner $banners): Content
    {
        $banners->setContent($this);
        $this->Banners[] = $banners;

        return $this;
    }

    /**
     * Remove Banners
     *
     * @param Banner $banners
     */
    public function removeBanner(Banner $banners)
    {
        $this->Banners->removeElement($banners);
    }

    /**
     * Get Banners
     *
     * @return Collection|Banner[]
     */
    public function getBanners()
    {
        return $this->Banners;
    }

// App\Entity\Banner.php

/**
     * @ORM\ManyToOne(targetEntity="App\Entity\Content", inversedBy="Banners")
     * @ORM\JoinColumn(name="content_id", referencedColumnName="id")
     */
    private $Content;

Steps to reproduce

• Add a Sonata\Form\Type\CollectionType field on an admin class with "inline" => "standard" and "edit" => "standard" parameters in fieldDescriptionOptions parameter
• When I click on the add button, the following request is getting me the modal view -> GET 200 http://127.0.0.1:8000/admin/fr/artistbanner/create?uniqid=s619b624b2f47c&code=sonata_admin_artistbanner&pcode=sonata_admin_physical_preorder_content&puniqid=s619b624ad0218

Then when I click on create via the modal view form, I have two requests executing -> This one first, which create the element successfully : POST 200 http://127.0.0.1:8000/admin/fr/artistbanner/create?uniqid=s619b624b2f47c

Then this one, which is I think supposed to replace html to show the newly created element in my form :

POST 200 http://127.0.0.1:8000/admin/fr/core/get-form-field-element?_sonata_admin=sonata_admin_physical_preorder_content&elementId=s619b624ad0218_Banners&uniqid=s619b624ad0218&_sonata_name=admin_sedona_umfinfoscombundle_preorder_create&_tab=tab_s619b610908738_1968181208_11

No errors in this last request, but it is returning this html response :

No matter if i'm on a new object or if i'm editing an existing one, the result is still the same. I saw an issue from 2016 (#4236) where someone had the same problem, it was a long thread but there was no solution for the modal way (the person who had the bug seems to have finally chosen to go on inline/table mode)

Am I actually doing this wrong ? I remember it was working well this way on an old sonata admin version (2.2)

Expected results

The element freshly created should be appended to your form

Actual results

No errors and no element added to the form.

[VincentLanglet]

A small reproducer in a repository would be useful to debug this.

[asifkhanpathan]

same issue reference entity is created but not appear in the form. any solution?

[VincentLanglet]

same issue reference entity is created but not appear in the form. any solution?

Hi, Current solutions are

• To provide a repository with the error to help people debugging this.
• To provide a PR with the bug fix.