sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Incorrect selection by the double click on the header information #7628

Closed pavelkameisha closed 2 years ago

pavelkameisha commented 2 years ago

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.106.1 4.4.0 The missing Symfony Admin Generator sonata-project/block-bundle 3.21.0 4.8.0 Symfony SonataBlockBundle sonata-project/cache 2.0.1 2.2.0 Cache library sonata-project/doctrine-extensions 1.14.0 1.15.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 3.35.0 4.2.1 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.7.0 2.9.1 Lightweight Exporter library sonata-project/form-extensions 1.12.1 1.12.3 Symfony form extensions sonata-project/twig-extensions 1.9.0 1.9.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/contracts v1.1.10 v2.5.0 A set of abstractions extracted out of the Symfony components symfony/deprecation-contracts v2.4.0 v2.5.0 A generic function and convention to trigger deprecation notices symfony/monolog-bundle v3.7.0 v3.7.1 Symfony MonologBundle symfony/phpunit-bridge v5.3.3 v6.0.0 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-ctype v1.23.0 v1.23.0 Symfony polyfill for ctype functions symfony/polyfill-iconv v1.23.0 v1.23.0 Symfony polyfill for the Iconv extension symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/security-acl v3.1.1 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/string v5.3.3 v5.4.0 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/symfony v4.4.26 v5.4.0 The Symfony PHP framework symfony/test-pack v1.0.8 v1.0.9 A pack for functional and end-to-end testing within a Symfony app ```

PHP version

$ php -v
PHP 7.4.22 (cli) (built: Jul 30 2021 13:08:17) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans
    with Zend OPcache v7.4.22, Copyright (c), by Zend Technologies

Subject

When I try to select current user ID in breadcrumb part by double click, it selects also previous data.

Minimal repository with the bug

Steps to reproduce

  1. Go to edit page
  2. Do double click on last page in breadcrumbs

Expected results

Only last part of breadcrumb is selected

Actual results

The last part and previous parts are selected 2021-12-02_13-15

VincentLanglet commented 2 years ago

I wouldn't consider this as a bug. And dunno if the expected results is to select the last part of the breadcrumb.

On my browser when I click two times, it select a word. When I click three it select the whole line. The only weird behavior I see is if I click two times on the first word of the last part of the breadcrumb, it select the last word of the previous part of the breadcrumb. (Which gives the "bug" you have)

But I wouldn't consider this as enough to add user-select: none to all the part of the breadcrumb. Someone may want to select another part than the last one.

VincentLanglet commented 2 years ago

Seems like related to the inline-block display on li https://stackoverflow.com/questions/43690276/text-selection-inside-inline-blocks-without-space-between

There are some dirty hacks I'd like to avoid.

The best solution may be to add user-select: all to breadcrumbs > li. It avoid this issue, and it's easier to select a whole li section. On the other side, users won't be able to select part of an li then...

WDYT @sonata-project/contributors

VincentLanglet commented 2 years ago

Closing due to lack of interest