search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Unable to configure routes using admin extension #7726

Closed core23 closed 2 years ago

core23 commented 2 years ago

Environment

Sonata packages

show

``` sonata-project/admin-bundle 4.8.1 4.8.1 The missing Symfony Admin Generator sonata-project/block-bundle 4.9.1 4.9.1 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/classification-bundle 4.0.1 4.0.1 Symfony SonataClassificationBundle sonata-project/datagrid-bundle 3.5.0 3.5.0 Symfony SonataDatagridBundle Package sonata-project/datagrid-bundle is abandoned, you should avoid using it. No replacement was suggested. sonata-project/doctrine-extensions 1.16.0 1.16.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.2.2 4.2.2 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.10.1 2.10.1 Lightweight Exporter library sonata-project/form-extensions 1.12.4 1.12.4 Symfony form extensions sonata-project/intl-bundle 2.11.2 2.11.2 Symfony SonataIntlBundle sonata-project/media-bundle 4.0.0 4.0.0 Symfony SonataMediaBundle sonata-project/seo-bundle 3.0.0 3.0.0 Symfony SonataSeoBundle sonata-project/twig-extensions 1.9.1 1.9.1 Sonata twig extensions ```

Symfony packages

show

``` symfony/asset v5.4.3 v6.0.3 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v5.4.3 v6.0.3 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/cache v5.4.3 v6.0.3 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.5.0 v3.0.0 Generic abstractions related to caching symfony/config v5.4.3 v6.0.3 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.4.3 v6.0.3 Eases the creation of beautiful and testable command line interfaces symfony/debug-bundle v5.4.3 v6.0.3 Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge into the Symfony full-sta... symfony/dependency-injection v5.4.3 v6.0.3 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v3.0.0 v3.0.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.4.3 v6.0.3 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v5.4.3 v6.0.3 Eases DOM navigation for HTML and XML documents symfony/dotenv v5.4.3 v6.0.3 Registers environment variables from a .env file symfony/error-handler v5.4.3 v6.0.3 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.4.3 v6.0.3 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v2.5.0 v3.0.0 Generic abstractions related to dispatching event symfony/expression-language v5.4.3 v6.0.3 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.4.3 v6.0.3 Provides basic utilities for the filesystem symfony/finder v5.4.3 v6.0.3 Finds files and directories via an intuitive fluent interface symfony/flex v1.18.3 v2.1.4 Composer plugin for Symfony symfony/form v5.4.3 v6.0.3 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.4.4 v6.0.4 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.4.3 v6.0.3 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.5.0 v3.0.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.4.3 v6.0.3 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.4.4 v6.0.4 Provides a structured process for converting a Request into a Response symfony/intl v5.4.3 v6.0.3 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mailer v5.4.3 v6.0.3 Helps sending emails symfony/mime v5.4.3 v6.0.3 Allows manipulating MIME messages symfony/monolog-bridge v5.4.3 v6.0.3 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.1 v3.7.1 Symfony MonologBundle symfony/options-resolver v5.4.3 v6.0.3 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.4.3 v6.0.3 Provides password hashing utilities symfony/polyfill-ctype v1.24.0 v1.24.0 Symfony polyfill for ctype functions symfony/polyfill-intl-grapheme v1.24.0 v1.24.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.24.0 v1.24.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.24.0 v1.24.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.24.0 v1.24.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.24.0 v1.24.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.24.0 v1.24.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.24.0 v1.24.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.24.0 v1.24.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.24.0 v1.24.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/polyfill-uuid v1.24.0 v1.24.0 Symfony polyfill for uuid functions symfony/property-access v5.4.3 v6.0.3 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.4.3 v6.0.3 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.4.3 v6.0.3 Provides integration for ProxyManager with various Symfony components symfony/routing v5.4.3 v6.0.3 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.4.3 v6.0.3 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.4.3 v6.0.3 Symfony Security Component - Core Library symfony/security-csrf v5.4.3 v6.0.3 Symfony Security Component - CSRF Library symfony/security-guard v5.4.3 v5.4.3 Symfony Security Component - Guard symfony/security-http v5.4.3 v6.0.3 Symfony Security Component - HTTP Integration symfony/service-contracts v2.4.1 v3.0.0 Generic abstractions related to writing services symfony/stopwatch v5.4.3 v6.0.3 Provides a way to profile code symfony/string v5.4.3 v6.0.3 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/templating v5.4.3 v6.0.3 Provides all the tools needed to build any kind of template system symfony/translation v5.4.3 v6.0.3 Provides tools to internationalize your application symfony/translation-contracts v2.5.0 v3.0.0 Generic abstractions related to translation symfony/twig-bridge v5.4.3 v6.0.3 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.4.3 v6.0.3 Provides a tight integration of Twig into the Symfony full-stack framework symfony/uid v5.4.3 v6.0.3 Provides an object-oriented API to generate and represent UIDs symfony/ux-dropzone v2.0.1 v2.0.1 File input dropzones for Symfony Forms symfony/validator v5.4.3 v6.0.3 Provides tools to validate values symfony/var-dumper v5.4.3 v6.0.3 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.4.3 v6.0.3 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-profiler-bundle v5.4.3 v6.0.3 Provides a development tool that gives detailed information about the execution of any request symfony/webpack-encore-bundle v1.13.2 v1.13.2 Integration with your Symfony app & Webpack Encore! symfony/yaml v5.4.3 v6.0.3 Loads and dumps YAML files ```

PHP version

$ php -v
# Put the result here.

Subject

When you want to modify an admin using the AbstractAdminExtension::configureRoutes extension point, the method will not be called. All other extensions points well be called in the right order.

final class CustomAdminExtension extends AbstractAdminExtension
{
    public function configureRoutes(AdminInterface $admin, RouteCollectionInterface $collection): void
    {
        $collection->add('browse', 'browse', [
            '_controller' => BrowseMediaAction::class,
        ]);
    }
}

It looks like the AbstractAdmin::buildRoutes method is called too soon, before all admin extensions are registered.

Maybe it is related to https://github.com/sonata-project/SonataAdminBundle/pull/7647 which was a refactoring of the routes cache.

VincentLanglet commented 2 years ago

How do you configure the admin extension ? Because this seems to work in my reproducer https://github.com/sonata-project/SonataAdminBundle/pull/7728

Edit: Did you try to clear the cache ?

VincentLanglet commented 2 years ago

I also tried following the second way in the doc. image

core23 commented 2 years ago

This was just a misconfiguration in my application.