fracsi commented 2 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.12.0 4.12.0 The missing Symfony Admin Generator sonata-project/block-bundle 4.12.0 4.12.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested. sonata-project/doctrine-extensions 1.17.0 1.17.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.2.8 4.2.8 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.11.0 2.11.0 Lightweight Exporter library sonata-project/form-extensions 1.16.0 1.16.0 Symfony form extensions sonata-project/twig-extensions 1.10.0 1.10.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' # Put the result here. symfony/amqp-messenger symfony/apache-pack symfony/asset symfony/browser-kit symfony/cache symfony/cache-contracts symfony/config symfony/console symfony/css-selector symfony/debug-bundle symfony/dependency-injection symfony/deprecation-contracts symfony/doctrine-bridge symfony/doctrine-messenger symfony/dom-crawler symfony/dotenv symfony/error-handler symfony/event-dispatcher symfony/event-dispatcher-contracts symfony/expression-language symfony/filesystem symfony/finder symfony/flex symfony/form symfony/framework-bundle symfony/http-client symfony/http-client-contracts symfony/http-foundation symfony/http-kernel symfony/intl symfony/lock symfony/maker-bundle symfony/messenger symfony/monolog-bridge symfony/monolog-bundle symfony/options-resolver symfony/password-hasher symfony/phpunit-bridge symfony/polyfill-intl-grapheme symfony/process symfony/property-access symfony/property-info symfony/proxy-manager-bridge symfony/redis-messenger symfony/routing symfony/runtime symfony/security-acl symfony/security-bundle symfony/security-core symfony/security-csrf symfony/security-guard symfony/security-http symfony/serializer symfony/service-contracts symfony/stopwatch symfony/string symfony/translation symfony/translation-contracts symfony/twig-bridge symfony/twig-bundle symfony/validator symfony/var-dumper symfony/var-exporter symfony/web-link symfony/web-profiler-bundle symfony/webapp-meta symfony/webpack-encore-bundle symfony/yaml ``` v5.4.5 v5.4.5 Symfony AMQP extension Messenger Bridge v1.0.1 v1.0.1 A pack for Apache support in Symfony v5.4.7 v6.0.7 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files v5.4.3 v6.0.3 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically v5.4.8 v6.0.8 Provides an extended PSR-6, PSR-16 (and tags) implementation v2.5.1 v3.0.1 Generic abstractions related to caching v5.4.8 v6.0.8 Helps you find, load, combine, autofill and validate configuration values of any kind v5.4.8 v6.0.8 Eases the creation of beautiful and testable command line interfaces v5.4.3 v6.0.3 Converts CSS selectors to XPath expressions v5.4.3 v6.0.3 Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge into the Symfony full-stack... v5.4.8 v6.0.8 Allows you to standardize and centralize the way objects are constructed in your application v3.0.1 v3.0.1 A generic function and convention to trigger deprecation notices v5.4.8 v6.0.8 Provides integration for Doctrine with various Symfony components v5.4.8 v6.0.8 Symfony Doctrine Messenger Bridge v5.4.6 v6.0.6 Eases DOM navigation for HTML and XML documents v5.4.5 v6.0.5 Registers environment variables from a .env file v5.4.8 v6.0.8 Provides tools to manage errors and ease debugging PHP code v5.4.3 v6.0.3 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them v3.0.1 v3.0.1 Generic abstractions related to dispatching event v5.4.8 v6.0.8 Provides an engine that can compile and evaluate expressions v5.4.7 v6.0.7 Provides basic utilities for the filesystem v5.4.8 v6.0.8 Finds files and directories via an intuitive fluent interface v2.1.8 v2.1.8 Composer plugin for Symfony v5.4.8 v6.0.8 Allows to easily create, process and reuse HTML forms v5.4.8 v6.0.8 Provides a tight integration between Symfony components and the Symfony full-stack framework v5.4.8 v6.0.8 Provides powerful methods to fetch HTTP resources synchronously or asynchronously v2.5.1 v3.0.1 Generic abstractions related to HTTP clients v5.4.8 v6.0.8 Defines an object-oriented layer for the HTTP specification v5.4.8 v6.0.8 Provides a structured process for converting a Request into a Response v5.4.8 v6.0.8 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library v5.4.7 v6.0.7 Creates and manages locks, a mechanism to provide exclusive access to a shared resource v1.43.0 v1.43.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. v5.4.8 v6.0.8 Helps applications send and receive messages to/from other applications or via message queues v5.4.3 v6.0.3 Provides integration for Monolog with various Symfony components v3.8.0 v3.8.0 Symfony MonologBundle v5.4.3 v6.0.3 Provides an improved replacement for the array_replace PHP function v5.4.8 v6.0.8 Provides password hashing utilities v6.0.8 v6.0.8 Provides utilities for PHPUnit, especially user deprecation notices management v1.25.0 v1.25.0 Symfony polyfill for intl's grapheme_* functions v5.4.8 v6.0.8 Executes commands in sub-processes v5.4.8 v6.0.8 Provides functions to read and write from/to an object or array using a simple string notation v5.4.7 v6.0.7 Extracts information about PHP class' properties using metadata of popular sources v5.4.6 v6.0.6 Provides integration for ProxyManager with various Symfony components v5.4.6 v6.0.7 Symfony Redis extension Messenger Bridge v5.4.8 v6.0.8 Maps an HTTP request to a set of configuration variables v5.4.8 v6.0.8 Enables decoupling PHP applications from global state v3.3.1 v3.3.1 Symfony Security Component - ACL (Access Control List) v5.4.8 v6.0.8 Provides a tight integration of the Security component into the Symfony full-stack framework v5.4.8 v6.0.8 Symfony Security Component - Core Library v5.4.3 v6.0.3 Symfony Security Component - CSRF Library v5.4.3 v5.4.3 Symfony Security Component - Guard v5.4.8 v6.0.8 Symfony Security Component - HTTP Integration v5.4.8 v6.0.8 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. v2.5.1 v3.0.1 Generic abstractions related to writing services v5.4.5 v6.0.5 Provides a way to profile code v5.4.8 v6.0.8 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way v5.4.8 v6.0.8 Provides tools to internationalize your application v2.5.1 v3.0.1 Generic abstractions related to translation v5.4.8 v6.0.8 Provides integration for Twig with various Symfony components v5.4.8 v6.0.8 Provides a tight integration of Twig into the Symfony full-stack framework v5.4.8 v6.0.8 Provides tools to validate values v5.4.8 v6.0.8 Provides mechanisms for walking through any arbitrary PHP variable v5.4.8 v6.0.8 Allows exporting any serializable PHP data structure to plain PHP code v5.4.3 v6.0.3 Manages links between resources v5.4.8 v6.0.8 Provides a development tool that gives detailed information about the execution of any request v1.0.0 v1.0.0 A meta package for the web app pack v1.14.1 v1.14.1 Integration with your Symfony app & Webpack Encore! v5.4.3 v6.0.3 Loads and dumps YAML files

PHP version

$ php -v
# Put the result here.
PHP 8.1.6 (cli) (built: May 17 2022 16:48:41) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.6, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.6, Copyright (c), by Zend Technologies

Subject

7824 broke datepicker functionality.

Current version of the datetimepicker library in sonata-project/form-extensions uses .size() function, which is removed in jQuery 3.0 , thus the datepicker in an input group does not work anymore.

Minimal repository with the bug

Steps to reproduce

Add a datepicker form type to any admin with the default 'datepicker_use_button' => true option. This way a bootstrap input-group is rendered by default with a calendar button.

Expected results

The datepicker can be opened by clicking on the calendar button.

Actual results

JS error

jQuery.Deferred exception: o.element.find(...).size is not a function TypeError: o.element.find(...).size is not a function
    at u (https://127.0.0.1:8000/bundles/sonataform/app.js:1:816)
    at new s (https://127.0.0.1:8000/bundles/sonataform/app.js:1:22219)
    at HTMLDivElement.<anonymous> (https://127.0.0.1:8000/bundles/sonataform/app.js:1:22349)
    at Function.each (https://127.0.0.1:8000/bundles/sonataadmin/app.js:1:144954)
    at T.fn.init.each (https://127.0.0.1:8000/bundles/sonataadmin/app.js:1:143433)
    at T.fn.init.e.fn.datetimepicker (https://127.0.0.1:8000/bundles/sonataform/app.js:1:22268)
    at HTMLDocument.<anonymous> (https://127.0.0.1:8000/ep/date-range-unique/create:405:51)
    at c (https://127.0.0.1:8000/bundles/sonataadmin/app.js:1:172313)
    at u (https://127.0.0.1:8000/bundles/sonataadmin/app.js:1:172615)

jordisala1991 commented 2 years ago

We might try to replace the size function with .length.

We are kind of stuck with the jQuery version. If we upgrade we break date picker, if we downgrade we break menu. To me it is better to keep jQuery 3.6 and manually patch the date picker library to be compatible (let's see if it is easy).

Anyway, that library will be upgraded with sonata-project/form-extensions, so it is not a big deal to manually patch it.

VincentLanglet commented 2 years ago

You mean editing https://github.com/sonata-project/form-extensions/blob/1.x/assets/vendor/bootstrap-datetimepicker.min.js ?