search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Object field validation #7954

Closed haivala closed 2 years ago

haivala commented 2 years ago

I'm not sure if this a bug

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 4.20.0 4.20.0 The missing Symfony Admin Generator sonata-project/block-bundle 4.18.0 4.18.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested. sonata-project/classification-bundle 4.3.0 4.3.0 Symfony SonataClassificationBundle sonata-project/doctrine-extensions 1.18.1 2.0.1 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.8.0 4.8.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/entity-audit-bundle 1.9.0 1.9.0 Audit for Doctrine Entities sonata-project/exporter 3.0.0 3.0.0 Lightweight Exporter library sonata-project/form-extensions 1.18.0 1.18.0 Symfony form extensions sonata-project/formatter-bundle 5.0.1 5.0.1 Symfony SonataFormatterBundle sonata-project/media-bundle 4.5.1 4.5.1 Symfony SonataMediaBundle sonata-project/page-bundle 4.0.0-alpha-1 4.0.0-alpha-1 This bundle provides a Site and Page management through container a... sonata-project/seo-bundle 3.5.0 3.5.0 Symfony SonataSeoBundle sonata-project/twig-extensions 2.0.0 2.0.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v5.4.13 v6.1.5 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScri... symfony/cache v5.4.13 v6.1.5 Provides extended PSR-6, PSR-16 (and tags) implementations symfony/cache-contracts v2.5.2 v3.1.1 Generic abstractions related to caching symfony/config v5.4.11 v6.1.3 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.4.14 v6.1.6 Eases the creation of beautiful and testable command line interfaces symfony/debug-bundle v5.4.11 v6.1.3 Provides a tight integration of the Symfony VarDumper component and the ServerLogComm... symfony/dependency-injection v5.4.13 v6.1.5 Allows you to standardize and centralize the way objects are constructed in your appl... symfony/deprecation-contracts v3.1.1 v3.1.1 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.4.14 v6.1.6 Provides integration for Doctrine with various Symfony components symfony/dotenv v5.4.5 v6.1.0 Registers environment variables from a .env file symfony/error-handler v5.4.14 v6.1.6 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.4.9 v6.1.0 Provides tools that allow your application components to communicate with each other ... symfony/event-dispatcher-contracts v3.1.1 v3.1.1 Generic abstractions related to dispatching event symfony/expression-language v5.4.14 v6.1.6 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.4.13 v6.1.5 Provides basic utilities for the filesystem symfony/finder v5.4.11 v6.1.3 Finds files and directories via an intuitive fluent interface symfony/flex v1.19.3 v2.2.3 Composer plugin for Symfony symfony/form v5.4.13 v6.1.5 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.4.14 v6.1.6 Provides a tight integration between Symfony components and the Symfony full-stack fr... symfony/http-client v5.4.14 v6.1.6 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.5.2 v3.1.1 Generic abstractions related to HTTP clients symfony/http-foundation v5.4.14 v6.1.6 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.4.14 v6.1.6 Provides a structured process for converting a Request into a Response symfony/intl v5.4.14 v6.1.6 Provides a PHP replacement layer for the C intl extension that includes additional da... symfony/mailer v5.4.13 v6.1.5 Helps sending emails symfony/maker-bundle v1.47.0 v1.47.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and m... symfony/mime v5.4.14 v6.1.6 Allows manipulating MIME messages symfony/monolog-bridge v5.4.10 v6.1.2 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.8.0 v3.8.0 Symfony MonologBundle symfony/options-resolver v5.4.11 v6.1.0 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.4.11 v6.1.3 Provides password hashing utilities symfony/polyfill-ctype v1.26.0 v1.26.0 Symfony polyfill for ctype functions symfony/polyfill-intl-grapheme v1.26.0 v1.26.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.26.0 v1.26.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.26.0 v1.26.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.26.0 v1.26.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.26.0 v1.26.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v5.4.11 v6.1.3 Executes commands in sub-processes symfony/property-access v5.4.11 v6.1.3 Provides functions to read and write from/to an object or array using a simple string... symfony/property-info v5.4.14 v6.1.6 Extracts information about PHP class' properties using metadata of popular sources symfony/psr-http-message-bridge v2.1.3 v2.1.3 PSR HTTP message bridge symfony/routing v5.4.11 v6.1.5 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.3.2 v3.3.2 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.4.11 v6.1.3 Provides a tight integration of the Security component into the Symfony full-stack fr... symfony/security-core v5.4.14 v6.1.6 Symfony Security Component - Core Library symfony/security-csrf v5.4.11 v6.1.0 Symfony Security Component - CSRF Library symfony/security-guard v5.4.13 v5.4.13 Symfony Security Component - Guard symfony/security-http v5.4.13 v6.1.6 Symfony Security Component - HTTP Integration symfony/serializer v5.4.14 v6.1.6 Handles serializing and deserializing data structures, including object graphs, into ... symfony/service-contracts v2.5.2 v3.1.1 Generic abstractions related to writing services symfony/stopwatch v5.4.13 v6.1.5 Provides a way to profile code symfony/string v5.4.14 v6.1.6 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points an... symfony/translation v5.4.14 v6.1.6 Provides tools to internationalize your application symfony/translation-contracts v2.5.2 v3.1.1 Generic abstractions related to translation symfony/twig-bridge v5.4.14 v6.1.6 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.4.8 v6.1.1 Provides a tight integration of Twig into the Symfony full-stack framework symfony/ux-turbo v2.4.0 v2.4.0 Hotwire Turbo integration for Symfony symfony/validator v5.4.14 v6.1.6 Provides tools to validate values symfony/var-dumper v5.4.14 v6.1.6 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.4.10 v6.1.3 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-profiler-bundle v5.4.14 v6.1.6 Provides a development tool that gives detailed information about the execution of an... symfony/webpack-encore-bundle v1.16.0 v1.16.0 Integration with your Symfony app & Webpack Encore! symfony/yaml v5.4.14 v6.1.6 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 8.1.11 (cli) (built: Oct  6 2022 23:53:25) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.11, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.11, Copyright (c), by Zend Technologies

I have entity that has:

    #[ORM\ManyToOne(targetEntity: Definition::class)]
    #[ORM\JoinColumn(nullable: false)]
    #[Assert\NotBlank]
    private $definition;

In admin I have 

    protected function configureFormFields(FormMapper $form): void
    {
        $form
            ->add('definition', ModelListType::class, [
                'required' => true
            ]);

Steps to reproduce

  1. create new
  2. leave that definition field to null
  3. push create button.

Expected results

There would be error in the form that this definition field cannot be null.

Actual results

create route gives me 500 error after submit because said definition field is null and it is used in __toString method to give the entity a name. Is this how this should work? Can I get example how the preValidate method should be used to get same kind of form error messages as in Sonata 3?

VincentLanglet commented 2 years ago

create route gives me 500 error after submit because said definition field is null and it is used in __toString method to give the entity a name.

What is the toString method of your entity ?

haivala commented 2 years ago

create route gives me 500 error after submit because said definition field is null and it is used in __toString method to give the entity a name.

What is the toString method of your entity ?

return (string) $this->definition->getName();

VincentLanglet commented 2 years ago

Your tostring is invalid for freshly created entity.

If you do $e = new Entity() (String) $e

The code will crash. Thats is exactly what happen.

You should do If (this->definition === null) { Return ''; }

Return (string) This->definition->getName();

haivala commented 2 years ago

OK! Seems to be working. It uses the toString in the flash message to give an error and that is why it was not working.

Can you give me an example how can I use the preValidate method? For example if I have 2 datetime fields and I want to check if the other one is before the other?

VincentLanglet commented 2 years ago

I never used the preValidate method. This was deprecated in 3.x removed in 4.x and 100% of what you can do with can be done with validation constraints from symfony. ;)

But I'm glad the create action works

haivala commented 2 years ago

preValidete is not removed in 4.x but ok. https://docs.sonata-project.org/projects/SonataAdminBundle/en/4.x/reference/saving_hooks/

VincentLanglet commented 2 years ago

Interesting, I always thought this was deprecated but indeed the deprecation was removed here: https://github.com/sonata-project/SonataAdminBundle/pull/7100

But as explained in the PR discussion, this is a method to only modify the data, and not adding extra error messages. For validation, you should prefer using validation constraints from Symfony like a classic form.