search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

AdminExtractor not executed on `translation:extract` command #7977

Closed ZZromanZZ closed 1 year ago

ZZromanZZ commented 1 year ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' Direct dependencies required in composer.json: sonata-project/admin-bundle 4.21.0 4.21.0 The missing Symfony Admin Generator sonata-project/doctrine-orm-admin-bundle 4.8.0 4.8.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.13.0 3.0.0 Lightweight Exporter library Transitive dependencies not required in composer.json: sonata-project/block-bundle 4.19.0 4.19.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested. sonata-project/doctrine-extensions 2.0.1 2.0.1 Doctrine2 behavioral extensions sonata-project/form-extensions 1.18.0 1.18.0 Symfony form extensions sonata-project/twig-extensions 2.0.0 2.0.0 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' Direct dependencies required in composer.json: symfony/asset v5.4.13 v6.1.5 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v5.4.11 v6.1.3 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/console v5.4.15 v6.1.7 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v5.4.11 v6.1.3 Converts CSS selectors to XPath expressions symfony/debug-bundle v5.4.11 v6.1.3 Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge into the Symfony full-stack framework symfony/dotenv v5.4.5 v6.1.0 Registers environment variables from a .env file symfony/expression-language v5.4.14 v6.1.6 Provides an engine that can compile and evaluate expressions symfony/flex v1.19.3 v2.2.3 Composer plugin for Symfony symfony/form v5.4.15 v6.1.7 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.4.14 v6.1.7 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.4.15 v6.1.7 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/intl v5.4.15 v6.1.7 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/maker-bundle v1.48.0 v1.48.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/messenger v5.4.14 v6.1.6 Helps applications send and receive messages to/from other applications or via message queues symfony/monolog-bundle v3.8.0 v3.8.0 Symfony MonologBundle symfony/phpunit-bridge v4.4.47 v6.1.6 Provides utilities for PHPUnit, especially user deprecation notices management symfony/process v5.4.11 v6.1.3 Executes commands in sub-processes symfony/property-access v5.4.15 v6.1.7 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.4.15 v6.1.7 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.4.6 v6.1.0 Provides integration for ProxyManager with various Symfony components symfony/runtime v5.4.11 v6.1.3 Enables decoupling PHP applications from global state symfony/security-bundle v5.4.11 v6.1.3 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/serializer v5.4.15 v6.1.6 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/stopwatch v5.4.13 v6.1.5 Provides a way to profile code symfony/swiftmailer-bundle v3.5.4 v3.5.4 Symfony SwiftmailerBundle Package symfony/swiftmailer-bundle is abandoned, you should avoid using it. Use symfony/mailer instead. symfony/translation v5.4.14 v6.1.6 Provides tools to internationalize your application symfony/twig-bundle v5.4.8 v6.1.1 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.4.15 v6.1.7 Provides tools to validate values symfony/var-dumper v5.4.14 v6.1.6 Provides mechanisms for walking through any arbitrary PHP variable symfony/web-link v5.4.3 v6.1.0 Manages links between resources symfony/web-profiler-bundle v5.4.14 v6.1.6 Provides a development tool that gives detailed information about the execution of any request symfony/webpack-encore-bundle v1.16.0 v1.16.0 Integration with your Symfony app & Webpack Encore! symfony/yaml v5.4.14 v6.1.6 Loads and dumps YAML files Transitive dependencies not required in composer.json: symfony/amqp-messenger v5.4.15 v6.1.7 Symfony AMQP extension Messenger Bridge symfony/cache v5.4.15 v6.1.7 Provides extended PSR-6, PSR-16 (and tags) implementations symfony/cache-contracts v2.5.2 v3.1.1 Generic abstractions related to caching symfony/config v5.4.11 v6.1.3 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/dependency-injection v5.4.13 v6.1.5 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v3.1.1 v3.1.1 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.4.15 v6.1.7 Provides integration for Doctrine with various Symfony components symfony/doctrine-messenger v5.4.12 v6.1.4 Symfony Doctrine Messenger Bridge symfony/dom-crawler v5.4.15 v6.1.7 Eases DOM navigation for HTML and XML documents symfony/error-handler v5.4.15 v6.1.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.4.9 v6.1.0 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v3.1.1 v3.1.1 Generic abstractions related to dispatching event symfony/filesystem v5.4.13 v6.1.5 Provides basic utilities for the filesystem symfony/finder v5.4.11 v6.1.3 Finds files and directories via an intuitive fluent interface symfony/http-client-contracts v2.5.2 v3.1.1 Generic abstractions related to HTTP clients symfony/http-foundation v5.4.15 v6.1.7 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.4.15 v6.1.7 Provides a structured process for converting a Request into a Response symfony/lock v5.4.15 v6.1.7 Creates and manages locks, a mechanism to provide exclusive access to a shared resource symfony/mime v5.4.14 v6.1.7 Allows manipulating MIME messages symfony/monolog-bridge v5.4.10 v6.1.2 Provides integration for Monolog with various Symfony components symfony/options-resolver v5.4.11 v6.1.0 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.4.11 v6.1.3 Provides password hashing utilities symfony/polyfill-intl-grapheme v1.27.0 v1.27.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.27.0 v1.27.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.27.0 v1.27.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.27.0 v1.27.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.27.0 v1.27.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.27.0 v1.27.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.27.0 v1.27.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.27.0 v1.27.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.27.0 v1.27.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/psr-http-message-bridge v2.1.3 v2.1.3 PSR HTTP message bridge symfony/redis-messenger v5.4.15 v6.1.7 Symfony Redis extension Messenger Bridge symfony/routing v5.4.15 v6.1.7 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.3.2 v3.3.2 Symfony Security Component - ACL (Access Control List) symfony/security-core v5.4.15 v6.1.7 Symfony Security Component - Core Library symfony/security-csrf v5.4.11 v6.1.0 Symfony Security Component - CSRF Library symfony/security-guard v5.4.13 v5.4.13 Symfony Security Component - Guard symfony/security-http v5.4.15 v6.1.7 Symfony Security Component - HTTP Integration symfony/service-contracts v2.5.2 v3.1.1 Generic abstractions related to writing services symfony/string v5.4.15 v6.1.7 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/translation-contracts v2.5.2 v3.1.1 Generic abstractions related to translation symfony/twig-bridge v5.4.14 v6.1.7 Provides integration for Twig with various Symfony components symfony/var-exporter v5.4.10 v6.1.3 Allows exporting any serializable PHP data structure to plain PHP code ```

PHP version

$ php -v
PHP 8.1.12 (cli) (built: Oct 28 2022 18:58:22) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.12, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.12, Copyright (c), by Zend Technologies

Subject

As command translation:update is deprecated since Symfony 5.4:

Command "translation:update" is deprecated since version 5.4 and will be removed in Symfony 6.0. Use "translation:extract" instead.

Command translation:extract should execute AdminExtractor too, however this is not happening.

Minimal repository with the bug

Steps to reproduce

Expected results

Actual results

VincentLanglet commented 1 year ago

The same command was renamed by Symfony https://github.com/symfony/symfony/pull/43758 and it's supposed to extract translation from every classes which implements ExtractorInterface

So:

Can you tell us more ?

ZZromanZZ commented 1 year ago

Sorry for bothering, this issue is more likely here https://github.com/php-translation/symfony-bundle/issues/446 and definitely not in Sonata. I am closing this.