search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Unable to use a custom message to be shown as the error flash message #8090

Closed plandolt closed 1 year ago

plandolt commented 1 year ago

Environment

Sonata packages

show

``` Direct dependencies required in composer.json: sonata-project/doctrine-orm-admin-bundle 4.13.0 4.13.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/form-extensions 1.20.0 2.0.0 Symfony form extensions sonata-project/intl-bundle 3.1.0 3.1.0 Symfony SonataIntlBundle sonata-project/translation-bundle 3.3.0 3.3.0 SonataTranslationBundle sonata-project/user-bundle 5.10.0 5.10.0 Symfony SonataUserBundle Transitive dependencies not required in composer.json: sonata-project/admin-bundle 4.26.0 4.26.0 The missing Symfony Admin Generator sonata-project/block-bundle 5.0.1 5.0.1 Symfony SonataBlockBundle sonata-project/doctrine-extensions 2.3.0 2.3.0 Doctrine2 behavioral extensions sonata-project/exporter 3.2.0 3.2.0 Lightweight Exporter library sonata-project/twig-extensions 2.3.0 2.3.0 Sonata twig extensions ```

Symfony packages

show

``` Direct dependencies required in composer.json: symfony/asset v6.3.0 v6.3.0 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v6.3.2 v6.3.2 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/console v6.3.2 v6.3.2 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v6.3.2 v6.3.2 Converts CSS selectors to XPath expressions symfony/debug-bundle v6.3.2 v6.3.2 Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge into the Symfony full-stack framework symfony/doctrine-messenger v6.3.1 v6.3.1 Symfony Doctrine Messenger Bridge symfony/dotenv v6.3.0 v6.3.0 Registers environment variables from a .env file symfony/expression-language v6.3.0 v6.3.0 Provides an engine that can compile and evaluate expressions symfony/flex v2.3.2 v2.3.2 Composer plugin for Symfony symfony/form v6.3.2 v6.3.2 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v6.3.2 v6.3.2 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v6.3.2 v6.3.2 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/intl v6.3.2 v6.3.2 Provides access to the localization data of the ICU library symfony/mailer v6.3.0 v6.3.0 Helps sending emails symfony/maker-bundle v1.50.0 v1.50.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/mime v6.3.3 v6.3.3 Allows manipulating MIME messages symfony/monolog-bundle v3.8.0 v3.8.0 Symfony MonologBundle symfony/notifier v6.3.0 v6.3.0 Sends notifications via one or more channels (email, SMS, ...) symfony/phpunit-bridge v6.3.2 v6.3.2 Provides utilities for PHPUnit, especially user deprecation notices management symfony/process v6.3.2 v6.3.2 Executes commands in sub-processes symfony/property-access v6.3.2 v6.3.2 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v6.3.0 v6.3.0 Extracts information about PHP class' properties using metadata of popular sources symfony/runtime v6.3.2 v6.3.2 Enables decoupling PHP applications from global state symfony/security-bundle v6.3.3 v6.3.3 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/serializer v6.3.3 v6.3.3 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/stopwatch v6.3.0 v6.3.0 Provides a way to profile code symfony/string v6.3.2 v6.3.2 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/translation v6.3.3 v6.3.3 Provides tools to internationalize your application symfony/twig-bundle v6.3.0 v6.3.0 Provides a tight integration of Twig into the Symfony full-stack framework symfony/uid v6.3.0 v6.3.0 Provides an object-oriented API to generate and represent UIDs symfony/validator v6.3.2 v6.3.2 Provides tools to validate values symfony/web-link v6.3.0 v6.3.0 Manages links between resources symfony/web-profiler-bundle v6.3.2 v6.3.2 Provides a development tool that gives detailed information about the execution of any request symfony/webpack-encore-bundle v1.17.1 v2.0.1 Integration with your Symfony app & Webpack Encore! symfony/yaml v6.3.3 v6.3.3 Loads and dumps YAML files Transitive dependencies not required in composer.json: symfony/cache v6.3.2 v6.3.2 Provides extended PSR-6, PSR-16 (and tags) implementations symfony/cache-contracts v3.3.0 v3.3.0 Generic abstractions related to caching symfony/clock v6.3.1 v6.3.1 Decouples applications from the system clock symfony/config v6.3.2 v6.3.2 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/dependency-injection v6.3.2 v6.3.2 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v3.3.0 v3.3.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v6.3.2 v6.3.2 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v6.3.1 v6.3.1 Eases DOM navigation for HTML and XML documents symfony/error-handler v6.3.2 v6.3.2 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v6.3.2 v6.3.2 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v3.3.0 v3.3.0 Generic abstractions related to dispatching event symfony/filesystem v6.3.1 v6.3.1 Provides basic utilities for the filesystem symfony/finder v6.3.3 v6.3.3 Finds files and directories via an intuitive fluent interface symfony/http-client-contracts v3.3.0 v3.3.0 Generic abstractions related to HTTP clients symfony/http-foundation v6.3.2 v6.3.2 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v6.3.3 v6.3.3 Provides a structured process for converting a Request into a Response symfony/messenger v6.3.3 v6.3.3 Helps applications send and receive messages to/from other applications or via message queues symfony/monolog-bridge v6.3.1 v6.3.1 Provides integration for Monolog with various Symfony components symfony/options-resolver v6.3.0 v6.3.0 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v6.3.0 v6.3.0 Provides password hashing utilities symfony/polyfill-intl-grapheme v1.27.0 v1.27.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.27.0 v1.27.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.27.0 v1.27.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.27.0 v1.27.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.27.0 v1.27.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php83 v1.27.0 v1.27.0 Symfony polyfill backporting some PHP 8.3+ features to lower PHP versions symfony/polyfill-uuid v1.27.0 v1.27.0 Symfony polyfill for uuid functions symfony/routing v6.3.3 v6.3.3 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.3.2 v3.3.2 Symfony Security Component - ACL (Access Control List) symfony/security-core v6.3.3 v6.3.3 Symfony Security Component - Core Library symfony/security-csrf v6.3.2 v6.3.2 Symfony Security Component - CSRF Library symfony/security-http v6.3.2 v6.3.2 Symfony Security Component - HTTP Integration symfony/service-contracts v3.3.0 v3.3.0 Generic abstractions related to writing services symfony/translation-contracts v3.3.0 v3.3.0 Generic abstractions related to translation symfony/twig-bridge v6.3.2 v6.3.2 Provides integration for Twig with various Symfony components symfony/var-dumper v6.3.3 v6.3.3 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v6.3.2 v6.3.2 Allows exporting any serializable PHP data structure to plain PHP code ```

PHP version

PHP 8.2.8 (cli) (built: Jul 10 2023 22:45:18) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.8, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.8, Copyright (c), by Zend Technologies

Subject

Cannot use a custom exception in preDelete with the message show up in the red alert flash message.

The PR https://github.com/sonata-project/SonataAdminBundle/pull/7761 was made to allow this behaviour. But after a closer inspection the function handleModelManagerThrowable does not return the message and instead always return null.

VincentLanglet commented 1 year ago

You have to override the handleModelManagerThrowable method if you want to display a custom error message.

plandolt commented 1 year ago

Yeah that worked.