search

sonata-project / SonataAdminBundle

The missing Symfony Admin Generator
https://docs.sonata-project.org/projects/SonataAdminBundle
MIT License
2.11k stars 1.26k forks source link

Support custom ModelManagerException messages #8141

Closed wadjei closed 9 months ago

wadjei commented 9 months ago

Support custom ModelManagerException messages

Add the option of customising the message passed to the FlashBag for caught ModelManagerException by returning a string from your overridden handleModelManagerException() methods.

This is similar to what was done previously for handleModelManagerThrowable() but that code path seems to be unreachable.

The method signature for handleModelManagerException has had its return type removed.

New tests have been added to validate the changes work as intended by way of two new controllers in the Sonata\AdminBundle\Tests\App\Controller namespace: CustomModelManagerThrowableMessageController and CustomModelManagerExceptionMessageController.

I am targeting this branch, because the change addresses an apparent inability to use handleModelManagerThrowable customised message facility from #7761.

Closes #8137

Changelog

### Changed
CRUDController::handleModelManagerException can now return a custom error message string for display in the flashbag instead of Sonata ones. Return type is removed from the signature
VincentLanglet commented 9 months ago

Thanks ; can you take a look at the failing build ?