Closed dmaicher closed 2 years ago
The only remaining thing I'm unsure about is
Is this still useful? :thinking:
Ah and this piece of code here that deals with response TTLs:
useful? :thinking:
The only remaining thing I'm unsure about is
Is this still useful? 🤔
According to the phpdoc it's cache-related https://github.com/sonata-project/SonataBlockBundle/blob/3d589d6bd26f9cab6bd26c2bbea60c04dcaad18a/src/Block/Service/AbstractBlockService.php#L51-L62 So it doesn't seems usefull anymore
@VincentLanglet yeah I believe all caching related things are actually useless now. Let me see if we need more deprecations on 4.x and remove them here.
Could you please rebase your PR and fix merge conflicts?
Thanks @dmaicher
@dmaicher Do you think there is still some PR to do on 4.x or we can create a release with all the deprecations ?
@VincentLanglet for now I think we are good on 4.x :blush: So creating a new release seems good to me.
Then we should also create a new release on SonataAdminBundle to have https://github.com/sonata-project/SonataAdminBundle/pull/7792
Fully remove all deprecated caching functionality