sonata-project / SonataBlockBundle

Symfony SonataBlockBundle
https://docs.sonata-project.org/projects/SonataBlockBundle
MIT License
413 stars 142 forks source link

Remove all caching related functionality #1044

Closed dmaicher closed 2 years ago

dmaicher commented 2 years ago

Fully remove all deprecated caching functionality

dmaicher commented 2 years ago

The only remaining thing I'm unsure about is

https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php#L107

https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php#L72

Is this still useful? :thinking:

dmaicher commented 2 years ago

Ah and this piece of code here that deals with response TTLs:

https://github.com/sonata-project/SonataBlockBundle/blob/0b54efe3d3670e0644967753259db6ebf9c46ca1/src/Block/BlockRenderer.php#L104

useful? :thinking:

VincentLanglet commented 2 years ago

The only remaining thing I'm unsure about is

https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php#L107

https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php#L72

Is this still useful? 🤔

According to the phpdoc it's cache-related https://github.com/sonata-project/SonataBlockBundle/blob/3d589d6bd26f9cab6bd26c2bbea60c04dcaad18a/src/Block/Service/AbstractBlockService.php#L51-L62 So it doesn't seems usefull anymore

dmaicher commented 2 years ago

@VincentLanglet yeah I believe all caching related things are actually useless now. Let me see if we need more deprecations on 4.x and remove them here.

SonataCI commented 2 years ago

Could you please rebase your PR and fix merge conflicts?

jordisala1991 commented 2 years ago

Thanks @dmaicher

VincentLanglet commented 2 years ago

@dmaicher Do you think there is still some PR to do on 4.x or we can create a release with all the deprecations ?

dmaicher commented 2 years ago

@VincentLanglet for now I think we are good on 4.x :blush: So creating a new release seems good to me.

Then we should also create a new release on SonataAdminBundle to have https://github.com/sonata-project/SonataAdminBundle/pull/7792