search

sonata-project / SonataBlockBundle

Symfony SonataBlockBundle
https://docs.sonata-project.org/projects/SonataBlockBundle
MIT License
413 stars 141 forks source link

Drop older versions #1060

Closed jordisala1991 closed 2 years ago

jordisala1991 commented 2 years ago

Subject

I am targeting this branch, because this is for the next major version.

Changelog

### Removed
- Remove support for Symfony ^4.4 and 5.3.x
- Remove support for Twig ^2
- Remove support for `doctrine/common` ^2
jordisala1991 commented 2 years ago

This is what I would like to do, but not sure if this is the correct place:

  1. Drop old versions of doctrine/common and twig (I think this is the correct place, we have done like this on other majors)
  2. Drop older sf versions (this can probably be done on 4.x, but is the correct move or should we wait for 5.0?)
VincentLanglet commented 2 years ago

I would drop only on 5.x IMHO.

jordisala1991 commented 2 years ago

So, you agree on all the changes proposed here?

VincentLanglet commented 2 years ago

So, you agree on all the changes proposed here?

I'm in favor of dropping support for symfony 4.4.

For twig and doctrine/common, I don't know if we win anything by dropping the support. Also, I dunno if some user could have a real reason to be stuck with doctrine common 2 or twig 2. So, I would say I'm ok with the drop, but don't know the impact.

jordisala1991 commented 2 years ago

Dev-kit PR: https://github.com/sonata-project/dev-kit/pull/2014

jordisala1991 commented 2 years ago

Should we also drop php7? (of course in another PR)

VincentLanglet commented 2 years ago

Should we also drop php7? (of course in another PR)

I think we can.