Closed jordisala1991 closed 2 years ago
We have
public function addChildren(self $children): void;
and I assume we will have the same for addChild()
in 5.x.
I think we should try the 5.x branch on PageBundle to see if the issue will be here.
If not, it's a psalm issue with @method
.
It works with 5.x. It is probably a problem with psalm @method annotation. Even thought it should be reported to psalm, isn't it better to fix it here and not get blocked?
It works with 5.x. It is probably a problem with psalm @method annotation. Even thought it should be reported to psalm, isn't it better to fix it here and not get blocked?
Sure, I just wanted to be sure we won't have the issue on 5.x
Subject
I am targeting this branch, because this is BC.
I don't know why, but psalm complains if I don't change this line. Here are 2 examples:
With this changes, Psalm is happy (I think we will need to add checks with 5.x branch for PageBundle.
Changelog