search

sonata-project / SonataBlockBundle

Symfony SonataBlockBundle
https://docs.sonata-project.org/projects/SonataBlockBundle
MIT License
413 stars 141 forks source link

Fix code needed for SonataPageBundle #1100

Closed jordisala1991 closed 2 years ago

jordisala1991 commented 2 years ago

Subject

I am targeting this branch, because this is BC? Not sure if adding an extra parameter on the interface is, or not.

Changelog

### Added
- Add `removeChild` to be consistent with `addChild` for Block Model.
jordisala1991 commented 2 years ago

According to our conversation:

  1. this pr only adds the removechild (needed for the rest of the changes and also for consistency with addChild)
  2. we have to do another pr to deprecate this block (since it can only be used on the SonataAdmin context)
  3. we have to do another pr on SonataPageBundle to stop xtend this block and define all options there, included a exception is the block edit is tried to use outside sonata.
  4. we might want to test this block on sonata page with panther test case (it could be followed up with tests for compose page, to test if js works correctly)
VincentLanglet commented 2 years ago
  1. we have to do another pr to deprecate this block (since it can only be used on the SonataAdmin context)
  2. we have to do another pr on SonataPageBundle to stop xtend this block and define all options there, included a exception is the block edit is tried to use outside sonata.
  3. we might want to test this block on sonata page with panther test case (it could be followed up with tests for compose page, to test if js works correctly)

Do you plan to do it or should we open issues ?

jordisala1991 commented 2 years ago

Yes, I plan to do it.