sonata-project / SonataBlockBundle

Symfony SonataBlockBundle
https://docs.sonata-project.org/projects/SonataBlockBundle
MIT License
413 stars 142 forks source link

Menu parameter as required #1124

Closed eerison closed 2 years ago

eerison commented 2 years ago

Subject

I am targeting this branch, because {reason}.

Changelog


### Changed
- Changed Menu name settings `required` field from `false` to `true` in `getFormSettingsKeys`
eerison commented 2 years ago

This field is required to render Menu

Issue: https://github.com/sonata-project/SonataPageBundle/issues/1495#issuecomment-1269493681

VincentLanglet commented 2 years ago

Can you fix the CI @eerison ?

eerison commented 2 years ago

is it missing something 👀 ?

VincentLanglet commented 2 years ago

is it missing something 👀 ?

time ^^

jordisala1991 commented 2 years ago

Thanks @eerison