Feature/batch flashmessages

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle

MIT License

318 stars 138 forks source link

Closed silasjoisten closed 5 years ago

silasjoisten commented 5 years ago

I am targeting this branch, because this is a bc.

Closes #507

### Added
- support for many grouped flash messages

SonataCI commented 5 years ago

Could you please rebase your PR and fix merge conflicts?

OskarStark commented 5 years ago

Could we add a count of the messages next to the "headline"?

Attention:

{{ app.flashes('success') }}

will clear all messages on the first consume, I think you need to use app.session.flashbag.peek(....)? 🤔 but not totally sure!

silasjoisten commented 5 years ago

One question: I created a new flashmessage.css file... How i implement the usage of this file?

silasjoisten commented 5 years ago

How gets the base.js loaded i dont find any includes or links... even not in AdminBundle? Do you randomly know how?

greg0ire commented 5 years ago

Sorry, I don't :sweat_smile:

silasjoisten commented 5 years ago

So is the translation in all provided languages really necessary? Because just speak 3 of them 😄

OskarStark commented 5 years ago

3 languages are enough here