search

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle
MIT License
318 stars 138 forks source link

Inject adapters on the new doctrine service name #679

Closed jordisala1991 closed 5 years ago

jordisala1991 commented 5 years ago

Subject

I am targeting this branch, because this should be BC.

Changelog

### Fixed
- Adapters are not being injected on the adapter chain.
- `sonata_urlsafeid` twig filter is working again
jordisala1991 commented 5 years ago

Does it makes sense to make this change here or should we move this compiler pass to the sonata-doctrine-extensions, where the chain lives:

https://github.com/sonata-project/sonata-doctrine-extensions/blob/5453bf15b2811d0c3249442897bcc50c67c91d57/src/Bridge/Symfony/Resources/config/doctrine_orm.xml

core23 commented 5 years ago

👍 for the doctrine repo

The core repo should die asap

jordisala1991 commented 5 years ago

ohhh... I see... if the doctrine-extensions repo is not enabled, then this works:

https://github.com/sonata-project/SonataCoreBundle/blob/3.x/src/CoreBundle/DependencyInjection/SonataCoreExtension.php#L80

So the compiler pass should be created on the sonata-doctrine-extensions