Set translation domain for the form validators

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle

MIT License

318 stars 138 forks source link

Set translation domain for the form validators #687

Closed c-Rolland closed 5 years ago

c-Rolland commented 5 years ago

Subject

I am targeting this branch, to give the possibility to set a translation domain for the form validators.

Changelog


### Changed
- Add this buildViolation()->setTranslationDomain() in ErrorElement::addViolation
- Add new parameter "$translationDomain" to ErrorElement::addViolation method

core23 commented 5 years ago

💯 bonus points if you add a test

qsomazzi commented 5 years ago

@sonata-project/release-managers Hello can you create a tag with this change please ? When you got free time of course

kunicmarko20 commented 5 years ago

Posted on slack channel, should be soon

OskarStark commented 5 years ago

@greg0ire are you in the release managers group?

greg0ire commented 5 years ago

Yes

greg0ire commented 5 years ago

I'm going to try to produce a changelog that is less technical