Allow to use symfony/twig-bridge 4.4.0

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle

MIT License

318 stars 138 forks source link

Closed fbourigault closed 4 years ago

fbourigault commented 4 years ago

This allow to use symfony/twig-bridge 4.4.0.

Tests failed because tests depends on code that is now no longer shipped with dist because of the new export-ignore rules.

I need to solve the translator mess to get something working.

fbourigault commented 4 years ago

I don't know how to solve the translator mess.

Basically I have to support 3 interfaces :

Symfony\Component\Translation\TranslatorInterface (deprecated ; from symfony/translation).
Symfony\Contracts\Translation\TranslatorInterface v1.
Symfony\Contracts\Translation\TranslatorInterface v2 (same as v1 with typehints).

That's something really complicated. So, I would like to know what the FormChoiceWidgetTest is really testing?

franmomu commented 4 years ago

As this bundle is deprecated, I'm not sure if it's worth it to support the new interfaces

core23 commented 4 years ago

Support new interfaces is a minor change, which we won't support for this bundle anymore

greg0ire commented 4 years ago

Alternate PR: #723