search

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle
MIT License
318 stars 138 forks source link

Steal Test fixture class from Twig bridge #723

Closed greg0ire closed 4 years ago

greg0ire commented 4 years ago

Subject

The bridge archives have recently been modified so that they no longer contain tests. We were relying on one of the fixtures that came with thes tests. Copying the fixture to our project fixes the issue. Allows using the twig bridge v4.4

See https://github.com/symfony/twig-bridge/commit/3b24df50a23d2a11d459d9e31dc4cffb8f7caf

I am targeting this branch, because this is BC.

Closes #722

Changelog

### Added
- Compatibility with `symfony/twig-bridge` 4.4
greg0ire commented 4 years ago
  1. I forgot one file
  2. Now I understand what mess @fbourigault was talking about… there is an interface that's present in symfony/contracts, which is a recent package…
greg0ire commented 4 years ago

Stand back, I'm trying some black magic

OskarStark commented 4 years ago

Looks like it’s working 😈

fbourigault commented 4 years ago

IMHO, we have to conflict with symfony/translation-contracts >= 2.0 because of the added type hints.

greg0ire commented 4 years ago

Also, the class that relies on these fixtures is not in tests, it's in src… I have to move the fixtures in src otherwise it will crash since we blacklist tests from our archives too.

greg0ire commented 4 years ago

@fbourigault actually, there is no conflict as long as people use php 7.2: https://3v4l.org/Kqeo7

greg0ire commented 4 years ago

I pushed with the conflict, then we can do a release, and if we want we can do another release that requires 7.2 and removes the conflict after that.

core23 commented 4 years ago

Changed the label to patch as we don't release any new minor version

greg0ire commented 4 years ago

I think we are supposed to use patch anyway, but it doesn't make sense to me, that's why I did not say anything regarding the label for the seo bundle.