search

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle
MIT License
318 stars 138 forks source link

Symfony 5 support #732

Closed jorrit closed 4 years ago

jorrit commented 4 years ago

Subject

Although the core bundle is deprecated, it may be hard to remove it as a dependency without breaking BC. This means that in order to enable upgrading bundles depending on the core bundle to update to Symfony 5, Core bundle must be upgraded to Symfony 5 too.

Here I'll try to see if this is possible.

I am targeting this branch, because I want to offer Symfony 5 support for depending modules without a major upgrade.

Changelog

### Added
- Added support for Symfony 5.

To do

VincentLanglet commented 4 years ago

I think that you'll need to fix this issue https://github.com/sonata-project/SonataCoreBundle/issues/731

jorrit commented 4 years ago

@core23 I completely understand that merging this PR is subject to further discussion. I just wanted to see if it is possible at all.

jorrit commented 4 years ago

@core23 Do you think it would be possible to get the latest Dev-Kit files in Sonata Core 3.x?

wbloszyk commented 4 years ago

@jorrit I working on #741 and https://github.com/sonata-project/dev-kit/issues/697.

This mean CoreBundle will be drop in some steps:

This will allow add Symfony 5 support in Sonata 3. I think you can close this PR.