search

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle
MIT License
318 stars 138 forks source link

Replace deprecated ContainerAwareCommand with Command #734

Closed jorrit closed 3 years ago

jorrit commented 4 years ago

Subject

In preparation for SF 5.0 support the usage of ContainerAwareCommand must be removed.

For SonataListFormMappingCommand I've replaced it with a constructor that receives the container. I know this is not the way to use dependency injection, but in this case I think this is justified because it is simplest and the command is not usable in practice.

I am targeting this branch, because is is backwards compatible.

Closes #731

Changelog

### Fixed
- Replaced use of deprecated ContainerAwareCommand with Command.
jorrit commented 4 years ago

@core23 I propose this change to help move #732 forward, which I created to help move https://github.com/sonata-project/SonataAdminBundle/pull/5936 forward.

jordisala1991 commented 3 years ago

Not needed