Move form and twig to standalone bundle

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle

MIT License

318 stars 138 forks source link

Move form and twig to standalone bundle #736

Closed wbloszyk closed 4 years ago

wbloszyk commented 4 years ago

Subject

This PR:

drop form and twig directories
required form- and twig- extensions (version 0.x based on dropped directories and 1.x services)
add deprecations notes
I am targeting this branch, because this PR is BC.

Closes #739

To do

[x] create form-extensions 0.x - https://github.com/sonata-project/form-extensions/pull/79
[x] create twig-extensions 0.x - https://github.com/sonata-project/twig-extensions/pull/74

wbloszyk commented 4 years ago

@greg0ire Can you create 4.x branch from 3.x and target this PR to it?

greg0ire commented 4 years ago

Sorry I didn't see this… is this still relevant?

wbloszyk commented 4 years ago

My bad. I just check something. I will revert it tomorrow.

greg0ire commented 4 years ago

Ok. Please tell me if I still need to create a branch

wbloszyk commented 4 years ago

@greg0ire this PR is not required becouse: https://github.com/sonata-project/SonataAdminBundle/issues/6016#issuecomment-612378919

wbloszyk commented 4 years ago

I change concept of this PR. More information in RP description.

wbloszyk commented 4 years ago

@greg0ire Some tests will be fix by https://github.com/sonata-project/form-extensions/pull/89

wbloszyk commented 4 years ago

@core23 @phansys @greg0ire Can you check it?

BTW i use 0.x-dev extensions becouse I dont wanna w8 for release. It should be replace to tags before release.

greg0ire commented 4 years ago

BTW i use 0.x-dev extensions becouse I dont wanna w8 for release. It should be replace to tags before release.

Should we use 0.1@dev before releasing then? That way we get a green build.

wbloszyk commented 4 years ago

@greg0ire 0.x-dev -work for branch, we dont have to release -BETA version. 0.x is not usable for now anyway. 0.1@dev - is for dev 0.1? or we can use ^0.1@dev ?

greg0ire commented 4 years ago

The build still fails… maybe the solution is 0.1-BETA@dev, I don't know, please try locally.

wbloszyk commented 4 years ago

0.1-BETA@dev works but without last commits. We should use 0.x-dev until make it stable or release next BETA after each PR.

For me we should use 0.x-dev becouse this change is in develop process and should not be used in production.

wbloszyk commented 4 years ago

@greg0ire I will split this PR. First RP with deprecations and aliases should be release as fast as possibe. Second PR (this) will be rebase.

greg0ire commented 4 years ago

Let's close this one then?