search

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle
MIT License
318 stars 138 forks source link

Move serializer to form directory #737

Closed wbloszyk closed 4 years ago

wbloszyk commented 4 years ago

Subject

This PR move serializer to form dictionary, becouse serializer is always used with BaseDoctrineORMSerializationType.

I am targeting this branch, because this is PATCH.

Closes #733

Changelog

### Added
- Added `Sonata\Form\Serializer\BaseSerializerHandler`
- Added `Sonata\Form\Serializer\BaseSerializerHandlerInterface` 
### Deprecated
- Deprecated `Sonata\Serializer\BaseSerializerHandler`
- Deprecated `Sonata\Serializer\BaseSerializerHandlerInterface`
wbloszyk commented 4 years ago

RTM, but I add notice deprecation to 3.19.0. Should I change it to 3.18.1 or you will release it as minor?

greg0ire commented 4 years ago

Change it to 3.x, I usually change the numbers when I release.

greg0ire commented 4 years ago

This occurrence should be updated to use the new name:

https://github.com/sonata-project/SonataCoreBundle/blob/d0f376d0551358609df523d2e63010c5b42c5887/src/CoreBundle/DependencyInjection/SonataCoreExtension.php#L201

wbloszyk commented 4 years ago

Change it to 3.x, I usually change the numbers when I release.

OK. I will remember about it. Should I change it here?

This occurrence should be updated to use the new name:

https://github.com/sonata-project/SonataCoreBundle/blob/d0f376d0551358609df523d2e63010c5b42c5887/src/CoreBundle/DependencyInjection/SonataCoreExtension.php#L201

Sorry for that. So many repeated.

BTW. After release serializer PATCH, I can add it to 0.x extensions backport. Then Core4 + backport extensions will be ready to review. (I test it from my repositories and it is working).

greg0ire commented 4 years ago

OK. I will remember about it. Should I change it here?

No need, keep it that way.

wbloszyk commented 4 years ago

@greg0ire It is RTM. Can you check it?

wbloszyk commented 4 years ago

It is little confusing but it is OK.

wbloszyk commented 4 years ago

@greg0ire It is RTM and checked.

greg0ire commented 4 years ago

Both Travis and FlintCI are failing, please run make cs-fix

wbloszyk commented 4 years ago

Travis is failing becouse FlintCl. FlintCl is failing but this PR is not the reason. Look at it.

wbloszyk commented 4 years ago

@phansys @greg0ire Can you merge it? I need it before start working on #739

greg0ire commented 4 years ago

Sure! Thanks @wbloszyk !