search

sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle
MIT License
319 stars 139 forks source link

Fix #748 #749

Closed wbloszyk closed 4 years ago

wbloszyk commented 4 years ago

Subject

I am targeting this branch, because it is BC and PATCH.

Closes #748 

## Fixed
- Display again flash message
VincentLanglet commented 4 years ago

I'll be happy to merge this, but I don't really understand the changes ^^'

@dmaicher Could you confirm that the PR fix the issue by requiring the branch in your composer.json ?

wbloszyk commented 4 years ago

@VincentLanglet Before this PR sonata.core.flashmessage.manager was service, sonata.core.flashmessage.twig.runtime was alias. This mean runtime configure sonata.twig.flashmessage.manager and sonata.core.flashmessage.manager was without configure. Now sonata.core.flashmessage.manager is alias for sonata.twig.flashmessage.manager. This mean configure is the same object.

Sonata\CoreBundle\FlashMessage\FlashManager is class_alias to Sonata\Twig\FlashMessage\FlashManager. This mean they are equal.

In #751 I move creating aliases to compiler pass. This change allow use sonata.twig.flashmessage.manager created in other bundle, so FormBundle and TwigBundle bridge can be register. User should stop using core and use extensions instead.

After #751 and https://github.com/sonata-project/dev-kit/issues/697 SonataCoreBundle will be optional.

dmaicher commented 4 years ago

I'll be happy to merge this, but I don't really understand the changes ^^'

@dmaicher Could you confirm that the PR fix the issue by requiring the branch in your composer.json ?

I can confirm this fix works :+1:

VincentLanglet commented 4 years ago

Thanks to both of you

VincentLanglet commented 4 years ago

@greg0ire If you find some time, I think we will need a 3.19.1 release 😁

greg0ire commented 4 years ago

I'm quite busy with Doctrine, please use #releases to ask for new releases when this is actually ready to be released.