sonata-project / SonataCoreBundle

[deprecated] SonataCoreBundle
MIT License
319 stars 139 forks source link

Improve core before split - CoreBundle 3.19.2 #751

Closed wbloszyk closed 4 years ago

wbloszyk commented 4 years ago

Subject

Allow register bridges by move aliases to compiler pass. Override CoreBundle config will throw exception about move this config to registred bridges.

I am targeting this branch, because these changes respect BC.

Changelog

### Changed
- change register aliases from bundle configuration to compiler pass
### Fixed
- fixed register CoreBundle with form and twig bridges 

This PR should be release as 3.19.2

wbloszyk commented 4 years ago

It can be release as 3.20 too. I will change reqiurements in feature PRs then.

wbloszyk commented 4 years ago

@VincentLanglet I check something. This PR replace creating alias from xml files to compiler pass. It can be trait as patch or minor. Some change is already merge. Better keep it as 3.19.2 to avoid fix it in production.

jordisala1991 commented 4 years ago

I did a couple of PR on your fork to improve this PR, feel free to merge them or use portions of code to help finish this PR.

wbloszyk commented 4 years ago

I have long weekend. I will back to home tomorrow. Some change look nice.

VincentLanglet commented 4 years ago

@VincentLanglet I check something. This PR replace creating alias from xml files to compiler pass. It can be trait as patch or minor. Some change is already merge. Better keep it as 3.19.2 to avoid fix it in production.

I don't understand.

Patch is for bugfix. Minor is for new feature.

Are you fixing a bug ? I don't think so. You're adding new CompilerPass and you're adding deprecation.

If someone require 3.19.x. Updating automatically from 3.19.1 to 3.19.2 could break a CI because of the deprecation for example. There is certainly other possible impact.

Even if we're deprecating the bundle, we should still respect the SemVer.

wbloszyk commented 4 years ago

I adding fix, becouse bridges exist and can't be register. It is not new feature too

jordisala1991 commented 4 years ago

Thank you @wbloszyk !