Closed wbloszyk closed 4 years ago
It can be release as 3.20 too. I will change reqiurements in feature PRs then.
@VincentLanglet I check something. This PR replace creating alias from xml files to compiler pass. It can be trait as patch or minor. Some change is already merge. Better keep it as 3.19.2 to avoid fix it in production.
I did a couple of PR on your fork to improve this PR, feel free to merge them or use portions of code to help finish this PR.
I have long weekend. I will back to home tomorrow. Some change look nice.
@VincentLanglet I check something. This PR replace creating alias from xml files to compiler pass. It can be trait as patch or minor. Some change is already merge. Better keep it as 3.19.2 to avoid fix it in production.
I don't understand.
Patch is for bugfix. Minor is for new feature.
Are you fixing a bug ? I don't think so. You're adding new CompilerPass and you're adding deprecation.
If someone require 3.19.x. Updating automatically from 3.19.1 to 3.19.2 could break a CI because of the deprecation for example. There is certainly other possible impact.
Even if we're deprecating the bundle, we should still respect the SemVer.
I adding fix, becouse bridges exist and can't be register. It is not new feature too
Thank you @wbloszyk !
Subject
Allow register bridges by move aliases to compiler pass. Override CoreBundle config will throw exception about move this config to registred bridges.
I am targeting this branch, because these changes respect BC.
Changelog
This PR should be release as 3.19.2