Something is wrong with DoctrinePager/ElasticaPager, DoctrineProxyQuery/ElasticaProxyQuery

[VincentLanglet]

The sonata datagrid bundle is exposing

Sonata\DatagridBundle\Pager\Doctrine\Pager :

• This class use the doctrine/orm library. But this one is only in the require-dev of the composer.json.
• This class is the same than Sonata\DoctrineORMAdminBundle\Datagrid\Pager but without all the improvement/bugfix made recently.

Sonata\DatagridBundle\Pager\Elastica\Pager :

• This class use the Elastica\Search class. But nothing is require in the composer.json.
• There is the line $countQuery->getResults()->getTotalHits(); which can't work since getResults return an array according to the interface. There are some other weird stuff in the class that makes me think this one doesn't work.

Sonata\DatagridBundle\ProxyQuery\Doctrine\ProxyQuery :

• This class use the doctrine/orm library. But this one is only in the require-dev of the composer.json.
• This class is the same than Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery but without all the improvement/bugfix made recently.

Sonata\DatagridBundle\ProxyQuery\Elastica\ProxyQuery :

• This class use the Elastica\Search class. But nothing is require in the composer.json.
• This class extends the BasProxyQuery class which works with a Doctrine\ORM\QueryBuilder.
• There is the line $query->setSort which can't work since query is a doctrine querybuilder and doesn't have a setSort function. There are some other weird stuff in the class that makes me think this one doesn't work.

IMHO, the two Elastica classes doesn't work and should be removed.

And we should find a way to remove the doctrine-orm dependency from this bundle. We can

• Still not requiring doctrine/ORM in order to not restrict the bundle to one doctrine storage.
• Keeping Sonata\DatagridBundle\ProxyQuery\Doctrine\ProxyQuery and Sonata\DatagridBundle\Pager\Doctrine\Pager until we find a solution.
• Deprecate these classes when the solution is found.

A solution could be to deprecate Sonata\DatagridBundle\ProxyQuery\Doctrine\ProxyQuery in favor of Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery and same for Pager.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[VincentLanglet]

The package will be deprecated anyway.