search

sonata-project / SonataDoctrineORMAdminBundle

Integrate Doctrine ORM into the SonataAdminBundle
https://docs.sonata-project.org/projects/SonataDoctrineORMAdminBundle
MIT License
445 stars 344 forks source link

EmptyFilter config entry not removed together with the class #1375

Closed VasilAnanievTH closed 3 years ago

VasilAnanievTH commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle dev-master 96a6af1 dev-master 96a6af1 The missing Symfony Admin Generator sonata-project/block-bundle 4.5.3 4.5.3 Symfony SonataBlockBundle sonata-project/cache 2.1.1 2.1.1 Cache library sonata-project/doctrine-extensions 1.12.0 1.12.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle dev-master 67ac215 dev-master 67ac215 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.6.1 2.6.1 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/translation-bundle dev-master cb6ec7d dev-master cb6ec7d SonataTranslationBundle sonata-project/twig-extensions 1.5.1 1.5.1 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v5.2.4 v5.2.4 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/cache v5.2.6 v5.2.6 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.2.0 v2.2.0 Generic abstractions related to caching symfony/config v5.2.4 v5.2.4 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.2.6 v5.2.6 Eases the creation of beautiful and testable command line interfaces symfony/debug-bundle v5.2.4 v5.2.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework symfony/debug-pack v1.0.9 v1.0.9 A debug pack for Symfony projects symfony/dependency-injection v5.2.6 v5.2.6 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.2.0 v2.2.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.2.6 v5.2.6 Provides integration for Doctrine with various Symfony components symfony/dotenv v5.2.4 v5.2.4 Registers environment variables from a .env file symfony/error-handler v5.2.6 v5.2.6 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.2.4 v5.2.4 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v2.2.0 v2.2.0 Generic abstractions related to dispatching event symfony/expression-language v5.2.4 v5.2.4 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.2.6 v5.2.6 Provides basic utilities for the filesystem symfony/finder v5.2.4 v5.2.4 Finds files and directories via an intuitive fluent interface symfony/flex v1.12.2 v1.12.2 Composer plugin for Symfony symfony/form v5.2.6 v5.2.6 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.2.6 v5.2.6 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.2.6 v5.2.6 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.3.1 v2.3.1 Generic abstractions related to HTTP clients symfony/http-foundation v5.2.4 v5.2.4 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.2.6 v5.2.6 Provides a structured process for converting a Request into a Response symfony/intl v5.2.4 v5.2.4 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/maker-bundle v1.30.2 v1.30.2 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/mime v5.2.6 v5.2.6 Allows manipulating MIME messages symfony/monolog-bridge v5.2.5 v5.2.5 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.6.0 v3.6.0 Symfony MonologBundle symfony/options-resolver v5.2.4 v5.2.4 Provides an improved replacement for the array_replace PHP function symfony/orm-pack v2.1.0 v2.1.0 A pack for the Doctrine ORM symfony/phpunit-bridge v5.2.6 v5.2.6 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.22.1 v1.22.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.22.1 v1.22.1 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.22.1 v1.22.1 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.22.1 v1.22.1 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.22.1 v1.22.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php72 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions symfony/polyfill-php73 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-uuid v1.22.1 v1.22.1 Symfony polyfill for uuid functions symfony/process v5.2.4 v5.2.4 Executes commands in sub-processes symfony/profiler-pack v1.0.5 v1.0.5 A pack for the Symfony web profiler symfony/property-access v5.2.4 v5.2.4 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.2.4 v5.2.4 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.2.4 v5.2.4 Provides integration for ProxyManager with various Symfony components symfony/psr-http-message-bridge v2.1.0 v2.1.0 PSR HTTP message bridge symfony/routing v5.2.6 v5.2.6 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.1.1 v3.1.1 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.2.6 v5.2.6 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.2.6 v5.2.6 Symfony Security Component - Core Library symfony/security-csrf v5.2.4 v5.2.4 Symfony Security Component - CSRF Library symfony/security-guard v5.2.4 v5.2.4 Symfony Security Component - Guard symfony/security-http v5.2.6 v5.2.6 Symfony Security Component - HTTP Integration symfony/serializer v5.2.4 v5.2.4 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/serializer-pack v1.0.4 v1.0.4 A pack for the Symfony serializer symfony/service-contracts v2.2.0 v2.2.0 Generic abstractions related to writing services symfony/stopwatch v5.2.4 v5.2.4 Provides a way to profile code symfony/string v5.2.6 v5.2.6 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/translation v5.2.6 v5.2.6 Provides tools to internationalize your application symfony/translation-contracts v2.3.0 v2.3.0 Generic abstractions related to translation symfony/twig-bridge v5.2.6 v5.2.6 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.2.4 v5.2.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.2.6 v5.2.6 Provides tools to validate values symfony/var-dumper v5.2.6 v5.2.6 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.2.4 v5.2.4 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v5.2.5 v5.2.5 Manages links between resources symfony/web-profiler-bundle v5.2.6 v5.2.6 Provides a development tool that gives detailed information about the execution of any request symfony/webpack-encore-bundle v1.11.1 v1.11.1 Integration with your Symfony app & Webpack Encore! symfony/workflow v5.2.4 v5.2.4 Provides tools for managing a workflow or finite state machine symfony/yaml v5.2.5 v5.2.5 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.14 (cli) (built: Jan 12 2021 02:26:27) ( NTS )

Subject

The entry for the EmptyFilter in the doctrine_orm_filter_types.xml on lines 43-45 is still present which throws an error when trying to access any page.

Minimal repository with the bug

Steps to reproduce

Expected results

Actual results

Symfony\Component\DependencyInjection\Exception\InvalidArgumentException:
Class "Sonata\DoctrineORMAdminBundle\Filter\EmptyFilter" used for service "Sonata\DoctrineORMAdminBundle\Filter\EmptyFilter" cannot be found.

  at /app/vendor/sonata-project/admin-bundle/src/DependencyInjection/Compiler/AddFilterTypeCompilerPass.php:45
  at Sonata\AdminBundle\DependencyInjection\Compiler\AddFilterTypeCompilerPass->process(object(ContainerBuilder))
     (/app/vendor/symfony/dependency-injection/Compiler/Compiler.php:91)
  at Symfony\Component\DependencyInjection\Compiler\Compiler->compile(object(ContainerBuilder))
     (/app/vendor/symfony/dependency-injection/ContainerBuilder.php:736)
  at Symfony\Component\DependencyInjection\ContainerBuilder->compile()
     (/app/vendor/symfony/http-kernel/Kernel.php:541)
  at Symfony\Component\HttpKernel\Kernel->initializeContainer()
     (/app/vendor/symfony/http-kernel/Kernel.php:780)
  at Symfony\Component\HttpKernel\Kernel->preBoot()
     (/app/vendor/symfony/http-kernel/Kernel.php:183)
  at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
     (/app/public/index.php:83)
VasilAnanievTH commented 3 years ago

Thanks for the fast resolve of the issue! I guess this bug can be closed now. :)

franmomu commented 3 years ago

Thanks for reporting it!