search

sonata-project / SonataDoctrineORMAdminBundle

Integrate Doctrine ORM into the SonataAdminBundle
https://docs.sonata-project.org/projects/SonataDoctrineORMAdminBundle
MIT License
445 stars 344 forks source link

Bulk delete in list view not working #1434

Closed Joost385 closed 3 years ago

Joost385 commented 3 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle dev-master b79b8a4 dev-master b79b8a4 The missing Symfony Admin Generator sonata-project/block-bundle 4.5.3 4.5.3 Symfony SonataBlockBundle sonata-project/cache 2.1.1 2.1.1 Cache library sonata-project/doctrine-extensions 1.12.0 1.12.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle dev-master 43b0e4d dev-master 43b0e4d Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.6.2 2.6.2 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.9.0 Symfony form extensions sonata-project/twig-extensions 1.5.1 1.5.1 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v5.2.7 v5.2.7 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/cache v5.2.7 v5.2.7 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v5.2.7 v5.2.7 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.2.7 v5.2.7 Eases the creation of beautiful and testable command line interfaces symfony/dependency-injection v5.2.7 v5.2.7 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.2.7 v5.2.7 Provides integration for Doctrine with various Symfony components symfony/dotenv v5.2.4 v5.2.4 Registers environment variables from a .env file symfony/error-handler v5.2.7 v5.2.7 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.2.4 v5.2.4 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v2.4.0 v2.4.0 Generic abstractions related to dispatching event symfony/expression-language v5.2.7 v5.2.7 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.2.7 v5.2.7 Provides basic utilities for the filesystem symfony/finder v5.2.4 v5.2.4 Finds files and directories via an intuitive fluent interface symfony/flex v1.12.2 v1.12.2 Composer plugin for Symfony symfony/form v5.2.7 v5.2.7 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.2.7 v5.2.7 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.2.7 v5.2.7 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.2.7 v5.2.7 Provides a structured process for converting a Request into a Response symfony/intl v5.2.7 v5.2.7 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/options-resolver v5.2.4 v5.2.4 Provides an improved replacement for the array_replace PHP function symfony/polyfill-intl-grapheme v1.22.1 v1.22.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.22.1 v1.22.1 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-normalizer v1.22.1 v1.22.1 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.22.1 v1.22.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php73 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.22.1 v1.22.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/property-access v5.2.4 v5.2.4 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.2.7 v5.2.7 Extracts information about PHP class' properties using metadata of popular sources symfony/routing v5.2.7 v5.2.7 Maps an HTTP request to a set of configuration variables symfony/security-acl v3.1.2 v3.1.2 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.2.7 v5.2.7 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.2.7 v5.2.7 Symfony Security Component - Core Library symfony/security-csrf v5.2.7 v5.2.7 Symfony Security Component - CSRF Library symfony/security-guard v5.2.4 v5.2.4 Symfony Security Component - Guard symfony/security-http v5.2.7 v5.2.7 Symfony Security Component - HTTP Integration symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing services symfony/stopwatch v5.2.7 v5.2.7 Provides a way to profile code symfony/string v5.2.6 v5.2.6 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/translation v5.2.7 v5.2.7 Provides tools to internationalize your application symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to translation symfony/twig-bridge v5.2.7 v5.2.7 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.2.4 v5.2.4 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.2.7 v5.2.7 Provides tools to validate values symfony/var-dumper v5.2.7 v5.2.7 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.2.7 v5.2.7 Allows exporting any serializable PHP data structure to plain PHP code symfony/yaml v5.2.7 v5.2.7 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 8.0.5 (cli) (built: Apr 30 2021 00:45:40) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.5, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.5, Copyright (c), by Zend Technologies

Subject

Steps to reproduce

Create a simple Entity with an admin, create a few entities and try to delete them using the bulk action in the list view. Note that the problem occurs both when selecting just one and multiple for deletion.

image

Expected results

Delete action going through on single and multiple selections.

Actual results

Deletion does not work, the following error is thrown: Cannot use object of type App\Entity\Post as array.

image

Joost385 commented 3 years ago

@VincentLanglet I pasted it below. Everything is relatively recent I think:

doctrine/annotations                1.12.1 1.12.1 Docblock Annotations Parser
doctrine/cache                      1.11.0 2.0.0  PHP Doctrine Cache library is a popular cache implementation that supports many different drivers such as redis, memcache, apc, m...
doctrine/collections                1.6.7  1.6.7  PHP Doctrine Collections library that adds additional functionality on top of PHP arrays.
doctrine/common                     3.1.2  3.1.2  PHP Doctrine Common project is a library that provides additional functionality that other Doctrine projects depend on such as be...
doctrine/dbal                       2.13.1 3.1.0  Powerful PHP database abstraction layer (DBAL) with many features for database schema introspection and management.
doctrine/deprecations               v0.5.3 v0.5.3 A small layer on top of trigger_error(E_USER_DEPRECATED) or PSR-3 logging with options to disable all deprecations or selectively...
doctrine/doctrine-bundle            2.3.1  2.3.1  Symfony DoctrineBundle
doctrine/doctrine-migrations-bundle 3.1.1  3.1.1  Symfony DoctrineMigrationsBundle
doctrine/event-manager              1.1.1  1.1.1  The Doctrine Event Manager is a simple PHP event system that was built to be used with the various Doctrine projects.
doctrine/inflector                  2.0.3  2.0.3  PHP Doctrine Inflector is a small library that can perform string manipulations with regard to upper/lowercase and singular/plura...
doctrine/instantiator               1.4.0  1.4.0  A small, lightweight utility to instantiate objects in PHP without invoking their constructors
doctrine/lexer                      1.2.1  1.2.1  PHP Doctrine Lexer parser library that can be used in Top-Down, Recursive Descent Parsers.
doctrine/migrations                 3.1.2  3.1.2  PHP Doctrine Migrations project offer additional functionality on top of the database abstraction layer (DBAL) for versioning you...
doctrine/orm                        2.8.4  2.8.4  Object-Relational-Mapper for PHP
doctrine/persistence                2.1.0  2.1.0  The Doctrine Persistence project is a set of shared interfaces and functionality that the different Doctrine object mappers share.
doctrine/sql-formatter              1.1.1  1.1.1  a PHP SQL highlighting library
VincentLanglet commented 3 years ago

Does this https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/1435 fix the issue ?

It seems like iterate was returning an array of array but toIterable is returning an array of object here.

Joost385 commented 3 years ago

Does this #1435 fix the issue ?

It seems like iterate was returning an array of array but toIterable is returning an array of object here.

@VincentLanglet Yes that fixes the issue. Thank you for looking into it :)