Batch actions not working when using Symfony Ulid as identifier for entity

michealmouner commented 2 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' sonata-project/admin-bundle 3.105.0 4.5.1 The missing Symfony Admin Generator sonata-project/block-bundle 3.23.2 4.9.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/cache-bundle 3.3.0 3.4.0 This bundle provides caching services sonata-project/classification-bundle 3.16.0 3.18.0 Symfony SonataClassificationBundle sonata-project/datagrid-bundle 3.3.0 3.5.0 Symfony SonataDatagridBundle sonata-project/doctrine-extensions 1.13.1 1.16.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 3.35.0 4.2.1 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/entity-audit-bundle 1.4.0 v2.0.0 Audit for Doctrine Entities sonata-project/exporter 2.7.0 2.9.1 Lightweight Exporter library sonata-project/form-extensions 1.9.0 1.12.4 Symfony form extensions sonata-project/formatter-bundle 4.5.0 4.6.1 Symfony SonataFormatterBundle sonata-project/media-bundle 3.32.0 3.37.1 Symfony SonataMediaBundle sonata-project/notification-bundle 3.13.0 3.13.0 Symfony SonataNotificationBundle sonata-project/page-bundle 3.23.0 3.25.0 This bundle provides a Site and Page management through container and block services sonata-project/seo-bundle 2.13.1 3.0.0 Symfony SonataSeoBundle sonata-project/twig-extensions 1.8.0 1.9.1 Sonata twig extensions ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/amqp-messenger symfony/asset symfony/browser-kit symfony/cache symfony/cache-contracts symfony/config symfony/console symfony/css-selector symfony/debug symfony/dependency-injection symfony/deprecation-contracts symfony/doctrine-bridge symfony/doctrine-messenger symfony/dom-crawler symfony/dotenv symfony/error-handler symfony/event-dispatcher symfony/event-dispatcher-contracts symfony/expression-language symfony/filesystem symfony/finder symfony/flex symfony/form symfony/framework-bundle symfony/http-client symfony/http-client-contracts symfony/http-foundation symfony/http-kernel symfony/intl symfony/lock symfony/mailchimp-mailer symfony/mailer symfony/maker-bundle symfony/messenger symfony/mime symfony/monolog-bridge symfony/monolog-bundle symfony/notifier symfony/options-resolver symfony/phpunit-bridge symfony/polyfill-php80 symfony/polyfill-php81 symfony/polyfill-uuid symfony/process symfony/property-access symfony/property-info symfony/proxy-manager-bridge symfony/psr-http-message-bridge symfony/redis-messenger symfony/routing symfony/security-acl symfony/security-bundle symfony/security-core symfony/security-csrf symfony/security-guard symfony/security-http symfony/serializer symfony/service-contracts symfony/stopwatch symfony/string symfony/templating symfony/translation symfony/translation-contracts symfony/twig-bridge symfony/twig-bundle symfony/uid symfony/validator symfony/var-dumper symfony/var-exporter symfony/web-profiler-bundle symfony/webpack-encore-bundle symfony/workflow symfony/yaml ``` v5.4.0 v6.0.1 Symfony AMQP extension Messenger Bridge v5.2.12 v6.0.1 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files v5.4.0 v6.0.1 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically v5.3.12 v6.0.1 Provides an extended PSR-6, PSR-16 (and tags) implementation v2.5.0 v3.0.0 Generic abstractions related to caching v4.4.34 v6.0.0 Helps you find, load, combine, autofill and validate configuration values of any kind v4.4.34 v6.0.1 Eases the creation of beautiful and testable command line interfaces v5.4.0 v6.0.1 Converts CSS selectors to XPath expressions v4.4.31 v4.4.31 Provides tools to ease debugging PHP code v4.4.34 v6.0.1 Allows you to standardize and centralize the way objects are constructed in your application v2.5.0 v3.0.0 A generic function and convention to trigger deprecation notices v4.4.34 v6.0.1 Provides integration for Doctrine with various Symfony components v5.4.0 v6.0.1 Symfony Doctrine Messenger Bridge v5.4.0 v6.0.1 Eases DOM navigation for HTML and XML documents v5.4.0 v6.0.1 Registers environment variables from a .env file v4.4.34 v6.0.1 Provides tools to manage errors and ease debugging PHP code v4.4.34 v6.0.1 Provides tools that allow your application components to communicate with each other by dispatching events and listening to... v1.1.11 v3.0.0 Generic abstractions related to dispatching event v5.4.0 v6.0.1 Provides an engine that can compile and evaluate expressions v5.4.0 v6.0.0 Provides basic utilities for the filesystem v5.4.0 v6.0.0 Finds files and directories via an intuitive fluent interface v1.17.6 v2.0.1 Composer plugin for Symfony v4.4.34 v6.0.1 Allows to easily create, process and reuse HTML forms v4.4.34 v6.0.1 Provides a tight integration between Symfony components and the Symfony full-stack framework v5.4.0 v6.0.1 Provides powerful methods to fetch HTTP resources synchronously or asynchronously v2.5.0 v3.0.0 Generic abstractions related to HTTP clients v4.4.34 v6.0.1 Defines an object-oriented layer for the HTTP specification v4.4.35 v6.0.1 Provides a structured process for converting a Request into a Response v5.4.0 v6.0.1 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library v5.4.0 v6.0.1 Creates and manages locks, a mechanism to provide exclusive access to a shared resource v5.4.0 v6.0.0 Symfony Mailchimp Mailer Bridge v5.4.0 v6.0.1 Helps sending emails v1.36.4 v1.36.4 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing bo... v5.4.0 v6.0.1 Helps applications send and receive messages to/from other applications or via message queues v5.4.0 v6.0.1 Allows manipulating MIME messages v5.2.12 v6.0.1 Provides integration for Monolog with various Symfony components v3.7.1 v3.7.1 Symfony MonologBundle v5.2.12 v6.0.1 Sends notifications via one or more channels (email, SMS, ...) v4.4.30 v6.0.0 Provides an improved replacement for the array_replace PHP function v5.4.0 v6.0.0 Provides utilities for PHPUnit, especially user deprecation notices management v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions v1.23.0 v1.23.0 Symfony polyfill for uuid functions v4.4.35 v6.0.0 Executes commands in sub-processes v5.4.0 v6.0.0 Provides functions to read and write from/to an object or array using a simple string notation v5.4.0 v6.0.0 Extracts information about PHP class' properties using metadata of popular sources v4.4.34 v6.0.1 Provides integration for ProxyManager with various Symfony components v2.1.2 v2.1.2 PSR HTTP message bridge v5.4.0 v6.0.1 Symfony Redis extension Messenger Bridge v4.4.34 v6.0.1 Maps an HTTP request to a set of configuration variables v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) v4.4.34 v6.0.1 Provides a tight integration of the Security component into the Symfony full-stack framework v4.4.34 v6.0.1 Symfony Security Component - Core Library v5.2.12 v6.0.1 Symfony Security Component - CSRF Library v4.4.27 v5.4.0 Symfony Security Component - Guard v4.4.34 v6.0.1 Symfony Security Component - HTTP Integration v5.4.0 v6.0.1 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like... v2.5.0 v3.0.0 Generic abstractions related to writing services v5.4.0 v6.0.0 Provides a way to profile code v5.4.0 v6.0.1 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way v4.4.30 v6.0.1 Provides all the tools needed to build any kind of template system v4.4.34 v6.0.1 Provides tools to internationalize your application v2.5.0 v3.0.0 Generic abstractions related to translation v4.4.34 v6.0.1 Provides integration for Twig with various Symfony components v4.4.30 v6.0.1 Provides a tight integration of Twig into the Symfony full-stack framework v5.4.0 v6.0.1 Provides an object-oriented API to generate and represent UIDs v4.4.35 v6.0.1 Provides tools to validate values v5.4.0 v6.0.1 Provides mechanisms for walking through any arbitrary PHP variable v5.4.0 v6.0.0 Allows exporting any serializable PHP data structure to plain PHP code v4.4.31 v6.0.1 Provides a development tool that gives detailed information about the execution of any request v1.13.1 v1.13.2 Integration with your Symfony app & Webpack Encore! v5.4.0 v6.0.1 Provides tools for managing a workflow or finite state machine v5.3.11 v6.0.1 Loads and dumps YAML files

PHP version

$ php -v
PHP 8.0.11 (cli) (built: Sep 26 2021 20:58:36) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.11, Copyright (c) Zend Technologies
    with Xdebug v3.1.0, Copyright (c) 2002-2021, by Derick Rethans

Subject

context: batch delete action for entity with Symfony\Component\Uid\Ulid as identifier

<?php

namespace App\Entity;

use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\Uid\Ulid;

/**
 * @ORM\Table(name="table_name")
 * @ORM\Entity
 */
class ClassName
{
    /**
     * @ORM\Id
     * @ORM\Column(type="ulid")
     */
    private Ulid $id;

   .....
}

Minimal repository with the bug

reference line from latest version seems not fixed too 🤞 https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/4.x/src/Model/ModelManager.php#L320

query parameters should be binary not string in this case

ex: Ulid::fromString($ulidString)->toBinary()

Steps to reproduce

Create entity with Symfony\Component\Uid\Ulid as identifier
Create sonata CRUD for this entity
make sure batch action delete is allowed (or any batch action)
try to delete using batch action

Expected results

Delete the selected records and green flash msg on success.

Actual results

Green flash msg said that the data deleted successfully but it didn't delete anything.

VincentLanglet commented 2 years ago

I would say we cannot consider this as a bug since UUID (and certainly Ulid) are not considered as supported currently by SonataAdmin. See https://github.com/sonata-project/SonataAdminBundle/issues/7327.

But any contribution is welcomed.

VincentLanglet commented 2 years ago

I'll close this in favor of https://github.com/sonata-project/SonataAdminBundle/issues/7327

sonata-project / SonataDoctrineORMAdminBundle