search

sonata-project / SonataDoctrineORMAdminBundle

Integrate Doctrine ORM into the SonataAdminBundle
https://docs.sonata-project.org/projects/SonataDoctrineORMAdminBundle
MIT License
445 stars 344 forks source link

Filter Services should be puplic so they wouldn't get removed? #1665

Closed Hanmac closed 2 years ago

Hanmac commented 2 years ago

Environment

Sonata packages

show

``` $ composer show --latest 'sonata-project/*' # Put the result here. sonata-project/admin-bundle 4.12.0 4.12.0 The missing Symfony Admin Generator sonata-project/block-bundle 4.13.0 4.13.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested. sonata-project/doctrine-extensions 1.17.0 1.17.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.3.0 4.3.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.13.0 2.13.0 Lightweight Exporter library sonata-project/form-extensions 1.17.1 1.17.1 Symfony form extensions sonata-project/intl-bundle 2.12.1 2.12.1 Symfony SonataIntlBundle sonata-project/twig-extensions 1.10.0 1.10.0 Sonata twig extensions sonata-project/user-bundle 5.1.0 5.1.0 Symfony SonataUserBundle ```

Symfony packages

show

``` $ composer show --latest 'symfony/*' symfony/asset v5.4.7 v5.4.7 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/cache v5.4.9 v5.4.9 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.5.1 v2.5.1 Generic abstractions related to caching symfony/config v5.4.9 v5.4.9 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.4.9 v5.4.9 Eases the creation of beautiful and testable command line interfaces symfony/dependency-injection v5.4.9 v5.4.9 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.5.1 v2.5.1 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.4.9 v5.4.9 Provides integration for Doctrine with various Symfony components symfony/dotenv v5.4.5 v5.4.5 Registers environment variables from a .env file symfony/error-handler v5.4.9 v5.4.9 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.4.9 v5.4.9 Provides tools that allow your application components to communicate with each other by dispatching events and li... symfony/event-dispatcher-contracts v2.5.1 v2.5.1 Generic abstractions related to dispatching event symfony/expression-language v5.4.8 v5.4.8 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.4.9 v5.4.9 Provides basic utilities for the filesystem symfony/finder v5.4.8 v5.4.8 Finds files and directories via an intuitive fluent interface symfony/flex v1.19.2 v1.19.2 Composer plugin for Symfony symfony/form v5.4.9 v5.4.9 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.4.9 v5.4.9 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-foundation v5.4.9 v5.4.9 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.4.9 v5.4.9 Provides a structured process for converting a Request into a Response symfony/intl v5.4.8 v5.4.8 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mailer v5.4.8 v5.4.8 Helps sending emails symfony/maker-bundle v1.43.0 v1.43.0 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about ... symfony/mime v5.4.9 v5.4.9 Allows manipulating MIME messages symfony/monolog-bridge v5.4.3 v5.4.3 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.8.0 v3.8.0 Symfony MonologBundle symfony/options-resolver v5.4.3 v5.4.3 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.4.8 v5.4.8 Provides password hashing utilities symfony/polyfill-intl-grapheme v1.26.0 v1.26.0 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.26.0 v1.26.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.26.0 v1.26.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.26.0 v1.26.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.26.0 v1.26.0 Symfony polyfill for the Mbstring extension symfony/polyfill-php73 v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/property-access v5.4.8 v5.4.8 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.4.9 v5.4.9 Extracts information about PHP class' properties using metadata of popular sources symfony/routing v5.4.8 v5.4.8 Maps an HTTP request to a set of configuration variables symfony/runtime v5.4.8 v5.4.8 Enables decoupling PHP applications from global state symfony/security-acl v3.3.1 v3.3.1 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.4.9 v5.4.9 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.4.8 v5.4.8 Symfony Security Component - Core Library symfony/security-csrf v5.4.9 v5.4.9 Symfony Security Component - CSRF Library symfony/security-guard v5.4.9 v5.4.9 Symfony Security Component - Guard symfony/security-http v5.4.9 v5.4.9 Symfony Security Component - HTTP Integration symfony/serializer v5.4.9 v5.4.9 Handles serializing and deserializing data structures, including object graphs, into array structures or other fo... symfony/service-contracts v2.5.1 v2.5.1 Generic abstractions related to writing services symfony/stopwatch v5.4.5 v5.4.5 Provides a way to profile code symfony/string v5.4.9 v5.4.9 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a uni... symfony/templating v5.4.3 v5.4.3 Provides all the tools needed to build any kind of template system symfony/translation v5.4.9 v5.4.9 Provides tools to internationalize your application symfony/translation-contracts v2.5.1 v2.5.1 Generic abstractions related to translation symfony/twig-bridge v5.4.9 v5.4.9 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.4.8 v5.4.8 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.4.8 v5.4.8 Provides tools to validate values symfony/var-dumper v5.4.9 v5.4.9 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.4.9 v5.4.9 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-profiler-bundle v5.4.8 v5.4.8 Provides a development tool that gives detailed information about the execution of any request symfony/yaml v5.4.3 v5.4.3 Loads and dumps YAML files ```

PHP version

$ php -v
PHP 7.4.21 (cli) (built: Jul  1 2021 19:26:44) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.21, Copyright (c), by Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans

Subject

Minimal repository with the bug

Steps to reproduce

    protected function configureDatagridFilters(DatagridMapper $filter) : void
    {
        $filter
            //->add('id')
            ->add('time'      ,'sonata.admin.orm.filter.type.datetime_range', [
                'field_type' => DateTimeRangePickerType::class
            ], ['label' => 'Zeit']);
    }

Expected results

Filter does appear

Actual results

No attached service to type named sonata.admin.orm.filter.type.datetime_range

RuntimeException:
No attached service to type named `sonata.admin.orm.filter.type.datetime_range`

  at vendor/sonata-project/admin-bundle/src/Filter/FilterFactory.php:33
  at Sonata\AdminBundle\Filter\FilterFactory->create('time', 'sonata.admin.orm.filter.type.datetime_range', array('field_type' => 'Sonata\\Form\\Type\\DateTimeRangePickerType', 'label' => 'Zeit', 'field_mapping' => array('fieldName' => 'time', 'type' => 'datetime', 'scale' => null, 'length' => null, 'unique' => false, 'nullable' => false, 'precision' => null, 'columnName' => 'time'), 'field_name' => 'time'))
     (vendor/sonata-project/doctrine-orm-admin-bundle/src/Builder/DatagridBuilder.php:152)
  at Sonata\DoctrineORMAdminBundle\Builder\DatagridBuilder->addFilter(object(Datagrid), 'sonata.admin.orm.filter.type.datetime_range', object(FieldDescription))
     (vendor/sonata-project/admin-bundle/src/Datagrid/DatagridMapper.php:112)

also this works, but that isn't the point, because that is a different service i think

    protected function configureDatagridFilters(DatagridMapper $filter) : void
    {
        $filter
            ->add('time'      , DateTimeRangeFilter::class, [
                'field_type' => DateTimeRangePickerType::class
            ], ['label' => 'Zeit']);
    }

imo the filter services should probably define aliases?

Edit: Hm the Problem might be in AddFilterTypeCompolerPass from AdminBundle it may or may not be on purpose

VincentLanglet commented 2 years ago

this works, but that isn't the point, because that is a different service i think

That's not a different service, but the way to use this filter.

The same way you're doing $formBuilder->add('foo', TextType::class).

Hanmac commented 2 years ago

there are a few problems i see with the service being unable to decorate or being unable to have two services with different parameters use the same class

would be better if the filter services would use their classes names as alias