sonata-project / SonataDoctrineORMAdminBundle

Integrate Doctrine ORM into the SonataAdminBundle
https://docs.sonata-project.org/projects/SonataDoctrineORMAdminBundle
MIT License
445 stars 345 forks source link

Add support for Doctrine DBAL 4 and ORM 3 #1796

Closed dmaicher closed 6 months ago

dmaicher commented 6 months ago

Subject

I am targeting this branch, because its BC.

Fixes https://github.com/sonata-project/SonataDoctrineORMAdminBundle/issues/1774

Changelog

### Added
- compatibility with `doctrine/dbal` 4 and `doctrine/orm` 3
dmaicher commented 6 months ago

I'm blocked by one test fail where I'm not sure if its an ORM bug or an issue on our side :confused:

[critical] Uncaught PHP Exception PHPUnit\Framework\Error\Warning: "Undefined property: Doctrine\ORM\Mapping\OneToOneInverseSideMapping::$joinColumns" at IdentityFunction.php line 40

See https://github.com/doctrine/orm/blob/3907872046b9a697860f51266714c2eb8e3b19d0/src/Query/AST/Functions/IdentityFunction.php#L40

Looks more like an ORM issue to me. @greg0ire any idea? Shall I open an issue for it on ORM?

@greg0ire never mind. It was an issue on our end :+1: found it after some more debugging. Sorry for the noise.

dmaicher commented 6 months ago

Tests are finally green :smile:

Shall we move ahead without https://github.com/sonata-project/EntityAuditBundle/issues/59 ? Shall I maybe create a separate workflow file (not managed by devkit) for the time being so we are running CI on DBAL 4 and ORM 3?

VincentLanglet commented 6 months ago

Tests are finally green 😄

Shall we move ahead without sonata-project/EntityAuditBundle#59 ? Shall I maybe create a separate workflow file (not managed by devkit) for the time being so we are running CI on DBAL 4 and ORM 3?

I'm ok with this strategy