search

sonata-project / SonataEasyExtendsBundle

[deprecated] Prototype to easily share entities across Bundle and Application
https://sonata-project.org/
MIT License
168 stars 47 forks source link

The declared functionality is not released #112

Closed vyshkant closed 7 years ago

vyshkant commented 7 years ago

Hi.

The official manual page contains the description of the functionality, that is not released yet (see https://sonata-project.org/bundles/easy-extends/master/doc/reference/why.html)

I'm using Symfony v3.2.7. I decidet to use SonataMediaBundle 3.5.1, which requires SonataEasyExtendsBundle ^2.1. Then I read the documentation and saw, that I can use --namespace option of :generate command to customize the namespace:

Also note that the –namespace option allows you to choose the base namespace, such as Application\Sonata. Default destination is Application\:vendor.

But in the fact I cannot use the --namespace option, because the commit providing it (https://github.com/sonata-project/SonataEasyExtendsBundle/pull/80) is not released yet (the latest release 2.1.10 does not contain it).

greg0ire commented 7 years ago

See the master part in the url you are showing us? It means you are reading the documentation for master. Please read the documentation for 2.x

vyshkant commented 7 years ago

https://sonata-project.org/bundles/easy-extends/2-x/doc/reference/why.html tells the same:

Also note that the –namespace option allows you to choose the base namespace, such as Application\Sonata. Default destination is Application\:vendor.
greg0ire commented 7 years ago

Then maybe we just need a new release? The functionality is on 2.x, isn't it?

greg0ire commented 7 years ago

https://github.com/sonata-project/SonataEasyExtendsBundle/releases shows there are 119 commits since last release (!) I'll ask for a release rightaway

vyshkant commented 7 years ago

I'm not sure if all of the new functionality is on 2.x branch, but the --namespace option is on it.

vyshkant commented 7 years ago

Not really 119 commits, because the 2.0.0 is only shown as the latest but is not latest. The latest is 2.1.10 (https://github.com/sonata-project/SonataEasyExtendsBundle/releases/tag/2.1.10) and there are 38 commits since it. I think that 2.0.0 is decided (by github) as "latest" because it was made last (in time). But the last in commits hierarchy as I see is 2.1.10.

greg0ire commented 7 years ago

Oh good, you're right! The functionality you are looking for still probably is in these 38 commits.

vyshkant commented 7 years ago

Yes, exactly.

greg0ire commented 7 years ago

A new release was created, please try it.

vyshkant commented 7 years ago

Thanks! There is also a problem with the backward compatibility of external bundles because of a lot of hardcode like Application\Sonata\MediaBundle... in theirs files.

For example, the compatibility with SonataMediaBundle had been broken: https://github.com/sonata-project/SonataMediaBundle/pull/1250