search

sonata-project / SonataEasyExtendsBundle

[deprecated] Prototype to easily share entities across Bundle and Application
https://sonata-project.org/
MIT License
168 stars 47 forks source link

Drop php 5 #125

Closed greg0ire closed 7 years ago

greg0ire commented 7 years ago

I am targeting this branch, because this is a huge BC-break.

In case of bug fix, 2.x MUST be targeted.

Changelog

### Removed
- support for PHP < 7.1

Subject

This PR adds type hinting to classes.

greg0ire commented 7 years ago

The master build still has php 5 jobs... what the hell?

SonataCI commented 7 years ago

Could you please rebase your PR and fix merge conflicts?

greg0ire commented 7 years ago

Finished! @sonata-project/contributors @jlamur please review

greg0ire commented 7 years ago

Fixed @jlamur ! @sonata-project/contributors please review

OskarStark commented 7 years ago

Awesome work @greg0ire 🎉