sonata-project / SonataEasyExtendsBundle

[deprecated] Prototype to easily share entities across Bundle and Application
https://sonata-project.org/
MIT License
168 stars 47 forks source link

More SF4 compatibility: CLI-commands #162

Closed BOAWEB closed 6 years ago

BOAWEB commented 6 years ago

I am targeting this branch, because this is the branch used for compatibility with SF4.

Closes #161

Changelog

### Fixed
- Register commands explicitly in `commands.xml`
- Generator services are now public

Subject

To be able to use this Bundle with SF4, especially the CLI-commands, there were some changes to be made. Commands defined were not showing up at all.

greg0ire commented 6 years ago

Please associate your boa.be email address with your Github account, or change the email in your commits to an address already associated with it.

greg0ire commented 6 years ago

For bonus points, squash your last commit with the commit that introduced the red pictogram

greg0ire commented 6 years ago

Thanks @BOAWEB

jordisala1991 commented 6 years ago

If we said to make them public why did you merge before it was changed @greg0ire ? 😅

greg0ire commented 6 years ago

If we said to make them public why did you merge before it was changed @greg0ire ? :sweat_smile:

WAT?