search

sonata-project / SonataEasyExtendsBundle

[deprecated] Prototype to easily share entities across Bundle and Application
https://sonata-project.org/
MIT License
168 stars 47 forks source link

Changed default namespace to App #209

Closed core23 closed 5 years ago

core23 commented 5 years ago

Subject

According to symfony, the application namespace should be App

Fixes #172

Changelog

### Changed
- Changed generated namespace to `App`
OskarStark commented 5 years ago

IMO we should release a major to be clear to the users

core23 commented 5 years ago

IMO we should release a major to be clear to the users

So I should change this on the master branch?

OskarStark commented 5 years ago

If @greg0ire is with us, then yes 👍

greg0ire commented 5 years ago

If this results in people trying to follow docs they saw in other bundles and complain that we should fix the docs, then yeah, we probably should release this as a major change. Is it the case?

core23 commented 5 years ago

Please review @sonata-project/contributors

I want to prepare a new major release for this bundle

kunicmarko20 commented 5 years ago

Didn't we say we are gonna deprecate this in favour of symfony recipes? didn't check the pr

core23 commented 5 years ago

Didn't we say we are gonna deprecate this in favour of symfony recipes? didn't check the pr

What should we deprecate? This bundle or the command?

kunicmarko20 commented 5 years ago

The bundle. btw I added a feature namespace_prefx to support symfony 4, I guess that can also be dropped if you plan to release a new major with this change.

core23 commented 5 years ago

The bundle. btw I added a feature namespace_prefx to support symfony 4, I guess that can also be dropped if you plan to release a new major with this change.

I would keep this bundle, because there are people who are not using symfony flex and rely on the bundle generation.

I will remove the namespace_prefx feature later this evening.

OskarStark commented 5 years ago

But I think this cannot work because you cannot use SensioGeneratorBundle with Symfony 4, right?

core23 commented 5 years ago

We don't need SensioGeneratorBundle for this... :confused:

kunicmarko20 commented 5 years ago

IIRC, this generates everything from skeletons, so it should still work.

core23 commented 5 years ago

So, should we deprecate this bundle and stop working on this stuff?

kunicmarko20 commented 5 years ago

@covex-nn started adding all the recipes and that was the idea, but you just mentioned that someone could use sonata without flex. This is true only for < sf4 https://github.com/symfony/symfony-standard

rande commented 5 years ago

@core23 don't bury the bundle too quickly as it is used to dynamically configure relationship inside Sonata's bundles, see https://github.com/sonata-project/SonataMediaBundle/blob/3.x/src/DependencyInjection/SonataMediaExtension.php#L274-L356 for a good example.

Thomas

kunicmarko20 commented 5 years ago

Hi @rande, we discussed this on slack and the plan is to move the collector to doctrine extension repository https://github.com/sonata-project/sonata-doctrine-extensions/pull/127

SonataCI commented 5 years ago

Could you please rebase your PR and fix merge conflicts?

core23 commented 5 years ago

Closing, because we will deprecate this bundle soon