search

sonata-project / SonataEasyExtendsBundle

[deprecated] Prototype to easily share entities across Bundle and Application
https://sonata-project.org/
MIT License
168 stars 47 forks source link

Fix PhpStorm findings #229

Closed franmomu closed 4 years ago

franmomu commented 4 years ago

Not sure if this should be in the changelog. My plan after this was to do this in master branch:

core23 commented 4 years ago

If you can fix all phpstan findings, can you add it as a GH action?

greg0ire commented 4 years ago

@core23 it says phpstORM in the title

core23 commented 4 years ago

Too early in the morning :laughing:

franmomu commented 4 years ago

If you can fix all phpstan findings, can you add it as a GH action?

I'm going try it

greg0ire commented 4 years ago

I'm going try it

wait so does this has to do with phpstorm, phpstan or both?

franmomu commented 4 years ago

I'm going try it

wait so does this has to do with phpstorm, phpstan or both?

I was for phpstorm at first, but fixing that also fixed some phpstan issues I believe 😬 . Should I open another PR with just the last commit?

OskarStark commented 4 years ago

No need for this overhead. Ready to merge?

franmomu commented 4 years ago

The entity classes can't be final because doctrine can't create proxy classes extending from them

greg0ire commented 4 years ago

Thanks @franmomu !