search

sonata-project / SonataFormatterBundle

Symfony SonataFormatterBundle
https://docs.sonata-project.org/projects/SonataFormatterBundle
MIT License
81 stars 117 forks source link

Symfony 5 support #463

Closed gam6itko closed 2 years ago

gam6itko commented 4 years ago

Feature Request

Are you planning to add support for Symfon5?

core23 commented 4 years ago

Are you planning to add support for Symfon5?

Yes, but no one has started it. Maybe you can help @gam6itko ?

jorrit commented 4 years ago

A while ago I started with it on https://github.com/jorrit/SonataFormatterBundle/tree/symfony5, but the dev dependencies media-bundle and admin-bundle are not compatible with Symfony 5 yet. These bundles are only needed for CkeditorAdminController and CkeditorAdminControllerTest. Perhaps the tests can be made optional somehow, otherwise it will take a while before the formatter bundle is compatible with Symfony 5.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

medsalah91 commented 3 years ago

Hello, Are you planning to add this issu ?

core23 commented 3 years ago

Hello, Are you planning to add this issu ?

We as the core team / reviewers are not actively working on the issue at the moment. Maybe you can help to finish this @medsalah91

VincentLanglet commented 3 years ago

We currently are working on the SonataMediaBundle, which is a requirement for this.

balazscsaba2006 commented 2 years ago

@core23 Since MediaBundle has already support for ^5.3, can this PR https://github.com/sonata-project/SonataFormatterBundle/pull/622 be merged? Do you need help with it?

ger86 commented 2 years ago

I have added support por SF 5.3 in this branch:

https://github.com/ger86/SonataFormatterBundle/tree/symfony5

It contains more changes than provided by @balazscsaba2006 to fix some errors. Do you want me to create a PR?

VincentLanglet commented 2 years ago

Any help on https://github.com/sonata-project/dev-kit/issues/1715 is welcomed.

But be sure to target the 5.x branch since adding support for Sonata 4/Symfony 5 will introduce some BC break I think.

VincentLanglet commented 2 years ago

5.x now support Sf5, feel free to try this unstable branch until we finished a stable release (it will still take some time)