sonata-project / SonataFormatterBundle

Symfony SonataFormatterBundle
https://docs.sonata-project.org/projects/SonataFormatterBundle
MIT License
81 stars 117 forks source link

Fix BlockService to work with current Form #721

Closed haivala closed 1 year ago

haivala commented 1 year ago

Subject

I am targeting this branch, because {reason}.

Closes #{put_issue_number_here}.

Changelog

### Fixed
- Fix FormatterBlockService to work with current form.
haivala commented 1 year ago

With this code the block works in SonataPageBundle 4.x

jordisala1991 commented 1 year ago

Can you add a changelog?

haivala commented 1 year ago

Can you add a changelog?

Sure I can. What should I write? Fixed: FormatterBlockService works with current form ?

jordisala1991 commented 1 year ago

There are 2 things:

  1. the changed code is about formatterType changes on 5.0, it has nothing to do about page
  2. It could still be compat with page 3. But still even if this bundle does not use/declare anything about page, it wont be compatible because of shared deps like admin.
jordisala1991 commented 1 year ago

Cs fixer needs to be fixed. Rector not sure how to fix it tho, it seems to be incompatible with some latest release of phpstan.

haivala commented 1 year ago

What should i do with rector?

VincentLanglet commented 1 year ago

What should i do with rector?

Just ignore it, we'll merge the pr ;)

jordisala1991 commented 1 year ago

Thank you @haivala . Take a look at my last edit for the changelog, this is how it should look like to be able to auto generate the final changelog for the release.