Closed nicolas-anaxago closed 3 years ago
``` $ composer show --latest 'sonata-project/*' sonata-project/doctrine-extensions 1.13.1 1.14.0 Doctrine2 behavioral ex... sonata-project/exporter 2.7.0 2.8.0 Lightweight Exporter li... sonata-project/form-extensions 1.9.0 1.11.0 Symfony form extensions sonata-project/intl-bundle 2.10.2 2.10.2 Symfony SonataIntlBundle sonata-project/media-bundle 4.x-dev d30dcd2 4.x-dev d30dcd2 Symfony SonataMediaBundle sonata-project/twig-extensions 1.7.0 1.9.0 Sonata twig extensions ```
``` $ composer show --latest 'symfony/*' symfony/asset v4.4.27 v5.3.4 Manages URL generation and versioning o... symfony/browser-kit v5.3.4 v5.3.4 Simulates the behavior of a web browser... symfony/cache v4.4.27 v5.3.8 Provides an extended PSR-6, PSR-16 (and... symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v4.4.27 v5.3.4 Helps you find, load, combine, autofill... symfony/console v4.4.29 v5.3.7 Eases the creation of beautiful and tes... symfony/css-selector v4.4.27 v5.3.4 Converts CSS selectors to XPath express... symfony/debug v4.4.27 v4.4.31 Provides tools to ease debugging PHP code symfony/debug-bundle v5.1.11 v5.3.4 Provides a tight integration of the Sym... symfony/dependency-injection v4.4.27 v5.3.8 Allows you to standardize and centraliz... symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to tr... symfony/doctrine-bridge v4.4.27 v5.3.8 Provides integration for Doctrine with ... symfony/dom-crawler v5.3.4 v5.3.7 Eases DOM navigation for HTML and XML d... symfony/dotenv v4.4.29 v5.3.8 Registers environment variables from a ... symfony/error-handler v4.4.27 v5.3.7 Provides tools to manage errors and eas... symfony/event-dispatcher v4.4.27 v5.3.7 Provides tools that allow your applicat... symfony/event-dispatcher-contracts v1.1.9 v2.4.0 Generic abstractions related to dispatc... symfony/expression-language v4.4.27 v5.3.7 Provides an engine that can compile and... symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesy... symfony/finder v4.4.27 v5.3.7 Finds files and directories via an intu... symfony/flex v1.14.0 v1.16.3 Composer plugin for Symfony symfony/form v4.4.27 v5.3.8 Allows to easily create, process and re... symfony/framework-bundle v4.4.27 v5.3.8 Provides a tight integration between Sy... symfony/http-client v4.4.27 v5.3.8 Provides powerful methods to fetch HTTP... symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP cl... symfony/http-foundation v5.3.6 v5.3.7 Defines an object-oriented layer for th... symfony/http-kernel v4.4.29 v5.3.9 Provides a structured process for conve... symfony/intl v4.4.27 v5.3.8 Provides a PHP replacement layer for th... symfony/messenger v4.4.27 v5.3.9 Helps applications send and receive mes... symfony/mime v5.3.4 v5.3.8 Allows manipulating MIME messages symfony/monolog-bridge v4.4.27 v5.3.7 Provides integration for Monolog with v... symfony/monolog-bundle v3.4.0 v3.7.0 Symfony MonologBundle symfony/notifier v5.0.8 v5.3.9 A library to notify messages symfony/options-resolver v4.4.27 v5.3.7 Provides an improved replacement for th... symfony/orm-pack v1.0.8 v2.1.0 A pack for the Doctrine ORM symfony/phpunit-bridge v5.3.4 v5.3.8 Provides utilities for PHPUnit, especia... symfony/polyfill-ctype v1.23.0 v1.23.0 Symfony polyfill for ctype functions symfony/polyfill-iconv v1.12.0 v1.23.0 Symfony polyfill for the Iconv extension symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* ... symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related... symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_asci... symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer ... symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring exten... symfony/polyfill-php56 v1.20.0 v1.20.0 Symfony polyfill backporting some PHP 5... symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7... symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7... symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8... symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8... symfony/process v4.4.27 v5.3.7 Executes commands in sub-processes symfony/property-access v5.3.4 v5.3.8 Provides functions to read and write fr... symfony/property-info v5.3.4 v5.3.8 Extracts information about PHP class' p... symfony/routing v4.4.27 v5.3.7 Maps an HTTP request to a set of config... symfony/security-bundle v4.4.27 v5.3.8 Provides a tight integration of the Sec... symfony/security-core v4.4.29 v5.3.8 Symfony Security Component - Core Library symfony/security-csrf v5.3.4 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v4.4.27 v5.3.7 Symfony Security Component - Guard symfony/security-http v4.4.27 v5.3.8 Symfony Security Component - HTTP Integ... symfony/serializer v4.4.27 v5.3.8 Handles serializing and deserializing d... symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing... symfony/stopwatch v5.3.4 v5.3.4 Provides a way to profile code symfony/string v5.3.3 v5.3.7 Provides an object-oriented API to stri... symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v4.4.27 v5.3.7 Provides all the tools needed to build ... symfony/translation v4.4.27 v5.3.9 Provides tools to internationalize your... symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to transla... symfony/twig-bridge v4.4.27 v5.3.7 Provides integration for Twig with vari... symfony/twig-bundle v4.4.27 v5.3.4 Provides a tight integration of Twig in... symfony/validator v4.4.29 v5.3.8 Provides tools to validate values symfony/var-dumper v5.3.6 v5.3.8 Provides mechanisms for walking through... symfony/var-exporter v5.3.4 v5.3.8 Allows exporting any serializable PHP d... symfony/web-link v4.4.27 v5.3.4 Manages links between resources symfony/web-profiler-bundle v5.0.11 v5.3.8 Symfony WebProfilerBundle symfony/webpack-encore-bundle v1.12.0 v1.12.0 Integration with your Symfony app & Web... symfony/yaml v4.4.29 v5.3.6 Loads and dumps YAML files ```
$ php -v PHP 7.4.23 (cli) (built: Aug 26 2021 15:51:55) ( NTS ) Copyright (c) The PHP Group Zend Engine v3.4.0, Copyright (c) Zend Technologies with Zend OPcache v7.4.23, Copyright (c), by Zend Technologies
CDN path missing when asking public URL for a file provider reference context .
Pretty sure there is a missing return at line 197.
return
https://github.com/sonata-project/SonataMediaBundle/blob/d30dcd295f4a10833cf77d8360759bb66cae054a/src/Provider/FileProvider.php#L194-L201
I can open a PR but I'm not sure how to cover this with a test.
PR open https://github.com/sonata-project/SonataMediaBundle/pull/2156
nicolas-anaxago
commented
3 years ago nicolas-anaxago
commented
3 years ago
Environment
Sonata packages
show
``` $ composer show --latest 'sonata-project/*' sonata-project/doctrine-extensions 1.13.1 1.14.0 Doctrine2 behavioral ex... sonata-project/exporter 2.7.0 2.8.0 Lightweight Exporter li... sonata-project/form-extensions 1.9.0 1.11.0 Symfony form extensions sonata-project/intl-bundle 2.10.2 2.10.2 Symfony SonataIntlBundle sonata-project/media-bundle 4.x-dev d30dcd2 4.x-dev d30dcd2 Symfony SonataMediaBundle sonata-project/twig-extensions 1.7.0 1.9.0 Sonata twig extensions ```
Symfony packages
show
``` $ composer show --latest 'symfony/*' symfony/asset v4.4.27 v5.3.4 Manages URL generation and versioning o... symfony/browser-kit v5.3.4 v5.3.4 Simulates the behavior of a web browser... symfony/cache v4.4.27 v5.3.8 Provides an extended PSR-6, PSR-16 (and... symfony/cache-contracts v2.4.0 v2.4.0 Generic abstractions related to caching symfony/config v4.4.27 v5.3.4 Helps you find, load, combine, autofill... symfony/console v4.4.29 v5.3.7 Eases the creation of beautiful and tes... symfony/css-selector v4.4.27 v5.3.4 Converts CSS selectors to XPath express... symfony/debug v4.4.27 v4.4.31 Provides tools to ease debugging PHP code symfony/debug-bundle v5.1.11 v5.3.4 Provides a tight integration of the Sym... symfony/dependency-injection v4.4.27 v5.3.8 Allows you to standardize and centraliz... symfony/deprecation-contracts v2.4.0 v2.4.0 A generic function and convention to tr... symfony/doctrine-bridge v4.4.27 v5.3.8 Provides integration for Doctrine with ... symfony/dom-crawler v5.3.4 v5.3.7 Eases DOM navigation for HTML and XML d... symfony/dotenv v4.4.29 v5.3.8 Registers environment variables from a ... symfony/error-handler v4.4.27 v5.3.7 Provides tools to manage errors and eas... symfony/event-dispatcher v4.4.27 v5.3.7 Provides tools that allow your applicat... symfony/event-dispatcher-contracts v1.1.9 v2.4.0 Generic abstractions related to dispatc... symfony/expression-language v4.4.27 v5.3.7 Provides an engine that can compile and... symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesy... symfony/finder v4.4.27 v5.3.7 Finds files and directories via an intu... symfony/flex v1.14.0 v1.16.3 Composer plugin for Symfony symfony/form v4.4.27 v5.3.8 Allows to easily create, process and re... symfony/framework-bundle v4.4.27 v5.3.8 Provides a tight integration between Sy... symfony/http-client v4.4.27 v5.3.8 Provides powerful methods to fetch HTTP... symfony/http-client-contracts v2.4.0 v2.4.0 Generic abstractions related to HTTP cl... symfony/http-foundation v5.3.6 v5.3.7 Defines an object-oriented layer for th... symfony/http-kernel v4.4.29 v5.3.9 Provides a structured process for conve... symfony/intl v4.4.27 v5.3.8 Provides a PHP replacement layer for th... symfony/messenger v4.4.27 v5.3.9 Helps applications send and receive mes... symfony/mime v5.3.4 v5.3.8 Allows manipulating MIME messages symfony/monolog-bridge v4.4.27 v5.3.7 Provides integration for Monolog with v... symfony/monolog-bundle v3.4.0 v3.7.0 Symfony MonologBundle symfony/notifier v5.0.8 v5.3.9 A library to notify messages symfony/options-resolver v4.4.27 v5.3.7 Provides an improved replacement for th... symfony/orm-pack v1.0.8 v2.1.0 A pack for the Doctrine ORM symfony/phpunit-bridge v5.3.4 v5.3.8 Provides utilities for PHPUnit, especia... symfony/polyfill-ctype v1.23.0 v1.23.0 Symfony polyfill for ctype functions symfony/polyfill-iconv v1.12.0 v1.23.0 Symfony polyfill for the Iconv extension symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* ... symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related... symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_asci... symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer ... symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring exten... symfony/polyfill-php56 v1.20.0 v1.20.0 Symfony polyfill backporting some PHP 5... symfony/polyfill-php72 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7... symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7... symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8... symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8... symfony/process v4.4.27 v5.3.7 Executes commands in sub-processes symfony/property-access v5.3.4 v5.3.8 Provides functions to read and write fr... symfony/property-info v5.3.4 v5.3.8 Extracts information about PHP class' p... symfony/routing v4.4.27 v5.3.7 Maps an HTTP request to a set of config... symfony/security-bundle v4.4.27 v5.3.8 Provides a tight integration of the Sec... symfony/security-core v4.4.29 v5.3.8 Symfony Security Component - Core Library symfony/security-csrf v5.3.4 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v4.4.27 v5.3.7 Symfony Security Component - Guard symfony/security-http v4.4.27 v5.3.8 Symfony Security Component - HTTP Integ... symfony/serializer v4.4.27 v5.3.8 Handles serializing and deserializing d... symfony/service-contracts v2.4.0 v2.4.0 Generic abstractions related to writing... symfony/stopwatch v5.3.4 v5.3.4 Provides a way to profile code symfony/string v5.3.3 v5.3.7 Provides an object-oriented API to stri... symfony/swiftmailer-bundle v3.5.2 v3.5.2 Symfony SwiftmailerBundle symfony/templating v4.4.27 v5.3.7 Provides all the tools needed to build ... symfony/translation v4.4.27 v5.3.9 Provides tools to internationalize your... symfony/translation-contracts v2.4.0 v2.4.0 Generic abstractions related to transla... symfony/twig-bridge v4.4.27 v5.3.7 Provides integration for Twig with vari... symfony/twig-bundle v4.4.27 v5.3.4 Provides a tight integration of Twig in... symfony/validator v4.4.29 v5.3.8 Provides tools to validate values symfony/var-dumper v5.3.6 v5.3.8 Provides mechanisms for walking through... symfony/var-exporter v5.3.4 v5.3.8 Allows exporting any serializable PHP d... symfony/web-link v4.4.27 v5.3.4 Manages links between resources symfony/web-profiler-bundle v5.0.11 v5.3.8 Symfony WebProfilerBundle symfony/webpack-encore-bundle v1.12.0 v1.12.0 Integration with your Symfony app & Web... symfony/yaml v4.4.29 v5.3.6 Loads and dumps YAML files ```
PHP version
Subject
CDN path missing when asking public URL for a file provider reference context .
Pretty sure there is a missing
returnat line 197.https://github.com/sonata-project/SonataMediaBundle/blob/d30dcd295f4a10833cf77d8360759bb66cae054a/src/Provider/FileProvider.php#L194-L201
I can open a PR but I'm not sure how to cover this with a test.