sonata-project / SonataMediaBundle

Symfony SonataMediaBundle
https://docs.sonata-project.org/projects/SonataMediaBundle
MIT License
451 stars 495 forks source link

Added new properties to media classes that cause type and accessibility errors #2224

Closed byhaskell closed 2 years ago

byhaskell commented 2 years ago

Environment

Sonata packages

show

``` sonata-project/admin-bundle 4.4.0 4.4.0 The missing Symfony Admin Generator sonata-project/block-bundle 4.8.0 4.8.0 Symfony SonataBlockBundle sonata-project/cache 2.2.0 2.2.0 Cache library sonata-project/doctrine-extensions 1.15.0 1.15.0 Doctrine2 behavioral extensions sonata-project/doctrine-orm-admin-bundle 4.2.0 4.2.0 Integrate Doctrine ORM into the SonataAdminBundle sonata-project/exporter 2.9.1 2.9.1 Lightweight Exporter library sonata-project/form-extensions 1.12.3 1.12.3 Symfony form extensions sonata-project/media-bundle 4.0.0-alpha1 4.0.0-RC2 Symfony SonataMediaBundle sonata-project/twig-extensions 1.9.0 1.9.0 Sonata twig extensions ```

Symfony packages

show

``` symfony/asset v5.3.11 v5.3.11 Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files symfony/browser-kit v5.3.4 v5.3.4 Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically symfony/cache v5.3.12 v5.3.12 Provides an extended PSR-6, PSR-16 (and tags) implementation symfony/cache-contracts v2.5.0 v2.5.0 Generic abstractions related to caching symfony/config v5.3.11 v5.3.11 Helps you find, load, combine, autofill and validate configuration values of any kind symfony/console v5.3.11 v5.3.11 Eases the creation of beautiful and testable command line interfaces symfony/css-selector v5.3.4 v5.3.4 Converts CSS selectors to XPath expressions symfony/debug-bundle v5.3.4 v5.3.4 Provides a tight integration of the Symfony Debug component into the Symfony full-stack framework symfony/dependency-injection v5.3.11 v5.3.11 Allows you to standardize and centralize the way objects are constructed in your application symfony/deprecation-contracts v2.5.0 v2.5.0 A generic function and convention to trigger deprecation notices symfony/doctrine-bridge v5.3.11 v5.3.11 Provides integration for Doctrine with various Symfony components symfony/dom-crawler v5.3.7 v5.3.7 Eases DOM navigation for HTML and XML documents symfony/dotenv v5.3.10 v5.3.10 Registers environment variables from a .env file symfony/error-handler v5.3.11 v5.3.11 Provides tools to manage errors and ease debugging PHP code symfony/event-dispatcher v5.3.11 v5.3.11 Provides tools that allow your application components to communicate with each other by dispatching events and listening to them symfony/event-dispatcher-contracts v2.5.0 v2.5.0 Generic abstractions related to dispatching event symfony/expression-language v5.3.11 v5.3.11 Provides an engine that can compile and evaluate expressions symfony/filesystem v5.3.4 v5.3.4 Provides basic utilities for the filesystem symfony/finder v5.3.7 v5.3.7 Finds files and directories via an intuitive fluent interface symfony/flex v1.17.5 v1.17.5 Composer plugin for Symfony symfony/form v5.3.11 v5.3.11 Allows to easily create, process and reuse HTML forms symfony/framework-bundle v5.3.11 v5.3.11 Provides a tight integration between Symfony components and the Symfony full-stack framework symfony/http-client v5.3.11 v5.3.11 Provides powerful methods to fetch HTTP resources synchronously or asynchronously symfony/http-client-contracts v2.5.0 v2.5.0 Generic abstractions related to HTTP clients symfony/http-foundation v5.3.11 v5.3.11 Defines an object-oriented layer for the HTTP specification symfony/http-kernel v5.3.12 v5.3.12 Provides a structured process for converting a Request into a Response symfony/intl v5.3.11 v5.3.11 Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library symfony/mailer v5.3.9 v5.3.9 Helps sending emails symfony/maker-bundle v1.36.3 v1.36.3 Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing boilerplate code. symfony/mime v5.3.11 v5.3.11 Allows manipulating MIME messages symfony/monolog-bridge v5.3.7 v5.3.7 Provides integration for Monolog with various Symfony components symfony/monolog-bundle v3.7.1 v3.7.1 Symfony MonologBundle symfony/notifier v5.3.11 v5.3.11 Sends notifications via one or more channels (email, SMS, ...) symfony/options-resolver v5.3.7 v5.3.7 Provides an improved replacement for the array_replace PHP function symfony/password-hasher v5.3.8 v5.3.8 Provides password hashing utilities symfony/phpunit-bridge v5.3.11 v5.3.11 Provides utilities for PHPUnit, especially user deprecation notices management symfony/polyfill-intl-grapheme v1.23.1 v1.23.1 Symfony polyfill for intl's grapheme_* functions symfony/polyfill-intl-icu v1.23.0 v1.23.0 Symfony polyfill for intl's ICU-related data and classes symfony/polyfill-intl-idn v1.23.0 v1.23.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions symfony/polyfill-intl-normalizer v1.23.0 v1.23.0 Symfony polyfill for intl's Normalizer class and related functions symfony/polyfill-mbstring v1.23.1 v1.23.1 Symfony polyfill for the Mbstring extension symfony/polyfill-php73 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions symfony/polyfill-php80 v1.23.1 v1.23.1 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions symfony/polyfill-php81 v1.23.0 v1.23.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions symfony/process v5.3.12 v5.3.12 Executes commands in sub-processes symfony/property-access v5.3.8 v5.3.8 Provides functions to read and write from/to an object or array using a simple string notation symfony/property-info v5.3.8 v5.3.8 Extracts information about PHP class' properties using metadata of popular sources symfony/proxy-manager-bridge v5.3.11 v5.3.11 Provides integration for ProxyManager with various Symfony components symfony/routing v5.3.11 v5.3.11 Maps an HTTP request to a set of configuration variables symfony/runtime v5.3.11 v5.3.11 Enables decoupling PHP applications from global state symfony/security-acl v3.2.0 v3.2.0 Symfony Security Component - ACL (Access Control List) symfony/security-bundle v5.3.12 v5.3.12 Provides a tight integration of the Security component into the Symfony full-stack framework symfony/security-core v5.3.11 v5.3.11 Symfony Security Component - Core Library symfony/security-csrf v5.3.4 v5.3.4 Symfony Security Component - CSRF Library symfony/security-guard v5.3.7 v5.3.7 Symfony Security Component - Guard symfony/security-http v5.3.11 v5.3.11 Symfony Security Component - HTTP Integration symfony/serializer v5.3.12 v5.3.12 Handles serializing and deserializing data structures, including object graphs, into array structures or other formats like XML and JSON. symfony/service-contracts v2.5.0 v2.5.0 Generic abstractions related to writing services symfony/stopwatch v5.3.4 v5.3.4 Provides a way to profile code symfony/string v5.3.10 v5.3.10 Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way symfony/translation v5.3.11 v5.3.11 Provides tools to internationalize your application symfony/translation-contracts v2.5.0 v2.5.0 Generic abstractions related to translation symfony/twig-bridge v5.3.11 v5.3.11 Provides integration for Twig with various Symfony components symfony/twig-bundle v5.3.10 v5.3.10 Provides a tight integration of Twig into the Symfony full-stack framework symfony/validator v5.3.12 v5.3.12 Provides tools to validate values symfony/var-dumper v5.3.11 v5.3.11 Provides mechanisms for walking through any arbitrary PHP variable symfony/var-exporter v5.3.11 v5.3.11 Allows exporting any serializable PHP data structure to plain PHP code symfony/web-link v5.3.4 v5.3.4 Manages links between resources symfony/web-profiler-bundle v5.3.8 v5.3.8 Provides a development tool that gives detailed information about the execution of any request symfony/yaml v5.3.11 v5.3.11 Loads and dumps YAML files ```

PHP version

PHP 7.4.21 (cli) (built: Jun 29 2021 18:06:27) ( ZTS Visual C++ 2017 x64 )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

Subject

Hello. After running the "php bin/console make:entity --regenerate App" command, additional properties began to be added to the media classes: SonataMediaGallery: galleryItems SonataMediaGalleryItem: gallery, media SonataMediaMedia: galleryItems Methods are added as private, which already causes a syntax error. If you make it a public property - and generate the methods, you get an error - Compile Error: Cannot override final method Sonata \ MediaBundle \ Model \ Gallery :: getGalleryItems () - This bug propagates to the version - 4.0.0-RC1, and 4.0.0-RC2. For version 4.0.0-alpha1, the type of input data in methods is no longer comparable. And so on for all generated methods. This is available in versions 4.0.0-alpha1, 4.0.0-RC1, and 4.0.0-RC2.

Steps to reproduce

  1. Install version 4.0.0-alpha1, 4.0.0-RC1 or 4.0.0-RC2.
  2. Create three media classes: SonataMediaGallery, SonataMediaGalleryItem and SonataMediaMedia from documentation (https://docs.sonata-project.org/projects/SonataMediaBundle/en/4.x/reference/installation/#configuration).
  3. Run the command and see the changes "php bin/console make:entity --regenerate App"

Expected results

No need for added links (which is most likely needed) or fix for accessibility and types.

Actual results

Initially: "Access level to 'SonataMediaGallery::$galleryItems' must be 'protected' (as in class 'Gallery') or weaker" After that, an error appears on the types in the created methods: SonataMediaGalleryItem: "Declaration must be compatible with GalleryItemInterface-> setGallery ([gallery: null | \ Sonata \ MediaBundle \ Model \ GalleryInterface = null])" SonataMediaGallery: "Declaration must be compatible with GalleryInterface->addGalleryItem(galleryItem: \Sonata\MediaBundle\Model\GalleryItemInterface) "

byhaskell commented 2 years ago

The problem goes away and sometimes reappears. I'll close it for now. I follow, I'm sorry.