sonata-project / SonataMediaBundle

Symfony SonataMediaBundle
https://docs.sonata-project.org/projects/SonataMediaBundle
MIT License
451 stars 495 forks source link

error on BaseMediaAdmin #235

Closed fidelio314 closed 11 years ago

fidelio314 commented 11 years ago

i found this exception:

[ErrorException]
Runtime Notice: Declaration of Sonata\MediaBundle\Admin\BaseMediaAdmin::configureSideMenu() should be compatible with that of Sonata\AdminBundle\Admin\Admin::configureSideMenu() in /home/fidelio/work/
azurshop-test2/vendor/sonata-project/media-bundle/Sonata/MediaBundle/Admin/BaseMediaAdmin.php line 26

is due to the commit 941c2f73ce87a318f6bab9a24fb1ac06b2cb03b2

https://github.com/sonata-project/SonataAdminBundle/pull/1037

you should change the method configureSideMenu in Sonata\MediaBundle\Admin\BaseMediaAdmin

change protected function configureSideMenu(MenuItemInterface $menu, $action, Admin $childAdmin = null)

to

protected function configureSideMenu(MenuItemInterface $menu, $action, AdminInterface $childAdmin = null)

rande commented 11 years ago

Please update the media bundle base code : https://github.com/sonata-project/SonataMediaBundle/commit/25b99ea3820f483d22149a89969cec46923d1542