coryjb
commented
10 years ago I extended ImageProvider to remove thumbnails in preRemove() rather than postRemove(). I did not submit a PR for the bundle, though, as the issue remains with a null media ID after Doctrine2 removes the entity. The side effect is a lingering entity without a file.
<?php
namespace Mobile\MediaBundle\Provider;
use Sonata\MediaBundle\Model\MediaInterface;
class ImageProvider extends \Sonata\MediaBundle\Provider\ImageProvider
{
/**
* Remove thumbnails before removing from database; bug in SonataMediaBundle that
* prevents media thumbnails from being removed because $id is null after
* Doctrine's remove() so the thumbnail file path is never contains the ID.
*/
public function preRemove(MediaInterface $media)
{
$path = $this->getReferenceImage($media);
if ($this->getFilesystem()->has($path)) {
$this->getFilesystem()->delete($path);
}
if ($this->requireThumbnails()) {
$this->thumbnail->delete($this, $media);
}
}
/**
* {@inheritdoc}
*/
public function postRemove(MediaInterface $media)
{
}
}
adc-scastro
rande
Filoz
xaben
Only the reference media is removed on S3 when removing a media entity. The source is in a Doctrine2 behavior when removing entities (http://www.doctrine-project.org/jira/browse/DDC-1680).
Essentially, the $id for the media entity is null in BaseMediaEventSubscriber::postRemove(). Sonata's FormatThumbnail::generatePrivateUrl() expects to find $id, but instead it generates something like default/01/0001/thumb__admin.jpg because the now removed entity's $id is null, so the thumbnail is never found.
I am working on a PR, but let me know if there's a better way to approach this.